Re: main [and, likely, stable/14]: do not set vfs.zfs.bclone_enabled=1 with that zpool feature enabled because it still leads to panics

On 09.09.2023 12:32, Mark Millard wrote:
> On Sep 8, 2023, at 21:54, Mark Millard <marklmi@yahoo.com> wrote:
>> On Sep 8, 2023, at 18:19, Mark Millard <marklmi@yahoo.com> wrote:
>>> On Sep 8, 2023, at 17:03, Mark Millard <marklmi@yahoo.com> wrote:
>>>> On Sep 8, 2023, at 15:30, Martin Matuska <mm@FreeBSD.org> wrote:
>>>> On 9. 9. 2023 0:09, Alexander Motin wrote:
>>>>> Thank you, Martin.  I was able to reproduce the issue with your script and found the cause.
>>>>>
>>>>> I first though the issue is triggered by the `cp`, but it appeared to be triggered by `cat`.  It also got copy_file_range() support, but later than `cp`.  That is probably why it slipped through testing.  This patch fixes it for me: https://github.com/openzfs/zfs/pull/15251 .
>>>>>
>>>>> Mark, could you please try the patch?
> 
> I finally stopped it at 7473 built (a little over 13 hrs elapsed):
> 
> ^C[13:08:30] Error: Signal SIGINT caught, cleaning up and exiting
> [main-amd64-bulk_a-default] [2023-09-08_19h51m52s] [sigint:] Queued: 34588 Built: 7473  Failed: 23    Skipped: 798   Ignored: 335   Fetched: 0     Tobuild: 25959  Time: 13:08:26
> [13:08:30] Logs: /usr/local/poudriere/data/logs/bulk/main-amd64-bulk_a-default/2023-09-08_19h51m52s
> [13:08:31] Cleaning up
> [13:17:10] Unmounting file systems
> Exiting with status 1
> 
> In part that was more evidence for deadlocks at least being fairly
> rare as well.
> 
> None of the failed ones looked odd. (A fair portion are because the
> bulk -a was mostly doing WITH_DEBUG= builds. Many upstreams change
> library names, some other file names, or paths used for debug
> builds and ports generally do not cover well building the debug
> builds for such. I've used these runs to extend my list of
> exceptions that avoid using WITH_DEBUG .) So no evidence of
> corruptions.

Thank you, Mark.  The patch was accepted upstream and merged to both 
master and zfs-2.2-release branches.

-- 
Alexander Motin