From nobody Thu Sep 07 19:40:36 2023 X-Original-To: freebsd-stable@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4RhV3B3NWjz4sPdR for ; Thu, 7 Sep 2023 19:40:54 +0000 (UTC) (envelope-from marklmi@yahoo.com) Received: from sonic312-24.consmr.mail.gq1.yahoo.com (sonic312-24.consmr.mail.gq1.yahoo.com [98.137.69.205]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 4RhV3B2D3qz4GW5 for ; Thu, 7 Sep 2023 19:40:54 +0000 (UTC) (envelope-from marklmi@yahoo.com) Authentication-Results: mx1.freebsd.org; none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1694115651; bh=M+MqA0csUHMUaWxa+zSanbioXgAJKG3pyTcBMhnMQXE=; h=Subject:From:In-Reply-To:Date:Cc:References:To:From:Subject:Reply-To; b=ExvcDhzXWBaMgD1BTMceAMM1v4sBmIiZsOgiuygpyy/Q7NcOyD0v/fHqeZLn5DiwcHCGZjqOEpp2PjteP6HUnkFs5fNwpHD26cW/EoPhyA69f2uthPWVLaNTQzcU4kp4dIG94Wgc7nBeF7o9apiz+WuEv6Fp4WZe7Y166ZG2Gs1bPN03zk7ZjxBeouBivpBXLgY2L85mObIFwgyL0bFtYK5s0u+xfQomAeLR0TIHXa7uSOesGinb9SBUGgpPqrfMdJ1jYM/V1bi7soovekgN4iSChdPShejYW0ZrO7C1Ou7hWEMwjTo7qlekZ9vP6rHCcjpMj4QZjfZ63dtfXIZBdw== X-SONIC-DKIM-SIGN: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1694115651; bh=5uzItdXMPZXlqsvxzllCppFn3A7G0dLXEP8QXshmaEp=; h=X-Sonic-MF:Subject:From:Date:To:From:Subject; b=L0zLWaGAGoH19IMAqcMDWN7XD+/RMH0xYERyyIW7G7pJduSWghw8zi+1DS/r2IdUiRtAtBc11jonl4bsgY4jrZRfsvHs09S3s6dwxTnZyZAmtZj72uK6JqfqSWiLRD8Mw1AAOQbLLqHdgpLqa2wROfT2mNESKS1xbeVd0/dtr1AJxLB24pz50MA4cwGpv0BcZzYAAgyojvl6GCV3lCmyu7gq2s/cnIx/Fr+HZWK8s9yOv5Kdv4URVXXNKTniFNd4e0iDK247VKUvMWsM4R2mVRbKcioUwlrnkMBwQ+sBVhvEwaIUEjwJN0HPRwvglNDX9nBEv9ZBEvEgWiy8KifKsQ== X-YMail-OSG: XfCKd1UVM1mudsCeWaOX7hcoInv9rDMsEctY7fRMQvjpPpkFMfGLotROk51fY_t 95BdEfhaadg9fqfa77JsPiRs2LUL8vOjbcqT6JeVPoEmYiS7PrYy.tMFM4CKXn5CashVKqhL49tC yWrWyAyDCKZYrRFa6F3IimisOlEgu03Xq245g.l.sQV4rNAuWuu2AzGF5PXFO4TJUKcWaEhQYy72 3qqSfckpjt4EHBftR.DLN79w1L3O4UiXnIa1muZfXwQmDdC7wMjkTFmajWT5SziTISYG16q3lE0b o4U1x6qYjUX4bqwuU1_oGvqQkr0k83qhJ5bsazyEZpJqxvR2EOK04BFhnTwh3MrK3i4fyu9XKcLD .6z4tgUJc3xp1atCPPwgk27itEqoeyTXGnJQAbDDWb5XU8CNuYF15CDDNKrU3E2sQO2YbmHLIdrn 9G2cnyycFMlmGl4Api2AHKHjLnaZ4YNsshoWYnSNCq2jm.uyV.I4ZpD_j49OGftKHS5waevCi1EX 0dDicyM.UN3GBnHi_zWibgAD3UQ1OjQWVg1f50VzHque17xp76gGxeEwsD9foKyE4bod0.KWfnrU vsnk48BKdlEIhq.OGrQCkwrk92qsAIezjnfEpxLxuh9kPL8A2u2327ygF.ncOOc_J8oHFGZMo.ZQ gzSMwGvPDZmbX0TZMhBTHIMNvSAidG7Q16PCEMt3eyqhGV28xe3kfInlgI.n56kTXi6Tci0jL55u gomFAAR0o0ArF0oVOG7QA8I0BVc9zS2BKr3E1mBiphsrzqVDXwk8sy25ASSzsHLsX07FcyiUXBer p2ucCg.MGWxSBmfhUXd.ykeclhnqI9gpTCjWeQQKtQCjLfW1bHFSoxmqnswyn.f5nMpfYZkKBi83 3QtWuD1H9MiAsCrZPwaBk5T.ToXu5lt8Wpa74q8GqFQXCHRzhTMQkwLL.MkNFHlCOd1AVgaTXTzD RWqVEjzumWrvhQHfmD_bd_h1fqPiP4iw1R.PMlt.6RO1W2XJznfheMPyl158D_nptz0JYzRs2I1F mwWL3iLODzIenL1GSVMYUqE1oydAQQ_GNXNT_F7kQ3kTGlFWXMeJ9_k4ViXoaq2mQuqdLMex9jcl VVoGmxCEzooHvUsQOihlHMgvfD7A2kBnsUi94liIjNNfqM4z6UnPGJ2f0wRXS0y2zDEHJRPPqWSy TVZiyjas2R36tDQn1tSXRupNydbztFtTnNoNgZY9IPqptZtWmnAMzgRn4YQe4Sz92iV6g4on2Ndh iwXI0MIxqEqVQeigqoMZzxfPM5Fyt2JT66aak1l1LTaSnvMarXV4EP30aIX7sWXvKmd2HeMimuUI MoSg_H5xuDJVT6gPuNYge2DnD_P8VnN924P7o20FfDYM6dj6x..biD52HvfBs_Rtg48nbHMH.lIe rDSkMzMPMAvOf2v6sCI4tf5OFI5Lu23uHx0PQI08VggWVLvkYCwmC_5YBCKyvOO2qBUPcdrRJS8s yaTjfBi0e3hSEaTb3GFHap90Y.gppH8L6OIIiuj_UynyftrYP4jEAlC2g2XyNfJQH28TDCeQIWQx Iq0xuNmM.t.7CA4aaPyKrDvj_a2wGqLZPLrcQrx9Ki5vnXGGuWL9twZSKnjC5ACo0TBWGuU3_ZyM e1OH40L4371OZgni8rxJbcb2g00AL9nxW3jba.jg5UjggDN3OwAJj0hrQ.gnyK9VqnuSIAhD.QqO J8NzlMsfvAJpE7bZUp884aDX5GioytjHJYUbNLGgL._Bo8uAmytBRhNP6cKov.N7NEC4IaQP6.mA JEcWGo5w1ssQW_NOvC.xLbdkkbPsny8bOyze6vrJ1sW6KUhqjqFt0kHdaaMFmvQAmKKTsZWCZwEh 7XNaECEwtjRH3A3p85dUTOF9T9g4pwbtYjURftG3qVXxNnJ_xQ7kLoUCyuR0ck_EmI9_c_nNalbY VvhlSR7siflFU5744xfy1ndHGSeCqskPMjF4IVZLrrlfQCRzFNTYP3xwBBxuqoUTXQu9aRCERvab WWx11u0TMOyBT7TUz2geTC5X69SOq0WpdapAoDdOSJPaCbAOkw15guI2fvq92AajFRZE1eCjEjl5 C6SHQYZWB2R4dTmU_vC1tmlyXE8_ZmDNcin_CmHo9tXqgY.x.a5rxkPtquUDmYAnUQxVh9bAiBQZ uftSTs7vfBnDsPs1hUWoOUf8ZTBV2OZQ.IMrSwHCSwjdI6uKg0hBgvDZt0cQkvapf.rE1OXDf7ic yxmP9ZkoM62x4dcGtJwxR0JSVro07P0aloVeC6VAgCSXG53XNO4T_PTHnvgd57.P7vMPGxuxux7b sr9CQYPAUTfQtnOg- X-Sonic-MF: X-Sonic-ID: 18bdaa88-2da8-4fe7-af1d-7060ca596b3b Received: from sonic.gate.mail.ne1.yahoo.com by sonic312.consmr.mail.gq1.yahoo.com with HTTP; Thu, 7 Sep 2023 19:40:51 +0000 Received: by hermes--production-gq1-6b7c87dcf5-qfzfj (Yahoo Inc. Hermes SMTP Server) with ESMTPA ID f3670204f7cff43689bc2a6e6d8c3804; Thu, 07 Sep 2023 19:40:47 +0000 (UTC) Content-Type: text/plain; charset=us-ascii List-Id: Production branch of FreeBSD source code List-Archive: https://lists.freebsd.org/archives/freebsd-stable List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-freebsd-stable@freebsd.org X-BeenThere: freebsd-stable@freebsd.org Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3731.700.6\)) Subject: Re: main [and, likely, stable/14]: do not set vfs.zfs.bclone_enabled=1 with that zpool feature enabled because it still leads to panics From: Mark Millard In-Reply-To: <20230907184823.GC4090@FreeBSD.org> Date: Thu, 7 Sep 2023 12:40:36 -0700 Cc: Current FreeBSD , FreeBSD-STABLE Mailing List , Pawel Jakub Dawidek , Alexander Motin Content-Transfer-Encoding: quoted-printable Message-Id: References: <7CE2CAAF-8BB0-4422-B194-4A6B0A4BC12C@yahoo.com> <08B7E72B-78F1-4ACA-B09D-E8C34BCE2335@yahoo.com> <20230907184823.GC4090@FreeBSD.org> To: Glen Barber , Martin Matuska X-Mailer: Apple Mail (2.3731.700.6) X-Spamd-Bar: ---- X-Rspamd-Pre-Result: action=no action; module=replies; Message is reply to one we originated X-Spamd-Result: default: False [-4.00 / 15.00]; REPLY(-4.00)[]; ASN(0.00)[asn:36647, ipnet:98.137.64.0/20, country:US] X-Rspamd-Queue-Id: 4RhV3B2D3qz4GW5 On Sep 7, 2023, at 11:48, Glen Barber wrote: > On Thu, Sep 07, 2023 at 11:17:22AM -0700, Mark Millard wrote: >> When I next have time, should I retry based on a more recent >> vintage of main that includes 969071be938c ? >>=20 >=20 > Yes, please, if you can. As stands, I rebooted that machine into my normal enviroment, so the after-crash-with-dump-info context is preserved. I'll presume lack of a need to preserve that context unless I hear otherwise. (But I'll work on this until later today.) Even my normal environment predates the commit in question by a few commits. So I'll end up doing a more general round of updates overall. Someone can let me know if there is a preference for debug over non-debug for the next test run. Looking at "git: 969071be938c - main", the relevant part seems to be just (white space possibly not preserved accurately): diff --git a/sys/kern/vfs_vnops.c b/sys/kern/vfs_vnops.c index 9fb5aee6a023..4e4161ef1a7f 100644 --- a/sys/kern/vfs_vnops.c +++ b/sys/kern/vfs_vnops.c @@ -3076,12 +3076,14 @@ vn_copy_file_range(struct vnode *invp, off_t = *inoffp, struct vnode *outvp, goto out; =20 /* - * If the two vnode are for the same file system, call + * If the two vnodes are for the same file system type, call * VOP_COPY_FILE_RANGE(), otherwise call = vn_generic_copy_file_range() - * which can handle copies across multiple file systems. + * which can handle copies across multiple file system types. */ *lenp =3D len; - if (invp->v_mount =3D=3D outvp->v_mount) + if (invp->v_mount =3D=3D outvp->v_mount || + strcmp(invp->v_mount->mnt_vfc->vfc_name, + outvp->v_mount->mnt_vfc->vfc_name) =3D=3D 0) error =3D VOP_COPY_FILE_RANGE(invp, inoffp, outvp, = outoffp, lenp, flags, incred, outcred, fsize_td); else That looks to call VOP_COPY_FILE_RANGE in more contexts and vn_generic_copy_file_range in fewer. The backtrace I reported involves: VOP_COPY_FILE_RANGE So it appears this change is unlikely to invalidate my test result, although failure might happen sooner if more VOP_COPY_FILE_RANGE calls happen with the newer code. That in turns means that someone may come up with some other change for me to test by the time I get around to setting up another test. Let me know if so. =3D=3D=3D Mark Millard marklmi at yahoo.com