From nobody Fri Nov 17 22:51:40 2023 X-Original-To: freebsd-stable@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4SXBwb5glRz51SHC for ; Fri, 17 Nov 2023 22:51:43 +0000 (UTC) (envelope-from wollman@hergotha.csail.mit.edu) Received: from hergotha.csail.mit.edu (tunnel82308-pt.tunnel.tserv4.nyc4.ipv6.he.net [IPv6:2001:470:1f06:ccb::2]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "garrett.wollman.name", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4SXBwb1wMZz4KGf for ; Fri, 17 Nov 2023 22:51:43 +0000 (UTC) (envelope-from wollman@hergotha.csail.mit.edu) Authentication-Results: mx1.freebsd.org; dkim=none; spf=pass (mx1.freebsd.org: domain of wollman@hergotha.csail.mit.edu designates 2001:470:1f06:ccb::2 as permitted sender) smtp.mailfrom=wollman@hergotha.csail.mit.edu; dmarc=fail reason="SPF not aligned (relaxed), No valid DKIM" header.from=bimajority.org (policy=none) Received: from hergotha.csail.mit.edu (localhost [127.0.0.1]) by hergotha.csail.mit.edu (8.17.1/8.17.1) with ESMTPS id 3AHMpflP096086 (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384 bits=256 verify=NO); Fri, 17 Nov 2023 17:51:42 -0500 (EST) (envelope-from wollman@hergotha.csail.mit.edu) Received: (from wollman@localhost) by hergotha.csail.mit.edu (8.17.1/8.17.1/Submit) id 3AHMpf39096085; Fri, 17 Nov 2023 17:51:41 -0500 (EST) (envelope-from wollman) List-Id: Production branch of FreeBSD source code List-Archive: https://lists.freebsd.org/archives/freebsd-stable List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-freebsd-stable@freebsd.org X-BeenThere: freebsd-stable@freebsd.org MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Message-ID: <25943.61052.819616.445139@hergotha.csail.mit.edu> Date: Fri, 17 Nov 2023 17:51:40 -0500 From: Garrett Wollman To: Mike Karels Cc: freebsd-stable@freebsd.org Subject: Re: NFS exports of ZFS snapshots broken In-Reply-To: <25943.60056.880614.452966@hergotha.csail.mit.edu> References: <25943.54632.572766.121032@hergotha.csail.mit.edu> <25943.60056.880614.452966@hergotha.csail.mit.edu> X-Mailer: VM 8.2.0b under 28.2 (amd64-portbld-freebsd13.2) X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.6.4 (hergotha.csail.mit.edu [0.0.0.0]); Fri, 17 Nov 2023 17:51:42 -0500 (EST) X-Spam-Status: No, score=-4.9 required=5.0 tests=ALL_TRUSTED, HEADER_FROM_DIFFERENT_DOMAINS,NICE_REPLY_A autolearn=disabled version=4.0.0 X-Spam-Checker-Version: SpamAssassin 4.0.0 (2022-12-14) on hergotha.csail.mit.edu X-Spamd-Result: default: False [-2.90 / 15.00]; NEURAL_HAM_MEDIUM(-1.00)[-1.000]; NEURAL_HAM_LONG(-1.00)[-1.000]; NEURAL_HAM_SHORT(-1.00)[-0.996]; FORGED_SENDER(0.30)[wollman@bimajority.org,wollman@hergotha.csail.mit.edu]; R_SPF_ALLOW(-0.20)[+ip6:2001:470:1f06:ccb::2]; MIME_GOOD(-0.10)[text/plain]; DMARC_POLICY_SOFTFAIL(0.10)[bimajority.org : SPF not aligned (relaxed), No valid DKIM,none]; MIME_TRACE(0.00)[0:+]; R_DKIM_NA(0.00)[]; ASN(0.00)[asn:6939, ipnet:2001:470::/32, country:US]; RCVD_COUNT_TWO(0.00)[2]; MLMMJ_DEST(0.00)[freebsd-stable@freebsd.org]; TO_MATCH_ENVRCPT_SOME(0.00)[]; FROM_NEQ_ENVFROM(0.00)[wollman@bimajority.org,wollman@hergotha.csail.mit.edu]; ARC_NA(0.00)[]; RCPT_COUNT_TWO(0.00)[2]; FREEFALL_USER(0.00)[wollman]; TO_DN_SOME(0.00)[]; FROM_HAS_DN(0.00)[]; RCVD_TLS_LAST(0.00)[] X-Rspamd-Queue-Id: 4SXBwb1wMZz4KGf X-Spamd-Bar: -- < Looking at this from the RPC side: > (PUTFH, GETATTR, LOOKUP(snapshotname), GETFH, GETATTR) > [NFS4_OK for all ops] > (PUTFH, GETATTR) > [NFS4_OK, NFS4_OK] > (PUTFH, ACCESS(0x3f), GETATTR) > [NFS4_OK, NFS4_OK, rights = 0x03, NFS4_OK] > (PUTFH, GETATTR, LOOKUPP, GETFH, GETATTR) > [NFS4_OK, NFS4_OK, NFS4ERR_NOFILEHANDLE] > and at this point the [EIO] is returned. For NFSv3, the client does a LOOKUP of the snapshot directory as before, then on the next round trip, the client calls ACCESS on the returned file handle and the server returns NFS3ERR_IO. GETATTR on the same file handle also returns NFS3ERR_IO. -GAWollman