From nobody Mon Nov 06 00:43:50 2023 X-Original-To: freebsd-stable@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4SNszv04cwz50JbK for ; Mon, 6 Nov 2023 00:44:11 +0000 (UTC) (envelope-from marklmi@yahoo.com) Received: from sonic310-22.consmr.mail.gq1.yahoo.com (sonic310-22.consmr.mail.gq1.yahoo.com [98.137.69.148]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 4SNszs3hHnz3TR0 for ; Mon, 6 Nov 2023 00:44:09 +0000 (UTC) (envelope-from marklmi@yahoo.com) Authentication-Results: mx1.freebsd.org; dkim=pass header.d=yahoo.com header.s=s2048 header.b=dPoAwVog; spf=pass (mx1.freebsd.org: domain of marklmi@yahoo.com designates 98.137.69.148 as permitted sender) smtp.mailfrom=marklmi@yahoo.com; dmarc=pass (policy=reject) header.from=yahoo.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1699231447; bh=ElsRvfQntq/MGlS5AjsCel9uwEsnSlX+Suz6tXeRV6Y=; h=Subject:From:In-Reply-To:Date:Cc:References:To:From:Subject:Reply-To; b=dPoAwVog0uy7wQp/3I/lzve83ZNpw9aswfi9EfpeSa/IO//9ESETReyREwk2CCAcdguJ1wwr1B09cU148f9NLf82K1nfnbuZYgxygOSqnQBPw5ny+6U48c+TRZRbsqjBh+trgleyO3gvXGCp2JaZZGFFg6vukYVfPWSYVz9GRIyp9/u7441OXPfugNWglv34SysJGfuBXTX1/SoX9KUrd/BOB+WvNp56WXvqeBMYdPx7NqXbVqHAYF/V2rBKH0yG+EsV43uEcTqlCzJwJJjVWd7+kZELQu93ZVIMkXf4ihyxO8BGS7iwGMcxIOP9cq0hZF4PqfCy767AmWpoh0s5KA== X-SONIC-DKIM-SIGN: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1699231447; bh=0edVvpF5HI2X8w2PhfMKQjamXwS6ikTkqP2P9tQK87f=; h=X-Sonic-MF:Subject:From:Date:To:From:Subject; b=eCVrmEcZXM4flFN3yQJO5ppUzpyFbr4JTg8L/WdTzbnB8dpYDI1vXic5OyaK7Y2fxE5k8qesugtmxXZskgPFz5BZCUUHlgFT6IExhbWqr+O9Ub4DTrt6GVjbZUef3AkiAGm07X5sGwAQUE27nDMRh9eNIbVISULaj6bYLlQh9lYjxBvK8772nn2mVRtJavdUykUXKTORJZ4zfTXR48eZa5JaLWT6UYaCT36/KOid9Tbaroxzn62FuU4+QczN8XtawofZjDx7ZMfY5qhLBC3+8SJ9gWXjgwPH2pD1bSxwvRctl0GKWQ91yzfgYXrfBI2R/FL2+PNTCPC3GzaPlGlEMw== X-YMail-OSG: yVNYL3kVM1m2ZgV9yti4jJtLW2TMIWeWbEYXsweXSUR.H_1koHbga4eFxT5UF_i nBv.g7w9tpsnWtfNH0zyDpDHzUS4_7bDXzy0kE.jHJOxjycuvsi_GT5cjgy0IEWbd5qlXWM8IT4W d3z9j_gwsN.p_0SMZKM2lIbnSE_eyYLjgch6u6pGjm51DTZitSwYFYmjSIY1ShFnBqoxkZRDqCEU ydSjm3ArN2EQWPFPDWIvgVKLIsiafZ6qpFpP3EqFPatl4baNHUBVH5kvAAb89Ye4wx.YApKcqmpT VWQZwrfWpWO36vgrNI0aYVAKiumpakhA5Y5ZD4hnD3qktvkg9UbtUYMdVJn3MZac7V9waQC0s_QR gm9pcoUJYmZXhpl1tFwPmo0LCEBDqEfGF_Qc0aUSK7YUxnJIA1SmVtVLW7K3aM5FJOCmrOLHgUYK qVWWcsgmYni8.MTfVHzl_lmDgcrLbA.p4e9YUgoVF3Ep6hzrO_cV_CSmsxUvYhyvo2hTUBBPykBC aby51kfQsg5nwGnLlj7kEoJu.8EBcKZox_JDzKydAs_M0tzu6bfdxwwp1i4UzgiyCueAUhSfhQK9 RjBFKOxKvSmjDwCNS3BnFhQE6syl0069DZVL3wSl8WVotGfDCIOTPVoU6hb7vRGXVwu39qS11vUF 1zPPpCgxY0XaPGct.o_fqDih6hKTZJgiqK9KM0i4Rr.wVZ5CVc7oVufZUiaERX0Sb00yot33umAX L_s47F0cgB9SYvEvE_IsmbIv2nBQbxKRc_i0GS.b_hbXLdiWBgtQUSIBdjUh86t3ajS2.2zuMKTG tobq5Ke2L50floCNDVUo1Z.F4W9EOnBQXSOh1d4mOPCPZnhMBWLCzl4Jr58A52CoexW0TLqYbBLi Y.V7ZVOmdINd8Jwpjd6v0uHlva4kA8SEg6Lge6VJeyEhOVq.fNj96XTSgzUDxKRVckTmVuvecs8Y jJQXNIiSW9X4PgLJuDDS3Teaob6NN7QACxu0KTXTQcuoUSOvid6M5EggwyvJLPOjBP7SGPA.SIkN PtUX_Bql2.191_yKDWrCGDUQmzLQj3pdC3EcIbXlz9DFVVcRgc.aTz4BT.w_WxIylXqEK9Vgj_.V vD2QC7vYx3DNVW0DVA5WhYqXI92ZKX0MPricPw7FKkAUAj4pxqi5wZUYguMHwDa6MP_qMPKCrevA buSy6VOSgcPmX0V7v5He2vwoayrMwanDljeh1IAsKuDAe4R7WRQd0Rcq8smgOaE8IWg_ayv0z3_v 4gTGjCTMustMyZSxetpyAYJxeMQh8K8n4fsAeBeS3WX5U6GC5hKoVJGJ5EYPEcjDm_1hWLcHaw4. AVRxLINmO.coA0u_vI6P5T.ptmurJ.WoOnqj3JUXa2H0A_mOvarmx3x39lQk57HcumXj.l9N_EaZ sWLQdX83o1PUURGh_D0x92CmwuU1dZR3o_GQnpSjkwX2PIMNaZ1FXvzM0b_1JkFNlejEjtVXc4kn nUFrj08rK69d.KYSaj7bK_8UiZeTdr.op8B5ML40bd7mWsVgzeh0XZUUEBbepoY4Qe3i8jz3uHuL DWd6jIM9MerMTz4BirPFpyb.6hdm3HyKHwHy3aSp7uVtJWM4BJcYL3fukJ80efHgga5h.1Dkpu2H 1Js7gqMWVxkRCnIXIWacyWsL0dkSZZWvV5lXrYGNnHzTy0aAxi21ShLsubKcrqneO1_rgXWbzF8U odvySrPh0aPGvoP2cW2xq8mu28IgBR9EPeeq1JZ0w_pjEWMkINaKJpH5XAkigdEr_FrNcJVyRlPI zBsRNYJVMM.X5neRochOlNjqLZkohvD1m4Ex6nNzAgdLLy1xvFSRr9afiq8Eqpu2LGY5P99w64Uq bWudSN1DA1Z0q2y26lbmCjQ9JLqmOgKfAODuRTgdmSrh5Auv_NPoowEkCUWtiVJFsqkYA2lYtkSx vXR2576SAXmOyuw2kg627ptWFuZ0c6YGq5SgSZDPxwlBS6e1gHhUpAYjxwFja_Pr2Uu0cKiesbFW 9g_vrDNeKcYHnqzuDhSKsg6wda4ayiuNxEcVP468GW5YF64Tl1LTVR5cj8vVFb6_dJXNyJvSo6d_ LojCk4to3HaV58ENUC_LyhO9YErs.82fB0LClcMkEdAZMoFAuDaOxoSon1r7K5I8ZPUb3L0812iQ DUPEHAzUwG0ObI5bIgE5X7qvDHyH4goFORmtoDd.koE4cTd1_3QRfTqeF77RlTm6FoRJz8ss4z82 J1Mo5Z5oMSweM5pqlxolvPqHuEZOkWkexvQTsbaEnfsX_VfQlEs_n9Rg1Hmc8i0GxERivGQhAu4M - X-Sonic-MF: X-Sonic-ID: da94b9b8-e415-49d4-a122-7e5ec7a500ea Received: from sonic.gate.mail.ne1.yahoo.com by sonic310.consmr.mail.gq1.yahoo.com with HTTP; Mon, 6 Nov 2023 00:44:07 +0000 Received: by hermes--production-ne1-56df75844-pr5zc (Yahoo Inc. Hermes SMTP Server) with ESMTPA ID 5020e09f3d3d5d67ad8183454b828498; Mon, 06 Nov 2023 00:44:02 +0000 (UTC) Content-Type: text/plain; charset=utf-8 List-Id: Production branch of FreeBSD source code List-Archive: https://lists.freebsd.org/archives/freebsd-stable List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-freebsd-stable@freebsd.org X-BeenThere: freebsd-stable@freebsd.org Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3774.200.91.1.1\)) Subject: Re: Is 14.0 to released based on 0 for sysctl vfs.zfs.bclone_enabled ? From: Mark Millard In-Reply-To: Date: Sun, 5 Nov 2023 16:43:50 -0800 Cc: Mike Karels , Ronald Klop , FreeBSD-STABLE Mailing List Content-Transfer-Encoding: quoted-printable Message-Id: References: <2F81D978-7DBD-42CE-8ECF-C020B0CB5C29.ref@yahoo.com> <2F81D978-7DBD-42CE-8ECF-C020B0CB5C29@yahoo.com> <7a906956-6836-421e-b25e-ff701369e3ed@FreeBSD.org> <830CD3A8-DB62-418D-A7F7-8DA6CB46B1F5@yahoo.com> To: =?utf-8?Q?Martin_Matu=C5=A1ka?= X-Mailer: Apple Mail (2.3774.200.91.1.1) X-Spamd-Result: default: False [-2.36 / 15.00]; SUBJECT_ENDS_QUESTION(1.00)[]; NEURAL_HAM_SHORT(-1.00)[-1.000]; NEURAL_HAM_LONG(-0.98)[-0.982]; NEURAL_HAM_MEDIUM(-0.87)[-0.873]; MV_CASE(0.50)[]; DMARC_POLICY_ALLOW(-0.50)[yahoo.com,reject]; R_DKIM_ALLOW(-0.20)[yahoo.com:s=s2048]; R_SPF_ALLOW(-0.20)[+ptr:yahoo.com]; MIME_GOOD(-0.10)[text/plain]; RCPT_COUNT_THREE(0.00)[4]; FROM_HAS_DN(0.00)[]; RCVD_VIA_SMTP_AUTH(0.00)[]; TO_MATCH_ENVRCPT_SOME(0.00)[]; RCVD_IN_DNSWL_NONE(0.00)[98.137.69.148:from]; BLOCKLISTDE_FAIL(0.00)[98.137.69.148:server fail]; MLMMJ_DEST(0.00)[freebsd-stable@freebsd.org]; ARC_NA(0.00)[]; ASN(0.00)[asn:36647, ipnet:98.137.64.0/20, country:US]; RWL_MAILSPIKE_POSSIBLE(0.00)[98.137.69.148:from]; DKIM_TRACE(0.00)[yahoo.com:+]; TO_DN_ALL(0.00)[]; FREEMAIL_FROM(0.00)[yahoo.com]; DWL_DNSWL_NONE(0.00)[yahoo.com:dkim]; FROM_EQ_ENVFROM(0.00)[]; FREEMAIL_ENVFROM(0.00)[yahoo.com]; MIME_TRACE(0.00)[0:+]; MID_RHS_MATCH_FROM(0.00)[]; RCVD_TLS_LAST(0.00)[]; RCVD_COUNT_TWO(0.00)[2] X-Rspamd-Queue-Id: 4SNszs3hHnz3TR0 X-Spamd-Bar: -- On Nov 5, 2023, at 16:27, Martin Matu=C5=A1ka wrote: > OpenZFS 2.2.0 in FreeBSD 14 fully supports block cloning. You can work = with pools that have feature@block_cloning enabled. > The sysctl variable vfs.zfs.bclone_enabled affects the behavior of = zfs_clone_range() which is called by copy_file_range(). When it is set = to 0, zfs_clone_range() does not do block cloning. > If it is set to anything else than 0, zfs_clone_range() does block = cloning (if all conditions are met - same ZFS pool, correct data = alignment, etc.). Ahh. =46rom the naming and vague memories of the history, I did not = understand that vfs.zfs.bclone_enabled has a narrower set of consequences than the name = suggests and vfs.zfs.bclone_enabled=3D0 does not imply any lack of support for = pools that have block cloning active. May be the wording at, for example = https://www.freebsd.org/releases/14.0R/relnotes/ should be more explicit about the relationships involved when = vfs.zfs.bclone_enabled=3D0 since others may read in the same bad interpretation that I did. Thanks for the note. Very helpful. > In FreeBSD-main, this tunable is enabled and I plan to enable it in = stable/14 somewhere around December 11, 2023. >=20 > As of today I personally use block cloning on all my systems. >=20 > mm >=20 > On 04/11/2023 13:35, Mark Millard wrote: >> On Nov 4, 2023, at 04:38, Mike Karels wrote: >>=20 >>> On 4 Nov 2023, at 4:01, Ronald Klop wrote: >>>=20 >>>> On 11/4/23 02:39, Mark Millard wrote: >>>>> It looks to me like releng/14.0 (as of 14.0-RC4) still has: >>>>>=20 >>>>> int zfs_bclone_enabled; >>>>> SYSCTL_INT(_vfs_zfs, OID_AUTO, bclone_enabled, CTLFLAG_RWTUN, >>>>> &zfs_bclone_enabled, 0, "Enable block cloning"); >>>>>=20 >>>>> leaving block cloning effectively disabled by default, no >>>>> matter what the pool has enabled. >>>>>=20 >>>>> https://www.freebsd.org/releases/14.0R/relnotes/ also reports: >>>>>=20 >>>>> QUOTE >>>>> OpenZFS has been upgraded to version 2.2. New features include: >>>>> =E2=80=A2 >>>>> block cloning, which allows shallow copies of blocks in file = copies. This is optional, and disabled by default; it can be enabled = with sysctl vfs.zfs.bclone_enabled=3D1. >>>>> END QUOTE >>>>>=20 >>>>=20 >>>> I think this answers your question in the subject. >>> I think so too (and I wrote that text). >> Thanks for the confirmation of the final intent. >>=20 >> I believe this makes: >>=20 >> QUOTE >> author Brian Behlendorf 2023-05-25 20:53:08 = +0000 >> committer GitHub 2023-05-25 20:53:08 +0000 >> commit 91a2325c4a0fbe01d0bf212e44fa9d85017837ce (patch) >> tree dd01dfce6aeef357ade1775acf18aade535c6271 >> . . . >> Update compatibility.d files >>=20 >> Add an openzfs-2.2 compatibility file for the next release. Edon-R = support has been enabled for FreeBSD removing the need for different = FreeBSD and Linux files. Symlinks for the -linux and -freebsd names are = created for any scripts expecting that convention. Additionally, a = symlink for ubunutu-22.04 was added. Signed-off-by: Brian Behlendorf = Closes #14833 >> END QUOTE >>=20 >> technically incorrect in that compatibility.d/openzfs-2.2-freebsd >> should be distinct in content from compatibility.d/openzfs-2.2 so >> that block cloning would not be enabled. >>=20 >>=20 >>>>> Just curiousity on my part about the default completeness of >>>>> openzfs-2.2 support, not an objection either way. >>>>>=20 >>>>=20 >>>> I haven't seen new issues with block cloning in the last few weeks = mentioned on the mailing lists. All known issues are fixed AFAIK. >>>> But I can imagine that the risk+effect ratio of data corruption is = seen as a bit too high for a 14.0 release for this particular feature. = That does not diminish the rest of the completeness of openzfs-2.2. >>>>=20 >>>> NB: I'm not involved in developing openzfs or the decision making = in the release. Just repeating what I read on the lists. >>> There was another block cloning fix in 14.0-RC4; see the commit log. >>> Maybe there will be no more issues, but it seems that corner cases = were >>> still being found recently. >> Looks like I'll stay at openzfs-2.1 pool features until there is >> a release that no longer has the default status: >>=20 >> 0 for sysctl vfs.zfs.bclone_enabled >>=20 >> I use main [so: 15 now] but only enable openzfs-2.* pool features >> supported by default on some FreeBSD release, that has an accurate >> compatibility.d/openzfs-2.*-freebsd file. >=20 =3D=3D=3D Mark Millard marklmi at yahoo.com