Re: stable/13 - amdgpu broken with n253286-d8a88ec38149
- Reply: Jonathan Vasquez : "Re: stable/13 - amdgpu broken with n253286-d8a88ec38149"
- Go to: [ bottom of page ] [ top of archives ] [ this month ]
Date: Sat, 17 Dec 2022 02:31:15 UTC
Hey Doug, Not a problem. I actually did clean rebuilds of everything, including pulling the latest ports and cleanly reinstalling drm-510-kmod and gpu-firmware-amd-kmod. But it still failed. Jonathan Vasquez PGP: 34DA 858C 1447 509E C77A D49F FB85 90B7 C4CA 5279 Sent with ProtonMail Secure Email Sent from Proton Mail mobile -------- Original Message -------- On Dec 16, 2022, 21:05, Doug Moore wrote: > Short answer - try rebuilding kmod from scratch. > > Long answer - I moved into stable/13 changes from main that changed some binary-level representations. One who found that the kmod he built before those changes no longer worked pointed out my error. So I made a change to stable/13 recently to restore the original representations, and satisfied that person’s complaint. But, someone who built kmod recently will find things broken, the way the original fellow did. I can only apologize and ask you to rebuild non-kernel stuff based on the stable/13 of more than a day ago. I hadn’t considered the impact of my changes on non-kernel code. > Doug > > Sent from my iPad > >> On Dec 16, 2022, at 6:50 PM, Jonathan Vasquez <jon@xyinn.org> wrote: > >> >> Hey all, >> >> it seems that my AMD Radeon 6900 XT doesn't load the amdgpu properly anymore. The machine will crash immediately upon load. After a bisect, I found the posted commit. This card uses the sienna_cichlid flavor for gpu-firmware-amd-kmod. >> >> commit d8a88ec381498f5942403088d28ee325b92e9a78 >> Author: Doug Moore <dougm@FreeBSD.org> >> Date: Fri Dec 16 03:15:28 2022 -0600 >> >> rb_tree: restore binary compat w/ 13 >> >> A change to RB_COLOR_INSERT, when merged into stable/13, broke binary >> compatibility. For 13, call the new function RB_DO_COLOR_INSERT, and >> restore the old function with the original name and parameters. Define >> RB_COLOR_INSERT in tree.h, and remove changes to the linux rbtree >> header. >> >> Another change altered the order of pointers in the RB_ENTRY struct. >> For 13, restore the original order. >> >> Reported by: manu >> Reviewed by: hselasky >> Tested by: manu >> Differential Revision: https://reviews.freebsd.org/D37716 >> >> sys/compat/linuxkpi/common/include/linux/rbtree.h | 11 ++---- >> sys/sys/tree.h | 46 ++++++++++++++++------- >> >> Jonathan Vasquez >> PGP: 34DA 858C 1447 509E C77A D49F FB85 90B7 C4CA 5279 >> Sent with ProtonMail Secure Email