Re: CAM IOCTL issue with 13.1-STABLE
- Reply: Warner Losh : "Re: CAM IOCTL issue with 13.1-STABLE"
- In reply to: Alexander Motin : "Re: CAM IOCTL issue with 13.1-STABLE"
- Go to: [ bottom of page ] [ top of archives ] [ this month ]
Date: Mon, 29 Aug 2022 18:00:28 UTC
On Tue, Aug 23, 2022 at 09:44:48AM -0400, Alexander Motin wrote: > Hi Matthew, > > I took a brief look on it and found that CAM compatibility code just > does not cover that IOCTL. That is why when CAM version was bumped it > cause the unexpected breakage. Short term fix would be to rebuild the > application to new CAM version, while for proper fix somebody would have > to implement the compatibility code for that IOCTL. I looked at this a bit more, and it seems trivial since 1) for periph drivers, CAMGETPASSTHRU ignores the input CCB, and 2) the CAM version bump from 0x19 to 0x1a does not affect XPT_GDEVLIST CCBs. Note for instance that cam_compat_handle_0x19() is a no-op for CAMGETPASSTHRU. So, isn't the patch here sufficient? https://reviews.freebsd.org/D36389 > On 22.08.2022 14:48, Matthew Grooms wrote: > > There appears to be a problem with XPT_DEV_MATCH CAM IOCTL calls. This > > prevents a bunch of packages on 13.1-STABLE from working correctly. A > > bug was filed and Mark J was kind enough to help diagnose the issue, but > > it's sitting in unassigned status. Can someone please assign it to the > > correct group so it gets some attention? > > > > The FreeBSD bug: > > https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=264709 > > > > The offending commit ( I think? ): > > https://cgit.freebsd.org/src/commit/sys/cam/cam_ccb.h?h=stable/13&id=7d7168478380f08b3a7fd58ca7cf83182fae6850 > > -- > Alexander Motin >