Re: FreeBSD Security Advisory FreeBSD-SA-23:02.openssh

Hi,

On Fri, 17 Feb 2023, at 13:28, Trond Endrestøl wrote:
> On Thu, 16 Feb 2023 19:47+0100, Michael Grimm wrote:
>
>> > On 16. Feb 2023, at 19:23, FreeBSD Security Advisories <security-advisories@freebsd.org> wrote:
>> 
>> […]
>> 
>> > Branch/path                             Hash                     Revision
>> > - -------------------------------------------------------------------------
>> > stable/13/                              296ec8eae0c8    stable/13-n260933
>> 
>> […]
>> 
>> > # git rev-list --count --first-parent HEAD
>> 
>> 254579
>> 
>> Typo or am I getting something wrong?

I thought so too.

> If you rebase your own local branch on the tip of the official branch, 
> then each occurance of rebasing counts as only one commit.

Not sure what you mean by this, or how it's relevant, or what it would imply.

> Searching for the commit hash is the better option.

Is the advice given in the security notice incorrect with respect to the revision number? Or is the method of checking incorrect? Both? A fresh clone of src a few minutes ago gives 254619 in response to 'git rev-list --count --first-parent HEAD'

# date
Sat Feb 18 14:46:15 GMT 2023
# pwd
/tmp
# git clone -q ssh://anongit@git.freebsd.org/src.git src
# cd src
# git checkout stable/13
Updating files: 100% (29235/29235), done.
branch 'stable/13' set up to track 'origin/stable/13'.
Switched to a new branch 'stable/13'
git rev-list --count --first-parent HEAD
254619

--