From nobody Tue Jul 05 19:31:14 2022 X-Original-To: scsi@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 29B291D01ED1 for ; Tue, 5 Jul 2022 19:31:26 +0000 (UTC) (envelope-from scottl@samsco.org) Received: from out5-smtp.messagingengine.com (out5-smtp.messagingengine.com [66.111.4.29]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 4Lct8D6NNXz3NBV; Tue, 5 Jul 2022 19:31:24 +0000 (UTC) (envelope-from scottl@samsco.org) Received: from compute5.internal (compute5.nyi.internal [10.202.2.45]) by mailout.nyi.internal (Postfix) with ESMTP id 1164D5C0102; Tue, 5 Jul 2022 15:31:18 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute5.internal (MEProxy); Tue, 05 Jul 2022 15:31:18 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=samsco.org; h=cc :cc:content-transfer-encoding:content-type:date:date:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to; s=fm1; t=1657049478; x= 1657135878; bh=/A7mUicWRdz4b4DgzfdUa9RMW9RNzZ4D7gKDzdFZ8hY=; b=M CxN0PkHwEbS+w4Wpvt3JJ2QA5MAjiD/l+SEvJy3ElpIKlhIISCmSyMfNNhnSJyXG 51JaVaw2VrXlBc3tf9+oR46k3jYEuznwDlccTdDBNDvR1mDRLxSD9PBqDSBxhrwJ nwrMuJjmxD6Nnc4iARQ8fFtCVfa+tPjRbvUhP0CkAlAtH4pq+c3bh2L/rTIqKtV3 aexS7SK+VcrxDjEv8YDYhtv5pZ8H4kH6jB+LRugcm/mmRZB2l5gDaIdrHsJYdJy9 UPMrYz/8xlZ0cZ0XDYCHlhp8HEavBvPz+fqoHSqdi9rEd/JPBDH0Ibg5LiGl4qHF jeMzvyG//1dXHhaqj+xLA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:date:date:feedback-id:feedback-id:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to:x-me-proxy:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm2; t=1657049478; x= 1657135878; bh=/A7mUicWRdz4b4DgzfdUa9RMW9RNzZ4D7gKDzdFZ8hY=; b=n dCyi+Y1F04pFqAi56l3oQll+ND5bufMILgROcqC3MwSgrkWAPbJCjhQV6y1Gl/G9 1OZ/OlaGZoHyGyfr6zwi2p6adaEhSAZSJU1KTmjywcfiznNCZDfD7QFF90NEBNbF vE505/z9ZdslLgEPiwilys871OmLgH9F1HmfKdM7SnDJ11fFrkeHlvGm9YAJ71Wf 5wVi+u3Kfm8sS+dTaSB7SSk9R5Jt7RUAxLcExeJNhTmddto+AO6fQyhYJuV2tDvq ib2N1kw9zsGOgwuLGzo76aKvMjYbb8Uu0yysNVeNLerx1fcg0s3aoAqAxbOGCDk+ ISueoGfCvlCR7cyhcY69A== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvfedrudeiuddgudegfecutefuodetggdotefrod ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfgh necuuegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmd enucfjughrpegtgffhggfufffkfhevjgfvofesthhqmhdthhdtjeenucfhrhhomhepufgt ohhtthcunfhonhhguceoshgtohhtthhlsehsrghmshgtohdrohhrgheqnecuggftrfgrth htvghrnhepfefhleevfeefveeuueehffefhfefudegleetvdegleevudffkeevueelfeel vdevnecuffhomhgrihhnpehfrhgvvggsshgurdhorhhgnecuvehluhhsthgvrhfuihiivg eptdenucfrrghrrghmpehmrghilhhfrhhomhepshgtohhtthhlsehsrghmshgtohdrohhr gh X-ME-Proxy: Feedback-ID: ib8894249:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Tue, 5 Jul 2022 15:31:17 -0400 (EDT) Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable From: Scott Long List-Id: SCSI subsystem List-Archive: https://lists.freebsd.org/archives/freebsd-scsi List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-freebsd-scsi@freebsd.org X-BeenThere: freebsd-scsi@freebsd.org Mime-Version: 1.0 (1.0) Subject: Re: [Bug 264848] mpr0: mpr_user_pass_thru: user reply buffer (64) smaller than returned buffer (68) Date: Tue, 5 Jul 2022 13:31:14 -0600 Message-Id: <718DF862-B883-4F16-8FB7-8739C5A10095@samsco.org> References: Cc: julien@perdition.city, scsi@freebsd.org In-Reply-To: To: Mark Johnston X-Mailer: iPhone Mail (19F77) X-Rspamd-Queue-Id: 4Lct8D6NNXz3NBV X-Spamd-Bar: ---- Authentication-Results: mx1.freebsd.org; dkim=pass header.d=samsco.org header.s=fm1 header.b="M CxN0Pk"; dkim=pass header.d=messagingengine.com header.s=fm2 header.b="n dCyi+Y"; dmarc=none; spf=pass (mx1.freebsd.org: domain of scottl@samsco.org designates 66.111.4.29 as permitted sender) smtp.mailfrom=scottl@samsco.org X-Spamd-Result: default: False [-4.10 / 15.00]; RCVD_VIA_SMTP_AUTH(0.00)[]; ARC_NA(0.00)[]; R_DKIM_ALLOW(-0.20)[samsco.org:s=fm1,messagingengine.com:s=fm2]; FREEFALL_USER(0.00)[scottl]; FROM_HAS_DN(0.00)[]; RCPT_COUNT_THREE(0.00)[3]; MV_CASE(0.50)[]; R_SPF_ALLOW(-0.20)[+ip4:66.111.4.29]; MIME_GOOD(-0.10)[text/plain]; DMARC_NA(0.00)[samsco.org]; NEURAL_HAM_LONG(-1.00)[-1.000]; TO_DN_SOME(0.00)[]; DWL_DNSWL_LOW(-1.00)[messagingengine.com:dkim]; RCVD_COUNT_THREE(0.00)[4]; TO_MATCH_ENVRCPT_SOME(0.00)[]; DKIM_TRACE(0.00)[samsco.org:+,messagingengine.com:+]; NEURAL_HAM_SHORT(-1.00)[-1.000]; NEURAL_HAM_MEDIUM(-1.00)[-1.000]; MLMMJ_DEST(0.00)[scsi]; FROM_EQ_ENVFROM(0.00)[]; MIME_TRACE(0.00)[0:+]; RCVD_TLS_LAST(0.00)[]; ASN(0.00)[asn:19151, ipnet:66.111.4.0/24, country:US]; MID_RHS_MATCH_FROM(0.00)[]; RCVD_IN_DNSWL_LOW(-0.10)[66.111.4.29:from] X-ThisMailContainsUnwantedMimeParts: N Your patch is better than what was originally there. However, i made the or= iginal test simplistic and specific because when the msgVer changes in the f= irmware, unknown parts of the API are also changing, and the software should= be aware of those changes, rather than blindly accepting them. In essence,= this was meant to be a reminder to obtain new specs and adapt code whenever= future changes happened. Scott > On Jul 5, 2022, at 10:41 AM, Mark Johnston wrote: >=20 > =EF=BB=BFOn Tue, Jul 05, 2022 at 08:42:20AM -0600, Scott Long wrote: >> I=E2=80=99ve lost my bugzilla password, and it seems that the =E2=80=9CFo= rgot Password=E2=80=9D functionality doesn=E2=80=99t work. >=20 > I think it works differently for @freebsd.org accounts, you have to > reset your cluster password: > https://docs.freebsd.org/en/articles/committers-guide/#kerberos-ldap >=20 >> Anyways... >>=20 >> The problems is here in mps_get_iocfacts() >>=20 >> snprintf(sysctlname, sizeof(sysctlname), "dev.%s.%d.msg_version", >> is_mps ? "mps" : "mpr", mps_unit); >>=20 >> factslen =3D sizeof(MPI2_IOC_FACTS_REPLY); >> len =3D sizeof(msgver); >> error =3D sysctlbyname(sysctlname, msgver, &len, NULL, 0); >> if (error =3D=3D 0) { >> if (strncmp(msgver, "2.6", sizeof(msgver)) =3D=3D 0) >> factslen +=3D 4; >> } >>=20 >> I haven=E2=80=99t been keeping track, but I=E2=80=99ll guess that msgver h= as numerically advanced past =E2=80=9C2.6=E2=80=9D for this system. >=20 > Thanks, that makes perfect sense. I attached a patch to the PR but > can't test it myself. >=20 > Julian, if you're able to test patches, could you please try the one in > the PR and confirm that the warnings stop appearing? It'd also be > useful to see the value of the dev.mpr.0.msg_version sysctl. >=20