From nobody Tue Jul 05 16:41:26 2022 X-Original-To: scsi@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 9AA4A1D119CB for ; Tue, 5 Jul 2022 16:41:31 +0000 (UTC) (envelope-from markjdb@gmail.com) Received: from mail-qt1-x834.google.com (mail-qt1-x834.google.com [IPv6:2607:f8b0:4864:20::834]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1D4" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4LcpNB5jsPz4hb2 for ; Tue, 5 Jul 2022 16:41:30 +0000 (UTC) (envelope-from markjdb@gmail.com) Received: by mail-qt1-x834.google.com with SMTP id bs20so14486061qtb.11 for ; Tue, 05 Jul 2022 09:41:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=sender:date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to; bh=I3cTSZiPxaK592ebif+4q0hSkBv6kX+XuSduNC7M55o=; b=a0KwyKICAQIq3hLoP+WpArXTjF0bMgmO0GTxtSlZiac9vbb2LJj0eEMTI9RwH47GBa 3X2nsa+56D/kKn4cnvLcqfUiOZUWeWIOZyYvm6zDgc/ohe6UbFlBlemAwblXLie9aXyb NfmwnTPGewIyHUck6FXUt+DvHO9OgRPCeWuDrq6ThzToSOOekrP/Xtn5QCpUq+ZIrU/3 0/wLe4ylE7H5vRmnbNHHo0ZE4y3zphju6aXXmSP6Ydt6D3m1ndg3qn6T/c6qWKqLaNRF fh0OGaZ+lnvjWgSygO4vN+bZA0ut9STNnZUxYMcAk2FERMdDvC/PgLhGdY/1V1YgiEe5 qMcQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:sender:date:from:to:cc:subject:message-id :references:mime-version:content-disposition :content-transfer-encoding:in-reply-to; bh=I3cTSZiPxaK592ebif+4q0hSkBv6kX+XuSduNC7M55o=; b=n3+sH2HnLbR/uiLAGq4faaSSskn4ZlblXcEDZYcwB7osxVqSiu7c33FV2qVDnrzmFB holGWYF4iVuf0mC6YAiwZSkGZ3l6MfH7GL5Ba4IAjOaIDEKGrPerqbQkk4Bs2Qyuh4Hi jFveMVcwQ+DWiBG6dhk6UPHd209uZFOJEEJ0Zq2Ir6npFr+mkOhC9arPR6tpX8qDqoFe pCzDSsxrUb9b4wsW6a2A095gtvYr2rzieRSq2pd1Jqb4hGqhnj5NNpubUwk8iRaTylVH AGeXPh4JqUb4OqBKxidyX57NH+oU4+142s+61arEktDTKW0VjG13AX+OjibzfpKARzpN CMOQ== X-Gm-Message-State: AJIora+Onld9IWMZW6SypLAIYDRh4LLBSBgSkAsIhjMq8RnubspTDYQI fYn+BCJfhCceGZRCow4tRXkIMpERJaE= X-Google-Smtp-Source: AGRyM1t7Vxns8IhdMDC25dZnojVd9NeCjho+heF7qBm1TJ3dcUEek4dXewPplI8VpALbQvKGxnS1Qg== X-Received: by 2002:ac8:4907:0:b0:31b:691e:15ba with SMTP id e7-20020ac84907000000b0031b691e15bamr29486237qtq.179.1657039290217; Tue, 05 Jul 2022 09:41:30 -0700 (PDT) Received: from nuc (198-84-189-58.cpe.teksavvy.com. [198.84.189.58]) by smtp.gmail.com with ESMTPSA id c4-20020a05620a268400b006aee03a95dfsm27204179qkp.124.2022.07.05.09.41.28 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 05 Jul 2022 09:41:29 -0700 (PDT) Date: Tue, 5 Jul 2022 12:41:26 -0400 From: Mark Johnston To: Scott Long Cc: julien@perdition.city, "scsi@freebsd.org" Subject: Re: [Bug 264848] mpr0: mpr_user_pass_thru: user reply buffer (64) smaller than returned buffer (68) Message-ID: References: <6AFB948F-9443-4522-8841-F94F5A1FFE3E@samsco.org> List-Id: SCSI subsystem List-Archive: https://lists.freebsd.org/archives/freebsd-scsi List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-freebsd-scsi@freebsd.org X-BeenThere: freebsd-scsi@freebsd.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <6AFB948F-9443-4522-8841-F94F5A1FFE3E@samsco.org> X-Rspamd-Queue-Id: 4LcpNB5jsPz4hb2 X-Spamd-Bar: -- Authentication-Results: mx1.freebsd.org; dkim=pass header.d=gmail.com header.s=20210112 header.b=a0KwyKIC; dmarc=none; spf=pass (mx1.freebsd.org: domain of markjdb@gmail.com designates 2607:f8b0:4864:20::834 as permitted sender) smtp.mailfrom=markjdb@gmail.com X-Spamd-Result: default: False [-2.67 / 15.00]; TO_DN_EQ_ADDR_SOME(0.00)[]; RCVD_VIA_SMTP_AUTH(0.00)[]; TO_DN_SOME(0.00)[]; R_SPF_ALLOW(-0.20)[+ip6:2607:f8b0:4000::/36]; RCVD_COUNT_THREE(0.00)[3]; DKIM_TRACE(0.00)[gmail.com:+]; NEURAL_HAM_SHORT(-0.97)[-0.968]; FORGED_SENDER(0.30)[markj@freebsd.org,markjdb@gmail.com]; MIME_TRACE(0.00)[0:+]; FREEMAIL_ENVFROM(0.00)[gmail.com]; ASN(0.00)[asn:15169, ipnet:2607:f8b0::/32, country:US]; FROM_NEQ_ENVFROM(0.00)[markj@freebsd.org,markjdb@gmail.com]; DWL_DNSWL_NONE(0.00)[gmail.com:dkim]; ARC_NA(0.00)[]; NEURAL_HAM_MEDIUM(-1.00)[-1.000]; R_DKIM_ALLOW(-0.20)[gmail.com:s=20210112]; FROM_HAS_DN(0.00)[]; RCPT_COUNT_THREE(0.00)[3]; NEURAL_HAM_LONG(-1.00)[-0.998]; MIME_GOOD(-0.10)[text/plain]; PREVIOUSLY_DELIVERED(0.00)[scsi@freebsd.org]; DMARC_NA(0.00)[freebsd.org]; TO_MATCH_ENVRCPT_SOME(0.00)[]; RCVD_IN_DNSWL_NONE(0.00)[2607:f8b0:4864:20::834:from]; MLMMJ_DEST(0.00)[scsi]; MID_RHS_NOT_FQDN(0.50)[]; RCVD_TLS_ALL(0.00)[] X-ThisMailContainsUnwantedMimeParts: N On Tue, Jul 05, 2022 at 08:42:20AM -0600, Scott Long wrote: > I’ve lost my bugzilla password, and it seems that the “Forgot Password” functionality doesn’t work. I think it works differently for @freebsd.org accounts, you have to reset your cluster password: https://docs.freebsd.org/en/articles/committers-guide/#kerberos-ldap > Anyways... > > The problems is here in mps_get_iocfacts() > > snprintf(sysctlname, sizeof(sysctlname), "dev.%s.%d.msg_version", > is_mps ? "mps" : "mpr", mps_unit); > > factslen = sizeof(MPI2_IOC_FACTS_REPLY); > len = sizeof(msgver); > error = sysctlbyname(sysctlname, msgver, &len, NULL, 0); > if (error == 0) { > if (strncmp(msgver, "2.6", sizeof(msgver)) == 0) > factslen += 4; > } > > I haven’t been keeping track, but I’ll guess that msgver has numerically advanced past “2.6” for this system. Thanks, that makes perfect sense. I attached a patch to the PR but can't test it myself. Julian, if you're able to test patches, could you please try the one in the PR and confirm that the warnings stop appearing? It'd also be useful to see the value of the dev.mpr.0.msg_version sysctl.