maintainer-feedback requested: [Bug 278554] lang/ruby33: /usr/bin/install: ChangeLog: Inappropriate file type or format

From: <bugzilla-noreply_at_freebsd.org>
Date: Tue, 23 Apr 2024 15:06:43 UTC
Bugzilla Automation <bugzilla@FreeBSD.org> has asked freebsd-ruby (Nobody)
<ruby@FreeBSD.org> for maintainer-feedback:
Bug 278554: lang/ruby33: /usr/bin/install: ChangeLog: Inappropriate file type
or format
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=278554



--- Description ---
Staging lang/ruby33 after this commit[0] to /usr/bin/install fails with the
following error:

```
[...]
installing manpages:		    /usr/local/share/man/man1
/bin/ln -fs ruby33 /wrkdirs/usr/ports/lang/ruby33/work/stage/usr/local/bin/ruby
/bin/ln -fs ruby33.1.gz
/wrkdirs/usr/ports/lang/ruby33/work/stage/usr/local/share/man/man1/ruby.1.gz
/usr/bin/strip /wrkdirs/usr/ports/lang/ruby33/work/stage/usr/local/bin/ruby33
/usr/bin/strip
/wrkdirs/usr/ports/lang/ruby33/work/stage/usr/local/lib/libruby33.so.33
/usr/bin/find
/wrkdirs/usr/ports/lang/ruby33/work/stage/usr/local/lib/ruby/3.3/amd64-freebsd1
5
-type f -name '*\.so' -exec /usr/bin/strip {} \;
/bin/mkdir -p
/wrkdirs/usr/ports/lang/ruby33/work/stage/usr/local/share/doc/ruby33/ripper
/wrkdirs/usr/ports/lang/ruby33/work/stage/usr/local/share/doc/ruby33/stringio
/wrkdirs/usr/ports/lang/ruby33/work/stage/usr/local/share/doc/ruby33/syslog
install  -m 0644
/wrkdirs/usr/ports/lang/ruby33/work/ruby-3.3.0/ext/ripper/README 
/wrkdirs/usr/ports/lang/ruby33/work/stage/usr/local/share/doc/ruby33/ripper/
install  -m 0644
/wrkdirs/usr/ports/lang/ruby33/work/ruby-3.3.0/ext/stringio/README.md 
/wrkdirs/usr/ports/lang/ruby33/work/stage/usr/local/share/doc/ruby33/stringio/
install  -m 0644
/wrkdirs/usr/ports/lang/ruby33/work/ruby-3.3.0/ext/syslog/syslog.txt 
/wrkdirs/usr/ports/lang/ruby33/work/stage/usr/local/share/doc/ruby33/syslog/
install  -m 0644 /wrkdirs/usr/ports/lang/ruby33/work/ruby-3.3.0/COPYING*       
 /wrkdirs/usr/ports/lang/ruby33/work/ruby-3.3.0/ChangeLog	
/wrkdirs/usr/ports/lang/ruby33/work/ruby-3.3.0/LEGAL		    
/wrkdirs/usr/ports/lang/ruby33/work/ruby-3.3.0/README* 
/wrkdirs/usr/ports/lang/ruby33/work/stage/usr/local/share/doc/ruby33/
install:
/wrkdirs/usr/ports/lang/ruby33/work/stage/usr/local/share/doc/ruby33/ChangeLog:
Inappropriate file type or format
*** Error code 73

Stop.
make: stopped in /usr/ports/lang/ruby33
=>> Cleaning up wrkdir
===>  Cleaning for ruby-3.3.0,1
build of lang/ruby33 | ruby-3.3.0,1 ended at Tue Apr 23 10:11:47 EDT 2024
build time: 00:04:17
!!! build failure encountered !!!
```

The line of interest is:
```
install  -m 0644 /wrkdirs/usr/ports/lang/ruby33/work/ruby-3.3.0/COPYING*       
 /wrkdirs/usr/ports/lang/ruby33/work/ruby-3.3.0/ChangeLog	
/wrkdirs/usr/ports/lang/ruby33/work/ruby-3.3.0/LEGAL		    
/wrkdirs/usr/ports/lang/ruby33/work/ruby-3.3.0/README* 
/wrkdirs/usr/ports/lang/ruby33/work/stage/usr/local/share/doc/ruby33/
install:
/wrkdirs/usr/ports/lang/ruby33/work/stage/usr/local/share/doc/ruby33/ChangeLog:
Inappropriate file type or format
*** Error code 73
```

This is due to this diff hunk[1] which changes the previous warning to a fatal
error. I'm not sure exactly what is the cause, @des or @markj could you help?
Full poudriere build log is attached.

[0]
https://cgit.freebsd.org/src/commit/?id=000a533e6d1db9878296b32d1cc212e11a2cc71
8
[1]
https://github.com/freebsd/freebsd-src/commit/000a533e6d1db9878296b32d1cc212e11
a2cc718#diff-665f6c246af038a9afd6eff198da57505ebc57a034f354ef0c750fb30ccde36eR8
46
[2] https://reviews.freebsd.org/D44810