From nobody Fri Dec 31 02:11:13 2021 X-Original-To: ruby@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 40360192E609 for ; Fri, 31 Dec 2021 02:11:14 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4JQ7ss55l3z3Gvv for ; Fri, 31 Dec 2021 02:11:13 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2610:1c1:1:606c::50:1d]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 85E5F231EE for ; Fri, 31 Dec 2021 02:11:13 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org ([127.0.1.5]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id 1BV2BDXU057894 for ; Fri, 31 Dec 2021 02:11:13 GMT (envelope-from bugzilla-noreply@freebsd.org) Received: (from www@localhost) by kenobi.freebsd.org (8.15.2/8.15.2/Submit) id 1BV2BDt2057893 for ruby@FreeBSD.org; Fri, 31 Dec 2021 02:11:13 GMT (envelope-from bugzilla-noreply@freebsd.org) X-Authentication-Warning: kenobi.freebsd.org: www set sender to bugzilla-noreply@freebsd.org using -f Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="UTF-8" From: bugzilla-noreply@freebsd.org To: ruby@FreeBSD.org Subject: maintainer-feedback requested: [Bug 260831] lang/ruby26, lang/ruby27, lang/ruby3[01]: patch for making dtrace an optional feature Date: Fri, 31 Dec 2021 02:11:13 +0000 X-Bugzilla-Type: request X-Bugzilla-Product: Ports & Packages X-Bugzilla-Component: Individual Port(s) X-Bugzilla-Version: Latest X-Bugzilla-Keywords: X-Bugzilla-Severity: Affects Only Me X-Bugzilla-Who: X-Bugzilla-Status: New X-Bugzilla-Resolution: X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: ruby@FreeBSD.org X-Bugzilla-Flags: maintainer-feedback? Message-ID: In-Reply-To: References: X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated List-Id: FreeBSD-specific Ruby discussions List-Archive: https://lists.freebsd.org/archives/freebsd-ruby List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-freebsd-ruby@freebsd.org X-BeenThere: freebsd-ruby@freebsd.org MIME-Version: 1.0 ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1640916673; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=hjuLWJTEsN/hAH1KgEH2OjDmwsJYzrWJSpIBdp2ZzHk=; b=pSIMMcQcPBKjUFXRKg75GNu3wtYepfvTI2fDImArjGYNejEjJJ7Jloxq5KHieQXQ02Xuhw jE94leMoyk1CangJUgpsW+Uo0i2AckLopRNfrhB17Qk0Bwe/7eqBd1Y2UNra0oITbGm3lE 5iv8OLV1DyvjKoQYuezMPXIq6eDzFfWw5D1otxnQXtN7rkSbB1uWgKRi39dCz0/MspPW8g 7cAHpUaH3rFqcRscbe0UCMHh7M8GH3aLhcUdyh6cl3oYKf/OvTTMI9eaRTZIiRUd7EspmW xce7cgNRkruaNf3JPXa/JDAYh0BuE7XoaHSbhyK5xU4TUzxE5Xq5D6plbD94dg== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1640916673; a=rsa-sha256; cv=none; b=X7UMURhCxQyKLv6KRDNQR0ZnP4PDzR7cMXcYd407SQrdTYCLTfeFLl52Oqu5Yt4zLYE6cN OQ3FU4Y2TH6Fa82vocHknfRrC4ZeTX9xzHpW41XD75M31EIOVwRdQjJgdZ7mewaihcG0pK 6UdurZSNcFVJC+/WD9HLLjwBCUI8o/gRoF80BvAFB3IQF5BN8TrG676DyDmxWS9qZWREb5 aIGisf7DxG/dB9G4RtqMnBIp6m6SD7NOENr1UIDUv08wqyMuEoXOjYQhhAXL+UoDgfFOQE +KRVj229YR8a9n/vfDgVTuxhovUm5U+Q8xmisBLwNKoZBwYuqhdqUw/Y4UoP4A== ARC-Authentication-Results: i=1; mx1.freebsd.org; none X-ThisMailContainsUnwantedMimeParts: N Bugzilla Automation has asked freebsd-ruby (Nobody) for maintainer-feedback: Bug 260831: lang/ruby26, lang/ruby27, lang/ruby3[01]: patch for making dtra= ce an optional feature https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D260831 --- Description --- The lang/ruby2[67] port builds will automatically enable dtrace support if dtrace is installed.=20 The lang/ruby3[01] builds - extending of a changeset upstream - will not provide any dtrace support for these Ruby versions, on FreeBSD. Referring to the FreeBSD Wiki[2], DTrace support may be available for users= pace in FreeBSD, at least if the kernel is built with -fno-omit-frame-pointer in CFLAGS then installed as unstripped bytecode. Otherwise, running dtrace on = an application may require superuser privileges. The Ruby 2.6 and Ruby 2.7 builds presently will incorporate dtrace support,= if available. The following patch (attached) makes DTrace a build option for Ruby, in all versions on FreeBSD This differs from previous port behaviors: - For Ruby 2.6 and 2.7, ensures that dtrace probes will not be added if the dtrace option is disabled, whether or not dtrace is installed - For Ruby 3.0 and 3.1, this adds functionality that may not be available w= ith upstream Ruby builds on FreeBSD, in those recent Ruby releases. This change= set includes an autoconf patch ensuring that dtrace will not be disabled on Fre= eBSD under autoconf scripting, and will be enabled if requested for the build.=20 - If the dtrace option is enabled and dtrace is not installed, the port bui= ld will fail under IGNORE semantics Corresponding to existing support for dtrace probes with Ruby 2.6 and Ruby = 2.7 on FreeBSD, the new dtrace option will be available for these Ruby language platforms on FreeBSD amd64 and i386 architectures. This patch has been tested with a rudimentary check using dtrace and a dtrace-enabled Ruby 3.1 under a local build of FreeBSD 12.1-RELEASE-p1 amd6= 4. The test was performed with the following shell command, under sudo: dtrace -l -m libruby31.so.31 -c 'ruby31 -v' [1] https://github.com/chrisa/ruby-dtrace=20 [2] https://wiki.freebsd.org/DTrace/KernelSupport