Re: StarFive VisionFive 2 support
- Reply: Colin S. Gordon: "Re: StarFive VisionFive 2 support"
- In reply to: Colin S. Gordon: "Re: StarFive VisionFive 2 support"
- Go to: [ bottom of page ] [ top of archives ] [ this month ]
Date: Tue, 10 Oct 2023 15:16:17 UTC
Colin S. Gordon wrote: >I see some GPL and MIT license headers in your current changes, which I'm trying to avoid, but I'll gladly build on some of the BSD-licensed changes. So far I've not quite grasped what is FreeBSD's stance on this issue. Some of my question on IRC have gone unanswered but I've got a picture that some dual-licensed files are used as such. I myself extracted some of the most important header code and used it under MIT license (naturally giving credits to the original author). Colin S. Gordon wrote: >It looks like I did at least partly duplicate your work with the dwmmc driver(https://github.com/csgordon/freebsd-starfive2/commit/fd7 >00cd60e466bacfd60c1dcc3b4 [github.com]), which I mostly adapted from one of the existing drivers. I'll also take a look at M. Horne's code, I wasn't aware of that myself. Oddly enough, for me MMC didn't require any additional code beyond offering clocks, (maybe the reset driver) and fixing that DMA bug which was initially reported here: https://reviews.freebsd.org/D34118 ...and which I re-reported here: https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=273694 I don't recall having any issues with biu and ciu clocks, so I'm not sure what that is about. -Jari