[Bug 284865] IPFW syntax errors in /etc/rc.firewall

From: <bugzilla-noreply_at_freebsd.org>
Date: Wed, 26 Feb 2025 19:08:06 UTC
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=284865

Jose Luis Duran <jlduran@FreeBSD.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jlduran@FreeBSD.org

--- Comment #1 from Jose Luis Duran <jlduran@FreeBSD.org> ---
(In reply to gotnull from comment #0)
You should not get an error when parsing rc.firewall.

Looking at the code, both options are valid, and should yield the same result,
(sbin/ipfw/ipfw2.c):

        { "icmptype",           TOK_ICMPTYPES },
        { "icmptypes",          TOK_ICMPTYPES },

This alias was added in
https://cgit.freebsd.org/src/commit/?id=0a7197a83c3c3833cc0cb862ee648308309fdc6b

The bug is perhaps in the man page, we should document this alias as well,
while here we could use the plural form when there are many ICMP (4/6) types in
/etc/rc.firewall.

-- 
You are receiving this mail because:
You are the assignee for the bug.