From nobody Thu Mar 10 00:47:34 2022 X-Original-To: rc@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4AD7B19F7556 for ; Thu, 10 Mar 2022 00:47:34 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4KDVlV0wGlz4nV9 for ; Thu, 10 Mar 2022 00:47:34 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2610:1c1:1:606c::50:1d]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id F422B1B137 for ; Thu, 10 Mar 2022 00:47:33 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org ([127.0.1.5]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id 22A0lXhb080429 for ; Thu, 10 Mar 2022 00:47:33 GMT (envelope-from bugzilla-noreply@freebsd.org) Received: (from bugzilla@localhost) by kenobi.freebsd.org (8.15.2/8.15.2/Submit) id 22A0lXGw080428 for rc@FreeBSD.org; Thu, 10 Mar 2022 00:47:33 GMT (envelope-from bugzilla-noreply@freebsd.org) X-Authentication-Warning: kenobi.freebsd.org: bugzilla set sender to bugzilla-noreply@freebsd.org using -f From: bugzilla-noreply@freebsd.org To: rc@FreeBSD.org Subject: [Bug 238301] [PATCH] handle encrypted swap in dumpon rc.d script Date: Thu, 10 Mar 2022 00:47:34 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Base System X-Bugzilla-Component: bin X-Bugzilla-Version: CURRENT X-Bugzilla-Keywords: patch X-Bugzilla-Severity: Affects Some People X-Bugzilla-Who: commit-hook@FreeBSD.org X-Bugzilla-Status: New X-Bugzilla-Resolution: X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: rc@FreeBSD.org X-Bugzilla-Flags: maintainer-feedback? X-Bugzilla-Changed-Fields: Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated List-Id: Discussion related to /etc/rc.d design and implementation List-Archive: https://lists.freebsd.org/archives/freebsd-rc List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-freebsd-rc@freebsd.org X-BeenThere: freebsd-rc@freebsd.org MIME-Version: 1.0 ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1646873254; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Z93GsWtuGp6a9k5uLMuDKupynglgT3wMacucxq5u7xY=; b=Fu338u3LXGh9bMzufThAW+M+0ZFVIwtDA4z7626xfrUUOIMYC1aEH6Qrw7hWsF5l/s7eXV LM26a9NTJh56OuLjzaFc62Cs0r3+YjzzBXpd591nvIlS0bh1JhZH01M+OD2xXyVqTpR0dQ kEit3AXW1Y3uDANvhIYqPtbuN68Y+LxRmrII7nsRFrwFQEVQYIyhk60ylqx2duh9z3bVFE nUguue9b/j7kxtGysy0S5uzB+hK47a33W9XyMgSLbonOuGyPutqmfGOWM+4pYNou6biF7M nlq0/y12DccMq3eIZMcH3YkBcpx5jUKMw5ZtMRrbKkN0AHfl3Rhm4Z+FtMBLIQ== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1646873254; a=rsa-sha256; cv=none; b=NxvQVLqLwVAAVAy3WVFzOki8QZM0lAmj4Wlm/jKOIiE1rnVu47JBva1KHI8sgSuDff01Al euT1LT2eumOi9S/GqJJUO3mcPKvRxEm00axIFEuiM//U5rvy9SByxmCwrsur1dav0Pq8oV KdOfjO5yecL3Y0uPdSFUfumbZWt/d4uPLtYL4GtbCdwvIS5Y55NkqpoQCoRj25OQXdNCoP ea4o0wee5GUkmDvAPDeXjikxLpZcIoHGDJaHHOiTpIhsA121OMH6Y1oI65UPheuQLTGh/w KQK24K40F6zW7tGWJosnpWZZ8Gki181vbDNvB1LzE0ksegBYf0ViQ0sAkPGIcg== ARC-Authentication-Results: i=1; mx1.freebsd.org; none X-ThisMailContainsUnwantedMimeParts: N https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D238301 --- Comment #6 from commit-hook@FreeBSD.org --- A commit in branch main references this bug: URL: https://cgit.FreeBSD.org/src/commit/?id=3D67e751f167c98d02f85eb38401e3e6388= db09ac1 commit 67e751f167c98d02f85eb38401e3e6388db09ac1 Author: Ed Maste AuthorDate: 2022-03-07 19:17:01 +0000 Commit: Ed Maste CommitDate: 2022-03-10 00:43:14 +0000 dumpon: use underlying device if encrypted swap is in use /etc/rc.d/dumpon runs before /etc/rc.d/swap. When encrypted swap is in use the .eli or .bde device will not exist at the time dumpon runs. Even if this is addressed it does not make sense to dump core to encrypted swap, as the encryption key will not be available after reboot rendering the dump useless. Thus, for the case that dumpdev=3DA= UTO and encrypted swap is in use, strip the extension and use the underlying device. Emit a warning if we are using the underlying device and the user has n= ot configured dump encryption, so that the user knows that the will not be encrypted. PR: 238301 Reported by: Ivan Rozhuk Reviewed by: jilles MFC after: 1 week Sponsored by: The FreeBSD Foundation Differential Revision: https://reviews.freebsd.org/D34474 libexec/rc/rc.d/dumpon | 19 +++++++++++++++++++ 1 file changed, 19 insertions(+) --=20 You are receiving this mail because: You are the assignee for the bug.=