From nobody Fri Mar 01 06:22:17 2024 X-Original-To: questions@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4TmJ0b001Pz5C09c for ; Fri, 1 Mar 2024 06:22:22 +0000 (UTC) (envelope-from tamelingdaniel@gmail.com) Received: from mail-wm1-x331.google.com (mail-wm1-x331.google.com [IPv6:2a00:1450:4864:20::331]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1D4" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4TmJ0Z0YGmz4gct for ; Fri, 1 Mar 2024 06:22:22 +0000 (UTC) (envelope-from tamelingdaniel@gmail.com) Authentication-Results: mx1.freebsd.org; dkim=pass header.d=gmail.com header.s=20230601 header.b=ZOqG+Gvf; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (mx1.freebsd.org: domain of tamelingdaniel@gmail.com designates 2a00:1450:4864:20::331 as permitted sender) smtp.mailfrom=tamelingdaniel@gmail.com Received: by mail-wm1-x331.google.com with SMTP id 5b1f17b1804b1-412c780464dso2084265e9.0 for ; Thu, 29 Feb 2024 22:22:22 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1709274139; x=1709878939; darn=freebsd.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=du5Z9BOHB1i8T5+czklapY1foHbo3SfHWI16c13fi0E=; b=ZOqG+GvfnGLkUbGCwoNwwwpmfLDqia7zhwkiRRJq0KT4nwh+L60WGTvfIa6BSxjkjx ojv1GAIWGN27N/Kq4Witrz5u23qOpDs5YNTZdeDQr7WzHHktUSTup89TYWuczdSEmEMN tCFS4ANIrphxqOnGRXbVXkod18s9l2E8wBCvL1Q3iLqpVYzUmxpYeLbOmq9XoqJ0IvyR nfFYdiUOn+cxMTPAX/iK8wgkCqX0hGmZT7Y4PJB81a0UUikD121YAul1O4T4p1nQucl+ 9bX0pWwPIW63fZ++tt6X8cI7yH7zD1eMF8PNTw/vlM2I9fRltVDhSMdFLNdEozQ16giy 0U6g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1709274139; x=1709878939; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=du5Z9BOHB1i8T5+czklapY1foHbo3SfHWI16c13fi0E=; b=jChJ/8EwqN0dyUTovtGjBqPTY98/y+9eztkX340MvOeS80oKwTg6RUyltkRrFFX5fO 6ONFBxZvqRbsHoevhJXlk4Zv2jVSG7v/IaMYIlDSuPjk50PQaDZq5opJb9pnNF0z/SpT rq8o9PPAr6XYwlf8j3Uy6OhtxJ+rmqcvQBxTQy/a91yD8w+ShGHzODNaZzUAGX0OnAWz ZH/g6DeDe8BiMNKg7AK2eu2FxXc+z1Q2CGc+ArPVKFLtxiJ6w11iHgArD6PB7LqhCayd k+Z3CVy8BYxxfNxHjH0g4eTK0NrzS0eZhA8L6V0u6YC3IuBU1p7a3TlZbX8S7P5prV7E SlTQ== X-Gm-Message-State: AOJu0YxoWrAbfsPyIDemhXoRHKReU9na242lFMuSJW4bTYgUPDSbyldP d6zN+4iWQCFPrB0Nq4Fbbpz+dycQLV4Ywe+FFJ0+bR4O2gQ82LNHIDRpSl8vshU= X-Google-Smtp-Source: AGHT+IGlih6DIGdPtmYB3GZlMVRo7Q78B1fjBqA2jq7LlXOwug7bz6XpLByhUViHYkIIT05wcvngmQ== X-Received: by 2002:a5d:4682:0:b0:33d:f883:4fad with SMTP id u2-20020a5d4682000000b0033df8834fadmr470663wrq.15.1709274139454; Thu, 29 Feb 2024 22:22:19 -0800 (PST) Received: from localhost (200116b80d760700cde06bc524eeb84b.dip.versatel-1u1.de. [2001:16b8:d76:700:cde0:6bc5:24ee:b84b]) by smtp.gmail.com with ESMTPSA id ck12-20020a5d5e8c000000b0033d2541b3e1sm3767749wrb.72.2024.02.29.22.22.18 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 29 Feb 2024 22:22:18 -0800 (PST) Date: Fri, 1 Mar 2024 07:22:17 +0100 From: Daniel Tameling To: questions@freebsd.org Subject: Re: FreeBSD 13.2R and OpenZFS bug #15933 Message-ID: References: <27dc6dbd-2ca0-4385-8281-e6bde086bd13@holgerdanske.com> <87eb268e-9429-414a-a3e6-d2e93eaa2119@holgerdanske.com> List-Id: User questions List-Archive: https://lists.freebsd.org/archives/freebsd-questions List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-freebsd-questions@freebsd.org X-BeenThere: freebsd-questions@freebsd.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <87eb268e-9429-414a-a3e6-d2e93eaa2119@holgerdanske.com> X-Spamd-Bar: --- X-Spamd-Result: default: False [-3.94 / 15.00]; NEURAL_HAM_MEDIUM(-1.00)[-1.000]; NEURAL_HAM_LONG(-1.00)[-1.000]; NEURAL_HAM_SHORT(-0.94)[-0.944]; DMARC_POLICY_ALLOW(-0.50)[gmail.com,none]; R_SPF_ALLOW(-0.20)[+ip6:2a00:1450:4000::/36]; R_DKIM_ALLOW(-0.20)[gmail.com:s=20230601]; MIME_GOOD(-0.10)[text/plain]; RCVD_TLS_LAST(0.00)[]; TO_MATCH_ENVRCPT_ALL(0.00)[]; FROM_HAS_DN(0.00)[]; ARC_NA(0.00)[]; MIME_TRACE(0.00)[0:+]; RCPT_COUNT_ONE(0.00)[1]; FREEMAIL_ENVFROM(0.00)[gmail.com]; FREEMAIL_FROM(0.00)[gmail.com]; DKIM_TRACE(0.00)[gmail.com:+]; MISSING_XM_UA(0.00)[]; ASN(0.00)[asn:15169, ipnet:2a00:1450::/32, country:US]; TO_DN_NONE(0.00)[]; RCVD_COUNT_TWO(0.00)[2]; FROM_EQ_ENVFROM(0.00)[]; DWL_DNSWL_NONE(0.00)[gmail.com:dkim]; PREVIOUSLY_DELIVERED(0.00)[questions@freebsd.org]; MLMMJ_DEST(0.00)[questions@freebsd.org]; MID_RHS_MATCH_FROMTLD(0.00)[]; RCVD_VIA_SMTP_AUTH(0.00)[]; RCVD_IN_DNSWL_NONE(0.00)[2a00:1450:4864:20::331:from] X-Rspamd-Queue-Id: 4TmJ0Z0YGmz4gct On Wed, Feb 28, 2024 at 06:08:14PM -0800, David Christensen wrote: > > OpenZFS bugs #15526 and #15933 appear to be integration bugs that involve > the (Linux) kernel, GNU coreutils, and ZFS. The test case involves setting > up a Portage system for Go on Gentoo Linux (?) and examining files manually > for zeroed holes where non-zero values should be. I do not know if the test > case can be run on FreeBSD, if there is a test case for these bugs on > FreeBSD, or if the bugs do not apply to FreeBSD because the kernel is not > Linux (?). Bug 15526 worked as follows: If you have a recently modified file and read it, you get the correct data. But if you ask ZFS if it contains holes there is a tiny window when gives you the wrong answer. Coreutils changed the defaults of cp for the latest major release, making it ask for holes. Go enters the picture as when it was compiling stuff it was copying a lot of recently modified files and some of the copies ended up with holes they shouldn't have had. The probability for this was very low but it was reproducible. The nasty thing about this was that the checksums were correct as they were computed for the new files. So several things needed to come together: 1) recently modified files, 2) copy them almost simultaneously while 3) looking for holes. Even then it was relatively rare to hit the bug, which is why it remained undetected for so long. Here is a write-up of the person that fixed the bug containing all the gory details: https://despairlabs.com/blog/posts/2023-12-25-openzfs-data-corruption-bug/ > > > Does this new OpenZFS bug [#15933] affect FreeBSD 13.2R? > > > > [#15933] mentions using block cloning which 13.2R does not include or > > support on the base system. Though a pool may have that enabled, I > > thought it was still disabled with a sysctl (that I hope never goes > > away even when 100% bug free; its important to be able to rewrite > > data on disk when desired). I am not sure if the bug is only produced > > when block cloning is enabled or if block cloning just brings out a > > different bug. Until the bug is properly 'debugged' or further > > diagnosed, it would be hard to say what systems reproduce the issue > > and under what conditions. > > > So, is my data safe on up-to-date FreeBSD 13.2R ZFS with native encryption > disabled? > It's safer than on FreeBSD 12 but nobody will give you any guarantees. -- Best regards Daniel