From nobody Wed Jul 10 02:12:38 2024 X-Original-To: questions@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4WJhGt3g1tz5PqZX for ; Wed, 10 Jul 2024 02:13:26 +0000 (UTC) (envelope-from wfdudley@gmail.com) Received: from mail-vk1-xa31.google.com (mail-vk1-xa31.google.com [IPv6:2607:f8b0:4864:20::a31]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "WR4" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4WJhGt17cMz4G11; Wed, 10 Jul 2024 02:13:26 +0000 (UTC) (envelope-from wfdudley@gmail.com) Authentication-Results: mx1.freebsd.org; none Received: by mail-vk1-xa31.google.com with SMTP id 71dfb90a1353d-4f30331218eso188555e0c.1; Tue, 09 Jul 2024 19:13:26 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1720577605; x=1721182405; darn=freebsd.org; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=VH6mpB0ngql/nRVNJTf4YVAEGYYC6qLmpJJKBrFGN5I=; b=bzMtviMjho+esZF2aYinxY4MLE/JkUOCJWfffAsjNL2tBC2y+at6wMQUHCjd87uGfV YD5JwW3HVIVF0pKdc2GVfx1qu6vu6lb3W8detmgIEc4UJBv/gpIqMkqYipW4ZCtyFo5T wOwIcsnMd8zPzbznNPHWVWXXkkLMhR/TRsBrqnz4Y22gomlVWRW2iAfJuhpvtpwFYwPp zEiTiAUKS7p6AJ4DftJ8St1JjHNdqYsLjGPFF4c/r4NhSTARxjKwxnYFojbQ9SWw1s40 FcDiDkuh2eA7Hs+th6XdXiegH4NmiOvsvuX7oPkX4re3pmDVF6EEVu82y7TPo6eG2bVs LXSA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1720577605; x=1721182405; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=VH6mpB0ngql/nRVNJTf4YVAEGYYC6qLmpJJKBrFGN5I=; b=Z2nSjEUS/4y5a5hYTM+VG6smDh4dRBgxxAlA/edakMZvujPYT/pgA4YN9cH0HqtBqX g+obMDuxiJRSeFxzERZFhn/8C6eKZYEa0fA2y9Bx503Rr7HZtj1WGBW6vDRfauU/Htxr gEV8iJhgal2pRdOoWMi1s12zkYgWzQQke2OL0+me6LBNcNMbYNeTPTGuhjBCMCAPol3E XQ97Mpqci8QiPJn9lB9ThFH0RYTTBsLrXwHnK2bl8+LSKZXaMqnflbwTY/LNhRAlD24l rlk7JCBNFp1OOJuwgf/jE1WYdZ3SC4LLyDHXi8IH9NcdxaZvQdYDui8fxf+xRD1nz+E5 RtxQ== X-Forwarded-Encrypted: i=1; AJvYcCX2RRFR9nGwTJgpULxjXWdsheCbTAgTg6nq+hsEyd98migQ+dyxpfAhqMW6mAaqa4MnuKFSwjuZhV5L81f9xRRTzh8= X-Gm-Message-State: AOJu0YwVECMPN8Ne3ZRHbQvsVdvwfxHY5Y290EERCSBvvUinPCeIGHfi qozhfj/ql8EU/Pr98c7L4Avcss/OUtPY6ouzUQkchiiaPCFZvzi5vWGD5q8Z/5b/oYpP5/1FvRG nLZ3ZnR2PbP+17FPlJ4hIlLR0mcH3F1ZN X-Google-Smtp-Source: AGHT+IE1WElOsmmVWrT9hjOuSZ0/X/BVQK6Go4V65T7I8PxiKLCBuAEUYAudSIPG/39hZAHNrhrFQe0+7M1Wcj/4He4= X-Received: by 2002:ac5:c93c:0:b0:4da:ae51:b755 with SMTP id 71dfb90a1353d-4f396e159damr1953013e0c.3.1720577605168; Tue, 09 Jul 2024 19:13:25 -0700 (PDT) List-Id: User questions List-Archive: https://lists.freebsd.org/archives/freebsd-questions List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: freebsd-questions@freebsd.org Sender: owner-freebsd-questions@FreeBSD.org MIME-Version: 1.0 References: <87msmqyzv7.wl-herbert@gojira.at> <87le2ayy12.wl-herbert@gojira.at> <87a5iqp0et.wl-herbert@gojira.at> In-Reply-To: <87a5iqp0et.wl-herbert@gojira.at> From: William Dudley Date: Tue, 9 Jul 2024 22:12:38 -0400 Message-ID: Subject: Re: Where is hptrr kernel module in 13.3 ? To: "Herbert J. Skuhra" Cc: questions@freebsd.org, andrew@freebsd.org Content-Type: multipart/alternative; boundary="000000000000f6f84a061cdb30a5" X-Spamd-Bar: ---- X-Rspamd-Pre-Result: action=no action; module=replies; Message is reply to one we originated X-Spamd-Result: default: False [-4.00 / 15.00]; REPLY(-4.00)[]; ASN(0.00)[asn:15169, ipnet:2607:f8b0::/32, country:US] X-Rspamd-Queue-Id: 4WJhGt17cMz4G11 --000000000000f6f84a061cdb30a5 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable I have submitted a but report. https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D280212 Thanks to all for reassuring me that I'm not missing something. Bill Dudley This email is free of malware because I run Linux. On Tue, Jul 9, 2024 at 8:16=E2=80=AFPM Herbert J. Skuhra wrote: > On Wed, 10 Jul 2024 00:56:57 +0200, "Herbert J. Skuhra" wrote: > > > > On Wed, 10 Jul 2024 00:27:08 +0200, Pete Wright wrote: > > > > > > On 7/9/24 15:17, Herbert J. Skuhra wrote: > > > > On Tue, 09 Jul 2024 21:39:30 +0200, William Dudley wrote: > > > >> I wanted to use an old "RocketRaid 1740" SATA PCI card in a machin= e, > > > >> and that requires the "hptrr" driver. This page: > > > >> > > > >> https://www.freebsd.org/releases/13.3R/hardware/ > > > >> > > > >> Suggests it's part of the 13.3 release, but I cannot find anything > but > > > >> a man page for it on my 13.3 systems (all three of them). > > > >> > > > >> Further, I installed the source tree (using git) because I though > > > >> maybe I had to build the module, but hptrr isn't mentioned at > > > >> all in the /usr/src/sys/amd64/GENERIC file, so I can't "enable" it > > > >> to be built as part of the kernel. > > > > It is listed in sys/amd64/conf/NOTES. > > > > > > > > From /usr/src/UPDATING: > > > > > > > > 20191003: > > > > The hpt27xx, hptmv, hptnr, and hptrr drivers have been > removed from > > > > GENERIC. They are available as modules and can be loaded > by adding > > > > to /boot/loader.conf hpt27xx_load=3D"YES", hptmv_load=3D"Y= ES", > > > > hptnr_load=3D"YES", or hptrr_load=3D"YES", respectively. > > > > > > > > But none of the 13.x-RELEASE kernel.txz (amd64) include the > mentioned modules. > > > > I guess you should open a PR at bugs.freebsd.org. Maybe this can be > > > > fixed for 13.4-RELEASE. > > > > > > > > Have you tried to build your own kernel with "device hptrr"? > > > > > > i've got a system running CURRENT and can confirm those modules are > > > present, i would also assume they are there on 13.x as well. what doe= s > > > "ls /boot/kernel/hpt*" show on your system? -pete > > > > The modules are available in 12.x, 14.x and main, but are obviously > > missing in 13.x: > > > > $ curl -O > https://download.freebsd.org/ftp/releases/amd64/13.3-RELEASE/kernel.txz > > $ tar -ztf kernel.txz |grep hpt > > ./boot/kernel/hptiop.ko > > $ curl -O > https://download.freebsd.org/ftp/releases/amd64/14.1-RELEASE/kernel.txz > > $ tar -ztf kernel.txz |grep hpt > > ./boot/kernel/hptrr.ko > > ./boot/kernel/hptnr.ko > > ./boot/kernel/tcphpts.ko > > ./boot/kernel/hpt27xx.ko > > ./boot/kernel/hptiop.ko > > ./boot/kernel/hptmv.ko > > > > And after running "make buildworld buildkernel" for stable/13 (amd64) > > on a stable/14 (amd64) system the modules are missing as well. > > Maybe > > commit 849aef496d2ae19961310f4e92f3a0b928732d26 > Author: Andrew Turner > AuthorDate: 2019-11-21 12:22:08 +0100 > Commit: Andrew Turner > CommitDate: 2019-11-21 12:22:08 +0100 > > Port the NetBSD KCSAN runtime to FreeBSD. > [...] > > > The modules are built again if you revert the change to > sys/modules/Makefile: > > diff --git a/sys/modules/Makefile b/sys/modules/Makefile > index a61b4ad19095..31f6530fcb49 100644 > --- a/sys/modules/Makefile > +++ b/sys/modules/Makefile > @@ -747,11 +747,11 @@ _chvgpio=3D chvgpio > _ciss=3D ciss > _chromebook_platform=3D chromebook_platform > _coretemp=3D coretemp > -.if ${MK_SOURCELESS_HOST} !=3D "no" && empty(KCSAN_ENABLED) > +.if ${MK_SOURCELESS_HOST} !=3D "no" > _hpt27xx=3D hpt27xx > .endif > _hptiop=3D hptiop > -.if ${MK_SOURCELESS_HOST} !=3D "no" && empty(KCSAN_ENABLED) > +.if ${MK_SOURCELESS_HOST} !=3D "no" > _hptmv=3D hptmv > _hptnr=3D hptnr > _hptrr=3D hptrr > > > I guess the following commit is missing on 13.x: > > commit 2422138952d86dd8b02ff33c55f747ca8e381afe > Author: Andrew Turner > AuthorDate: 2021-06-02 12:07:55 +0200 > Commit: Andrew Turner > CommitDate: 2021-06-02 12:59:19 +0200 > > Fix the KCSAN_ENABLED check when building modules > > > --000000000000f6f84a061cdb30a5 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
I have submitted a but report.=C2=A0=C2=A0https://bugs.freebsd= .org/bugzilla/show_bug.cgi?id=3D280212
Thanks to all for reassuring= me that I'm not missing something.

Bill Dudley<= br clear=3D"all">
This email is free of malware because I run Linux.=


On Tue, Jul 9, 2024 at 8:16=E2=80=AFPM Herber= t J. Skuhra <herbert@gojira.at&= gt; wrote:
On We= d, 10 Jul 2024 00:56:57 +0200, "Herbert J. Skuhra" wrote:
>
> On Wed, 10 Jul 2024 00:27:08 +0200, Pete Wright wrote:
> >=C2=A0
> > On 7/9/24 15:17, Herbert J. Skuhra wrote:
> > > On Tue, 09 Jul 2024 21:39:30 +0200, William Dudley wrote: > > >> I wanted to use an old "RocketRaid 1740" SATA = PCI card in a machine,
> > >> and that requires the "hptrr" driver.=C2=A0 Th= is page:
> > >>
> > >> https://www.freebsd.org/releases/= 13.3R/hardware/
> > >>
> > >> Suggests it's part of the 13.3 release, but I cannot= find anything but
> > >> a man page for it on my 13.3 systems (all three of them)= .
> > >>
> > >> Further, I installed the source tree (using git) because= I though
> > >> maybe I had to build the module, but hptrr isn't men= tioned at
> > >> all in the /usr/src/sys/amd64/GENERIC file, so I can'= ;t "enable" it
> > >> to be built as part of the kernel.
> > > It is listed in sys/amd64/conf/NOTES.
> > >
> > >=C2=A0 From /usr/src/UPDATING:
> > >
> > > 20191003:
> > >=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 The hpt27xx, hptmv, hptnr,= and hptrr drivers have been removed from
> > >=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 GENERIC.=C2=A0 They are av= ailable as modules and can be loaded by adding
> > >=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 to /boot/loader.conf hpt27= xx_load=3D"YES", hptmv_load=3D"YES",
> > >=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 hptnr_load=3D"YES&quo= t;, or hptrr_load=3D"YES", respectively.
> > >
> > > But none of the 13.x-RELEASE kernel.txz (amd64) include the = mentioned modules.
> > > I guess you should open a PR at bugs.freebsd.org. Maybe th= is can be
> > > fixed for 13.4-RELEASE.
> > >
> > > Have you tried to build your own kernel with "device hp= trr"?
> >
> > i've got a system running CURRENT and can confirm those modul= es are
> > present, i would also assume they are there on 13.x as well. what= does
> > "ls /boot/kernel/hpt*" show on your system? -pete
>
> The modules are available in 12.x, 14.x and main, but are obviously > missing in 13.x:
>
> $ curl -O https://downlo= ad.freebsd.org/ftp/releases/amd64/13.3-RELEASE/kernel.txz
> $ tar -ztf kernel.txz |grep hpt
> ./boot/kernel/hptiop.ko
> $ curl -O https://downlo= ad.freebsd.org/ftp/releases/amd64/14.1-RELEASE/kernel.txz
> $ tar -ztf kernel.txz |grep hpt
> ./boot/kernel/hptrr.ko
> ./boot/kernel/hptnr.ko
> ./boot/kernel/tcphpts.ko
> ./boot/kernel/hpt27xx.ko
> ./boot/kernel/hptiop.ko
> ./boot/kernel/hptmv.ko
>
> And after running "make buildworld buildkernel" for stable/1= 3 (amd64)
> on a stable/14 (amd64) system the modules are missing as well.

Maybe

commit 849aef496d2ae19961310f4e92f3a0b928732d26
Author:=C2=A0 =C2=A0 =C2=A0Andrew Turner
AuthorDate: 2019-11-21 12:22:08 +0100
Commit:=C2=A0 =C2=A0 =C2=A0Andrew Turner
CommitDate: 2019-11-21 12:22:08 +0100

=C2=A0 =C2=A0 Port the NetBSD KCSAN runtime to FreeBSD.
=C2=A0 =C2=A0 [...]


The modules are built again if you revert the change to
sys/modules/Makefile:

diff --git a/sys/modules/Makefile b/sys/modules/Makefile
index a61b4ad19095..31f6530fcb49 100644
--- a/sys/modules/Makefile
+++ b/sys/modules/Makefile
@@ -747,11 +747,11 @@ _chvgpio=3D chvgpio
=C2=A0_ciss=3D=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0ciss
=C2=A0_chromebook_platform=3D=C2=A0 chromebook_platform
=C2=A0_coretemp=3D=C2=A0 =C2=A0 =C2=A0coretemp
-.if ${MK_SOURCELESS_HOST} !=3D "no" && empty(KCSAN_ENABL= ED)
+.if ${MK_SOURCELESS_HOST} !=3D "no"
=C2=A0_hpt27xx=3D=C2=A0 =C2=A0 =C2=A0 hpt27xx
=C2=A0.endif
=C2=A0_hptiop=3D=C2=A0 =C2=A0 =C2=A0 =C2=A0hptiop
-.if ${MK_SOURCELESS_HOST} !=3D "no" && empty(KCSAN_ENABL= ED)
+.if ${MK_SOURCELESS_HOST} !=3D "no"
=C2=A0_hptmv=3D=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 hptm= v
=C2=A0_hptnr=3D=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 hptn= r
=C2=A0_hptrr=3D=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 hptr= r


I guess the following commit is missing on 13.x:

commit 2422138952d86dd8b02ff33c55f747ca8e381afe
Author:=C2=A0 =C2=A0 =C2=A0Andrew Turner
AuthorDate: 2021-06-02 12:07:55 +0200
Commit:=C2=A0 =C2=A0 =C2=A0Andrew Turner
CommitDate: 2021-06-02 12:59:19 +0200

=C2=A0 =C2=A0 Fix the KCSAN_ENABLED check when building modules


--000000000000f6f84a061cdb30a5--