From nobody Thu Feb 29 02:08:14 2024 X-Original-To: questions@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4TlZQ23SBXz5BcTD for ; Thu, 29 Feb 2024 02:08:26 +0000 (UTC) (envelope-from dpchrist@holgerdanske.com) Received: from holgerdanske.com (holgerdanske.com [184.105.128.27]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-256) server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "holgerdanske.com", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4TlZQ11fP5z47y0 for ; Thu, 29 Feb 2024 02:08:25 +0000 (UTC) (envelope-from dpchrist@holgerdanske.com) Authentication-Results: mx1.freebsd.org; dkim=pass header.d=holgerdanske.com header.s=nov-20210719-112354 header.b="n/2fe3DA"; dmarc=pass (policy=none) header.from=holgerdanske.com; spf=pass (mx1.freebsd.org: domain of dpchrist@holgerdanske.com designates 184.105.128.27 as permitted sender) smtp.mailfrom=dpchrist@holgerdanske.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=holgerdanske.com; s=nov-20210719-112354; t=1709172495; bh=zPYZDyS1JC+jL97xqRqD2PkiV1japbLY76t9Kv7awVA=; h=Received:Message-ID:Date:MIME-Version:User-Agent:From:Subject:To: References:Content-Language:In-Reply-To:Content-Type: Content-Transfer-Encoding; b=n/2fe3DASOiEroFrt62Bju8d+zPIJgW4OeINL1iReUdSuT/pPszq/X6eulNRVv2dd wZDNGRk2feytfP65yONgmZzsuMxjOmPtGlqt536F8ozXPECSo+dNXWxNz57HGlhV2S PWC6Cbuf3WwBXCA8mRaYlOdnaE5z9voBCYzwiwN9O9Ok1v+C1rlAfd+bEYjbYjQjvI I8DYnJL6Mt+9cfy9FmS3EN2YuMSim9aU3A8gwLwoESV2QqzCJl0ewYRZMEVN17mZCz YmXugC59+MI/a3mbVfxPi/WxgUlvwXDS5AP9R8tmf7nfhTYG/DhpU+9Rf+9D67sJMC RHKmUi1wZzW7BN6kxAK3DNdYPt/cgylLDHMrMz5W0JsiZ+PBgu9goz9pFn9e0gvYNt vuWmO2x9QhDxfjzPBhx4UcIZql06JgdZCq7+Re6p0ESPLJOZiAABaUY9wN4GwFGxyd k1CW7RWGqd0Qr8WOUQjX496A6LGO585Bnq/mtORS7BzkEFMPUCJ6JGioeDLWH8AVaG Wi9byMYvoaQQyZsa5LFuzy0QsCvFDOvEN/sK9yJpyamn8w1bP+19V5UuZG369UDxlk WBolOaLGj8sxT9jWDmOCziYBL5EknwIcQ07qLs/pRIW9AAJwuTmNRcm24RlDHnLNyj sD4uAzOm0Qh6t331Sugw/jMo= Received: from 99.100.19.101 (99-100-19-101.lightspeed.frokca.sbcglobal.net [99.100.19.101]) by holgerdanske.com with ESMTPSA (TLS_AES_128_GCM_SHA256:TLSv1.3:Kx=any:Au=any:Enc=AESGCM(128):Mac=AEAD) (SMTP-AUTH username dpchrist@holgerdanske.com, mechanism PLAIN) for ; Wed, 28 Feb 2024 18:08:15 -0800 Message-ID: <87eb268e-9429-414a-a3e6-d2e93eaa2119@holgerdanske.com> Date: Wed, 28 Feb 2024 18:08:14 -0800 List-Id: User questions List-Archive: https://lists.freebsd.org/archives/freebsd-questions List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-freebsd-questions@freebsd.org X-BeenThere: freebsd-questions@freebsd.org MIME-Version: 1.0 User-Agent: Mozilla Thunderbird From: David Christensen Subject: Re: FreeBSD 13.2R and OpenZFS bug #15933 To: questions@freebsd.org References: <27dc6dbd-2ca0-4385-8281-e6bde086bd13@holgerdanske.com> Content-Language: en-US In-Reply-To: <27dc6dbd-2ca0-4385-8281-e6bde086bd13@holgerdanske.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spamd-Bar: --- X-Spamd-Result: default: False [-3.80 / 15.00]; NEURAL_HAM_MEDIUM(-1.00)[-1.000]; NEURAL_HAM_LONG(-1.00)[-1.000]; NEURAL_HAM_SHORT(-0.91)[-0.910]; DMARC_POLICY_ALLOW(-0.50)[holgerdanske.com,none]; R_SPF_ALLOW(-0.20)[+a]; R_DKIM_ALLOW(-0.20)[holgerdanske.com:s=nov-20210719-112354]; ONCE_RECEIVED(0.10)[]; MIME_GOOD(-0.10)[text/plain]; XM_UA_NO_VERSION(0.01)[]; RCPT_COUNT_ONE(0.00)[1]; RCVD_VIA_SMTP_AUTH(0.00)[]; ASN(0.00)[asn:6939, ipnet:184.104.0.0/15, country:US]; MIME_TRACE(0.00)[0:+]; RCVD_COUNT_ONE(0.00)[1]; RCVD_TLS_ALL(0.00)[]; MLMMJ_DEST(0.00)[questions@freebsd.org]; ARC_NA(0.00)[]; FROM_EQ_ENVFROM(0.00)[]; FROM_HAS_DN(0.00)[]; MID_RHS_MATCH_FROM(0.00)[]; TO_DN_NONE(0.00)[]; PREVIOUSLY_DELIVERED(0.00)[questions@freebsd.org]; TO_MATCH_ENVRCPT_ALL(0.00)[]; DKIM_TRACE(0.00)[holgerdanske.com:+] X-Rspamd-Queue-Id: 4TlZQ11fP5z47y0 I am replying on the thread with the corrected bug number -- David On 2/27/24 19:12, Edward Sanford Sutton, III wrote: > On 2/27/24 16:00, David Christensen wrote: >> ... [since installing 12.1R] >> I have used freebsd-update(8) and pkg(8) exclusively to >> install software, to update/ update the system, and to update/ >> upgrade the software packages. > > That approach is fine, though on ZFS there are reports of major > freebsd-update upgrades taking unexpectedly long amounts of time. Thank you for the reply. :-) Thankfully, I did not experience upgrade problems with FreeBSD RELEASE 12.1 through 12.4-p9 (other than PEBKAC). (To replace the 12.4R computer, I plan to do a fresh install of 13.2R on another computer, backup the data on the 12.4R computer, and restore the data on the 13.2R computer. I will validate the data migration with mtree(8).) >> Is there a way to determine the origin (e.g. Illumos, OpenZFS) and >> version of the ZFS code that is running in the kernel on the above >> computer other than downloading the source tarball and crawling the >> code? >> >> https://download.freebsd.org/ftp/releases/amd64/12.4-RELEASE/ I decompressed the FreeBSD 12.4R src.xz tarball and looked for clues. There is a lot of code. Searching for "illumos" and "openzfs" proved interesting when comparing 12.4R and 13.2R: 2024-02-28 16:44:23 dpchrist@samba ~/unzipped/download.freebsd.org/ftp/releases/amd64/12.4-RELEASE/usr/src $ find . -name '*zfs*' | xargs grep -i illumos | wc 196 608 15804 2024-02-28 16:44:28 dpchrist@samba ~/unzipped/download.freebsd.org/ftp/releases/amd64/12.4-RELEASE/usr/src $ find . -name '*zfs*' | xargs grep -i openzfs | wc 0 0 0 2024-02-28 17:20:27 dpchrist@samba ~/unzipped/download.freebsd.org/ftp/releases/amd64/13.2-RELEASE/usr/src $ find . -name '*zfs*' | xargs grep -i illumos | wc 142 479 18266 2024-02-28 17:20:53 dpchrist@samba ~/unzipped/download.freebsd.org/ftp/releases/amd64/13.2-RELEASE/usr/src $ find . -name '*zfs*' | xargs grep -i openzfs | wc 86 576 10380 So, it appears FreeBSD 12.4R uses Illumos code and FreeBSD 13.2R uses OpenZFS code with some Illumos remnants. Crawling the 12.4R code, I am unable to find anything that looks like an Illumos release number or identifier (?). Looking at the Illumos GitHub page, it appears Illumos does not do releases (?): https://github.com/illumos/illumos-gate Releases No releases published I assume Illumos practices confirmation management, but I am unable to correlate the Illumos ZFS code in FreeBSD 12.4R with the Illumos GitHub repository. > You could read release notes or maybe follow feature support changes > that came along with the migration. I thought migration from Illumos > to OpenZFS (ZoL initially based effort) happened at 13. A case-insensitive search for "zfs" finds zero matching strings in the "Announcement" and "Release Notes" pages for 12.0R, 12.1R, 12.2R, 12.3R, or 12.4R: https://www.freebsd.org/releases/ >> I have been reading about OpenZFS data corruption bugs since >> November 2023 and delaying upgrading this and my other FreeBSD >> computers. I thought I had found an solution with FreeBSD 13.2R: >> >> https://lists.freebsd.org/archives/freebsd-questions/2024-February/004920.html > > Block cloning was accused for being the source of the November > 2023(?) bug which was tracked back to unrelated code from before > OpenZFS from before 2010. 12 was not immune to the November 2023 bug, > but it was less likely to happen due to fewer tools having as > advanced of filesystem API support; a patch was released before > support for 12 was dropped which freebsd-update should apply if it > hadn't happened yet (don't remember patch#). > >> But, another OpenZFS data corruption bug report was opened >> yesterday for the current version of OpenZFS (2.2.3): >> >> https://github.com/openzfs/zfs/issues/15933 OpenZFS bugs #15526 and #15933 appear to be integration bugs that involve the (Linux) kernel, GNU coreutils, and ZFS. The test case involves setting up a Portage system for Go on Gentoo Linux (?) and examining files manually for zeroed holes where non-zero values should be. I do not know if the test case can be run on FreeBSD, if there is a test case for these bugs on FreeBSD, or if the bugs do not apply to FreeBSD because the kernel is not Linux (?). >> Does this new OpenZFS bug [#15933] affect FreeBSD 13.2R? > > [#15933] mentions using block cloning which 13.2R does not include or > support on the base system. Though a pool may have that enabled, I > thought it was still disabled with a sysctl (that I hope never goes > away even when 100% bug free; its important to be able to rewrite > data on disk when desired). I am not sure if the bug is only produced > when block cloning is enabled or if block cloning just brings out a > different bug. Until the bug is properly 'debugged' or further > diagnosed, it would be hard to say what systems reproduce the issue > and under what conditions. So, is my data safe on up-to-date FreeBSD 13.2R ZFS with native encryption disabled? David