From nobody Sun Aug 27 18:13:24 2023 X-Original-To: questions@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4RYhdY2l91z4rTM7 for ; Sun, 27 Aug 2023 18:13:37 +0000 (UTC) (envelope-from 4250.82.1d5040001c80130.cc965bf5162c43682c82b842888b940f@email-od.com) Received: from s1-b0c6.socketlabs.email-od.com (s1-b0c6.socketlabs.email-od.com [142.0.176.198]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 4RYhdX1Ktzz4cmM for ; Sun, 27 Aug 2023 18:13:36 +0000 (UTC) (envelope-from 4250.82.1d5040001c80130.cc965bf5162c43682c82b842888b940f@email-od.com) Authentication-Results: mx1.freebsd.org; dkim=pass header.d=email-od.com header.s=dkim header.b=hsRbzODA; spf=pass (mx1.freebsd.org: domain of 4250.82.1d5040001c80130.cc965bf5162c43682c82b842888b940f@email-od.com designates 142.0.176.198 as permitted sender) smtp.mailfrom=4250.82.1d5040001c80130.cc965bf5162c43682c82b842888b940f@email-od.com; dmarc=none DKIM-Signature: v=1; a=rsa-sha256; d=email-od.com;i=@email-od.com;s=dkim; c=relaxed/relaxed; q=dns/txt; t=1693160016; x=1695752016; h=content-transfer-encoding:content-type:mime-version:references:in-reply-to:message-id:subject:to:from:date:x-thread-info:subject:to:from:cc:reply-to; bh=5hAn0FW+MlkHaX+9gGY5vv+J1x88Q4n6/UFM+buoRrQ=; b=hsRbzODACl3F2ypiAB3pjAlPBVtgcN9XxbC1SqYyi6h7aNjWiTiaOrwU3EP/S36tKOZH4GCLR9BLXQ0mJWifZ/vZM8pWkdc8/6zmR3BJ7OtxQYAI5Z3DugOY7h3DO0kC/HVGW4UoFZ33uh5Y9xrFzOXaN2ROrG3JcoFkDthI4IY= X-Thread-Info: NDI1MC4xMi4xZDUwNDAwMDFjODAxMzAucXVlc3Rpb25zPWZyZWVic2Qub3Jn Received: from r2.us-west-2.aws.in.socketlabs.com (r2.us-west-2.aws.in.socketlabs.com [142.0.190.2]) by mxsg2.email-od.com with ESMTP(version=Tls12 cipher=Aes256 bits=256); Sun, 27 Aug 2023 14:13:28 -0400 Received: from smtp.lan.sohara.org (EMTPY [185.202.17.215]) by r2.us-west-2.aws.in.socketlabs.com with ESMTP(version=Tls12 cipher=Aes256 bits=256); Sun, 27 Aug 2023 14:13:26 -0400 Received: from [192.168.63.1] (helo=steve.lan.sohara.org) by smtp.lan.sohara.org with smtp (Exim 4.95 (FreeBSD)) (envelope-from ) id 1qaKGL-000ADC-IE for questions@freebsd.org; Sun, 27 Aug 2023 19:13:24 +0100 Date: Sun, 27 Aug 2023 19:13:24 +0100 From: Steve O'Hara-Smith To: questions@freebsd.org Subject: Re: git-rebase(1) prior to a PR in in the github.com/freebsd area Message-Id: <20230827191324.eb8e546fdfb61469dd14bc5a@sohara.org> In-Reply-To: References: <20230827083631.192eb52f7b99e9ebd6b54ccf@sohara.org> X-Mailer: Sylpheed 3.7.0 (GTK+ 2.24.33; amd64-portbld-freebsd13.1) X-Clacks-Overhead: "GNU Terry Pratchett" List-Id: User questions List-Archive: https://lists.freebsd.org/archives/freebsd-questions List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-freebsd-questions@freebsd.org X-BeenThere: freebsd-questions@freebsd.org Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Spamd-Result: default: False [-2.70 / 15.00]; NEURAL_HAM_MEDIUM(-1.00)[-1.000]; NEURAL_HAM_LONG(-1.00)[-1.000]; NEURAL_HAM_SHORT(-1.00)[-0.997]; MV_CASE(0.50)[]; FORGED_SENDER(0.30)[steve@sohara.org,4250.82.1d5040001c80130.cc965bf5162c43682c82b842888b940f@email-od.com]; R_SPF_ALLOW(-0.20)[+ip4:142.0.176.0/20]; R_DKIM_ALLOW(-0.20)[email-od.com:s=dkim]; MIME_GOOD(-0.10)[text/plain]; MLMMJ_DEST(0.00)[questions@freebsd.org]; RCVD_TLS_LAST(0.00)[]; RCVD_IN_DNSWL_NONE(0.00)[142.0.190.2:received]; MIME_TRACE(0.00)[0:+]; FROM_NEQ_ENVFROM(0.00)[steve@sohara.org,4250.82.1d5040001c80130.cc965bf5162c43682c82b842888b940f@email-od.com]; ASN(0.00)[asn:7381, ipnet:142.0.176.0/22, country:US]; ARC_NA(0.00)[]; RCVD_COUNT_THREE(0.00)[3]; MID_RHS_MATCH_FROM(0.00)[]; TO_MATCH_ENVRCPT_ALL(0.00)[]; FROM_HAS_DN(0.00)[]; DKIM_TRACE(0.00)[email-od.com:+]; TO_DN_NONE(0.00)[]; RCPT_COUNT_ONE(0.00)[1]; DMARC_NA(0.00)[sohara.org]; DWL_DNSWL_NONE(0.00)[email-od.com:dkim] X-Spamd-Bar: -- X-Rspamd-Queue-Id: 4RYhdX1Ktzz4cmM On Sun, 27 Aug 2023 18:42:20 +0100 Graham Perrin wrote: > I did use 'git rebase -i' with success four days ago, for a PR in > someone else's repo (not a fork of a FreeBSD tree). Successful then, > however I have used the command so rarely – like, only a handful of > occasions over the past year or so – that my mind goes blank. Entirely > blank, and using a search engine will make things far worse for me. > > What should I do first, for the PR above? I would go with git rebase -i - it pretty much tells you what to do if you know what you want - but in this case it boils down to changing the pick in front of the commits to a sequence like edit squash squash ... Then tidying up the commit message. -- Steve O'Hara-Smith