From nobody Thu Jun 06 21:33:04 2024 X-Original-To: python@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4VwHdM2YXcz5N492 for ; Thu, 06 Jun 2024 21:33:43 +0000 (UTC) (envelope-from sunpoet@freebsd.org) Received: from smtp.freebsd.org (smtp.freebsd.org [IPv6:2610:1c1:1:606c::24b:4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "smtp.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4VwHdL6jYjz41xN for ; Thu, 6 Jun 2024 21:33:42 +0000 (UTC) (envelope-from sunpoet@freebsd.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1717709622; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=94NqsJxpCH2I+huAGS0GlrFEAdvaOr6d8asJA5zlwec=; b=Lk/wfgoZE/h7GjBlHf1/t4YoFNrv9heEKlKNeDU8OLg8hAYkjq+OdLvAOHeuGniKV22zXm W/Rkokqd7IezNc/FIITKYPfOARAn+G4EHLOXoXJok9JlMhf0RH9xZTJzJ53yC8kL4UVba4 Kiqo31ukVBgL72PVaY17G6sIfXDlOHKNNKjVh0PzaLCkCue6KGAKiT6NwxJ+Eappf8HXOs 2J4CAsTav6QCtNc1ad8ImcLow6jpYiv1PbSWvQd8YbCt2beJZnbwK+Dsr4oJyE9QJcCbDc EqB9jI7EiZ5mBoi+sZBE1Wb1XMTplGAeSzX8Zmhr32YL0wGjIaJENUUmHjTdHw== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1717709622; a=rsa-sha256; cv=none; b=EaBFjthrx56LFbau8P4DrKudD2GhXQV/mp0VqG221XPL0LYiS+oHDWXpAn7byG2A9jjWuI W3VJ0vG6b1/ODzbuRzrgNRJOtL33NxqoAN13mv4guLAUdUMsX18m+xjttyc+BQCZiFwZv/ p5tHwU3Q8FQ1Y4hfdqItLgU4SXC9egxllvhHWAlAPBQH6gIdndhVHB99mM5OhOHV46zQ4e JwguWJs6xHb4Qm7nu0qfF9PFSWujxmUgle7J7Y2nQfbAWy9/kvGY7EraKZmqWF4BDmLhZ3 2hHjXLQdVC7x02fgzhYQZJRnzmZE0XcxTYQf0SKdELM5ncThPupQJqAHk2bWvA== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1717709622; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=94NqsJxpCH2I+huAGS0GlrFEAdvaOr6d8asJA5zlwec=; b=HF09CWxSQRrbngevRRK34myoeYlMxZk8PzzTLC3PtNiSCCXt1gDlTd5/DqlPNqp4FGUDTh vR56JG1U0LCN3BV1J13Iz4NcnLFA0umFXqWec8j2bxwJicrwe6zP5gHyAmD8h5OVyl8sJN hWHSvHgFmQrhxHiijTOEkfM7Q+CHg0vuAdc1E0/iiDnQ6tT9VyRJ4jqjAX4+fHkF16H9if 0VntiY8mGXJDkFkf9/GziBC7IcaDS1qnb08eRc4NIjzKquuavguDSQwWf7yiUOxZ5Aas3T 4kQNmJesePAgwJze29RTELB1rhtCPDsPJVyv6blMquPFgca4/0lrsH25yMVk4Q== Received: from mail-ej1-f50.google.com (mail-ej1-f50.google.com [209.85.218.50]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "WR4" (verified OK)) (Authenticated sender: sunpoet) by smtp.freebsd.org (Postfix) with ESMTPSA id 4VwHdL69Ywz1ZS9 for ; Thu, 6 Jun 2024 21:33:42 +0000 (UTC) (envelope-from sunpoet@freebsd.org) Received: by mail-ej1-f50.google.com with SMTP id a640c23a62f3a-a68c5524086so166690766b.3 for ; Thu, 06 Jun 2024 14:33:42 -0700 (PDT) X-Forwarded-Encrypted: i=1; AJvYcCWEQHfxMG2fU/Di/diEggPV1IHOH8Ya8yp2Bu0ThzdUO49Yy7kg/64EThltsK59YWlqBmwi004NA/amYqOA96Mzev4= X-Gm-Message-State: AOJu0Yw41GtmyQP3gOMEO+8Vx1dyTuDVGbq2rtoj2vvlWhkx46dtD9YD q2rDF+eUC1aWN8HPKZAaWtNQQMzd1ezywYPVqh0xG4ZhNsAdS83j55/5QKrBVrQNH+xoQG4RKPa MiB+6PW/bPNGLBzAH8zkv2QjI5Ffsj34f+jH4ig== X-Google-Smtp-Source: AGHT+IFOUdHBss0v70mG0Q4Vnzod4miQBSLs42oLPLNimnPIsNiNbw553xgJ118O1LfwJrSDMaTd4zKijCl4uIV3ctI= X-Received: by 2002:a17:906:ad87:b0:a68:ec11:4561 with SMTP id a640c23a62f3a-a6cdc0e3a63mr46704166b.76.1717709621574; Thu, 06 Jun 2024 14:33:41 -0700 (PDT) List-Id: FreeBSD-specific Python issues List-Archive: https://lists.freebsd.org/archives/freebsd-python List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: freebsd-python@freebsd.org Sender: owner-freebsd-python@FreeBSD.org MIME-Version: 1.0 References: <202405191726.44JHQM14064613@gitrepo.freebsd.org> <34165e76-5b3d-4ed6-8395-c679ecb1e110@freebsd.org> In-Reply-To: <34165e76-5b3d-4ed6-8395-c679ecb1e110@freebsd.org> From: Po-Chuan Hsieh Date: Fri, 7 Jun 2024 05:33:04 +0800 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: git: b9a3602bb3da - main - devel/py-pyproject_hooks: Update to 1.1.0 To: Charlie Li Cc: ports-committers@freebsd.org, dev-commits-ports-all@freebsd.org, dev-commits-ports-main@freebsd.org, python@freebsd.org Content-Type: multipart/alternative; boundary="000000000000d26268061a3f6f08" --000000000000d26268061a3f6f08 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Tue, Jun 4, 2024 at 2:08=E2=80=AFAM Charlie Li wro= te: > Po-Chuan Hsieh wrote: > > The branch main has been updated by sunpoet: > > > > URL: > https://cgit.FreeBSD.org/ports/commit/?id=3Db9a3602bb3da661da313a970d4177= a95a1233afc > > > > commit b9a3602bb3da661da313a970d4177a95a1233afc > > Author: Po-Chuan Hsieh > > AuthorDate: 2024-05-19 16:17:56 +0000 > > Commit: Po-Chuan Hsieh > > CommitDate: 2024-05-19 17:15:43 +0000 > > > > devel/py-pyproject_hooks: Update to 1.1.0 > > > > Changes: > https://github.com/pypa/pyproject-hooks/blob/main/docs/changelog.rst > > > https://pyproject-hooks.readthedocs.io/en/latest/changelog.html > This is causing all setuptools builds under PEP-517 even upstream to fail= : > https://github.com/pypa/pyproject-hooks/issues/192 > https://github.com/pypa/setuptools/issues/4333 > > So far the only fallout here is with devel/py-setuptools58 since it uses > PEP-517 to build, but may want to consider rolling back pyproject_hooks > for now in case it takes a bit for upstream to figure out. > > -- > Charlie Li > ...nope, still don't have an exit line. > > IMHO, we do n=C3=B3t need to do anything right now as py-setuptools58 is no= t used by anything. It means we do not need to revert py-pyproject_hooks. Furthermore, I don't think current PY_SETUPTOOLS and devel/py-setuptools58 are needed in our ports tree. Since we could build almost every python port with pep517 (with minor fixes for the case in its name), we should always use devel/py-setuptools with correct version requirement rather than PY_SETUPTOOLS. In my case, there are 1,310 ports with USE_PYTHON=3Dpep517 and only 3 ports with USE_PYTHON=3Ddistutils which are intentional for simplicity. We should encourage people to convert their ports to pep517 build. And we should preserve PY_SETUPTOOLS for conditional dependency on py-setuptools for Python 3.12+. Best regards, sunpoet --000000000000d26268061a3f6f08 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
On Tue, Jun 4, 2024 at 2:08=E2=80=AFAM Ch= arlie Li <vishw= in@freebsd.org> wrote:
Po-Chuan Hsieh wrote:
> The branch main has been updated by sunpoet:
>
> URL: https:= //cgit.FreeBSD.org/ports/commit/?id=3Db9a3602bb3da661da313a970d4177a95a1233= afc
>
> commit b9a3602bb3da661da313a970d4177a95a1233afc
> Author:=C2=A0 =C2=A0 =C2=A0Po-Chuan Hsieh <sunpoet@FreeBSD.org><= br> > AuthorDate: 2024-05-19 16:17:56 +0000
> Commit:=C2=A0 =C2=A0 =C2=A0Po-Chuan Hsieh <sunpoet@FreeBSD.org><= br> > CommitDate: 2024-05-19 17:15:43 +0000
>
>=C2=A0 =C2=A0 =C2=A0 devel/py-pyproject_hooks: Update to 1.1.0
>=C2=A0 =C2=A0 =C2=A0
>=C2=A0 =C2=A0 =C2=A0 Changes:=C2=A0 =C2=A0 =C2=A0 =C2=A0 https://github.com/pypa/pyproject-hooks/blob/m= ain/docs/changelog.rst
>=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 = =C2=A0 https://pyproject-hooks.readth= edocs.io/en/latest/changelog.html
This is causing all setuptools builds under PEP-517 even upstream to fail:<= br> https://github.com/pypa/pyproject-hooks/issues/192=
https://github.com/pypa/setuptools/issues/4333

So far the only fallout here is with devel/py-setuptools58 since it uses PEP-517 to build, but may want to consider rolling back pyproject_hooks for now in case it takes a bit for upstream to figure out.

--
Charlie Li
...nope, still don't have an exit line.


IMHO, we do n=C3=B3t need to do anythi= ng right now as py-setuptools58 is not used by=C2=A0anything.
It = means we do not need to revert py-pyproject_hooks.

Furthermore, I don't think current PY_SETUPTOOLS and devel/py-setuptoo= ls58 are needed in our ports tree.
Since we could build almost ev= ery python port with=C2=A0pep517 (with minor fixes for the case in its name= ), we should always use devel/py-setuptools with=C2=A0correct=C2=A0version = requirement rather=C2=A0than PY_SETUPTOOLS.
In my case, there are= 1,310 ports with USE_PYTHON=3Dpep517 and only 3 ports with USE_PYTHON=3Ddi= stutils which are intentional for simplicity.

We s= hould encourage people to convert their ports to pep517 build.
An= d we should preserve PY_SETUPTOOLS for conditional dependency=C2=A0on py-se= tuptools for Python 3.12+.

Best regards,
sunpoet
--000000000000d26268061a3f6f08--