From nobody Sat Mar 12 03:16:32 2022 X-Original-To: python@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 2E4751A07D3B for ; Sat, 12 Mar 2022 03:16:33 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4KFnyS5hGmz3H77 for ; Sat, 12 Mar 2022 03:16:32 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2610:1c1:1:606c::50:1d]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 9FB992535F for ; Sat, 12 Mar 2022 03:16:32 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org ([127.0.1.5]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id 22C3GWDC019639 for ; Sat, 12 Mar 2022 03:16:32 GMT (envelope-from bugzilla-noreply@freebsd.org) Received: (from www@localhost) by kenobi.freebsd.org (8.15.2/8.15.2/Submit) id 22C3GW8g019638 for python@FreeBSD.org; Sat, 12 Mar 2022 03:16:32 GMT (envelope-from bugzilla-noreply@freebsd.org) X-Authentication-Warning: kenobi.freebsd.org: www set sender to bugzilla-noreply@freebsd.org using -f From: bugzilla-noreply@freebsd.org To: python@FreeBSD.org Subject: [Bug 262495] lang/python*: add option PGO and enable by default, add LTO option to python27 and enable by default Date: Sat, 12 Mar 2022 03:16:32 +0000 X-Bugzilla-Reason: AssignedTo CC X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Ports & Packages X-Bugzilla-Component: Individual Port(s) X-Bugzilla-Version: Latest X-Bugzilla-Keywords: X-Bugzilla-Severity: Affects Many People X-Bugzilla-Who: koobs@FreeBSD.org X-Bugzilla-Status: New X-Bugzilla-Resolution: X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: python@FreeBSD.org X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: cc attachments.created Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated List-Id: FreeBSD-specific Python issues List-Archive: https://lists.freebsd.org/archives/freebsd-python List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-freebsd-python@freebsd.org X-BeenThere: freebsd-python@freebsd.org MIME-Version: 1.0 ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1647054992; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=vFXIBBqBM2+ni13iK2eicLikvkVi79aMUUppt9Q60a4=; b=qLpRt+kwoOPui7va/69AA7tvf1fCeddXTonBrtuYUsonSwRVCfQvZuwIAVyPS5hvE8QFb0 LW5CwSh+1a/I2H7FKebiwPVbck19+FOlqn9bx0LTxNiOiDilzPwMAZneJZDKi1OqvAZ4+x H5ltzFks9UoDoGpGmB+Mv1zqlhIfQFTNDagtn2pzL9Q/kiMFNpbeDPkgZoDGWVE5GG3dmN IataVY3jrndrRbAb3JwpdWmH2fL1XgFy62QPr0q4Xh1P8I3SwqgVn4F8fORlqlSxx7THc5 p7Jfp+iOpsM7NlIKX0JgJLV7xHQg/6F8E7mU0YbGPw7d9oFDGtrKCK/asOVLCw== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1647054992; a=rsa-sha256; cv=none; b=kTWxUSHW2hUv1GFZLFQdbeOr1x9pLsTLWxoP7dJ3OOosG+gIb9yr3RoSfnnd4X6HlSHlqo bL7lAYgUnvInqOUKbICrYVPhCaE8WGT5deA8FEq/4n4K1hFr1md8BouoRfb64X6tselbXu zAzeMT83UYyHDRJQYGvSgfqC6kKJKnDRKutnSCBr90V3RnRTABMz3i6Q05d+wD8tVkSv5O oCatxguQMB3VKwSbNk6Yev9nIrYFXURbB+yy0AWFmZFFKpy58wz/4W8Yvxxi7oOWEBu+XI a0n86oNHaEEKMXj1TyNOGkMhvS45DDtSH0Tkz74aBktn6WRMq7WOYefWq2N15Q== ARC-Authentication-Results: i=1; mx1.freebsd.org; none X-ThisMailContainsUnwantedMimeParts: N https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D262495 Kubilay Kocak changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |koobs@FreeBSD.org --- Comment #1 from Kubilay Kocak --- Created attachment 232397 --> https://bugs.freebsd.org/bugzilla/attachment.cgi?id=3D232397&action= =3Dedit clang as cc detection for pgo Thanks Piotr What is the nature of the dependence on PGO for LTO?=20 If this is only a consequence of the 'optimization' option 'needing' both [= 1], we shouldn't couple ourselves to that option. Also I don't believe we should default to PGO builds, particularly at such = an early stage, as the profiling and optimizations instrumentation on the offi= cial package build hardware, will only be specific to that hardware, and may not= be appropriate for, is unlikely to be, or may result in performance regressions on, any other (user) hardware. There was also an issue identified during my testing with Python not detec= ting cc (clang) for PGO [2], which requires and additional '*)' case for default= ing to 'clang style PGO'. There may be alternate ways to address this, and this= was not tested in the gcc case. We wont want to carry local patches in the long term either, so working with upstream to resolve this is important. We'll also want to test and confirm QA across all supported freebsd version= s, archs, and toolchains (gcc included) explicitly, and include Python's test suite in that QA. At a minimum the test failure delta should not change. Unfortunately, a successful build alone is insufficient for LTO/PGO, and th= ere are many results for LTO/PGO Python segfaults and other issues at runtime o= ut there. [1] https://bugs.python.org/issue29766 [2] https://464982.bugs.gentoo.org/attachment.cgi?id=3D344902 --=20 You are receiving this mail because: You are the assignee for the bug. You are on the CC list for the bug.=