Re: Help in adding flavor support to sysutils/vimpager

When I use # make FLAVOR=x11, it does try to build x11 flavor of editors/vim but when I package all flavors of sysutils/vimpager and editors/vim to /usr/ports/packages local repository and then install any flavor of sysutils/vimpager with pkg, it still depends on vanilla editors/vim. It doesn't match with editors/vim's flavor. I wonder if this would make a problem FreeBSD build system builds it when my patch that improperly (?) added flavors support to sysutils/vimpager. The port has no maintainer and if I could get this flavor support working properly (?), I would want to take maintainership of this port.

I found out that a port does it like that below but in just one RUN_DEPENDS.
Code:

# cat ../../output
./editors/cream/Makefile:RUN_DEPENDS=   ${LOCALBASE}/bin/gvim:editors/vim@gtk3
# pkg ins cream
Updating FreeBSD repository catalogue...
FreeBSD repository is up to date.
Updating custom repository catalogue...
Fetching meta.conf: 100%    178 B   0.2kB/s    00:01
Fetching data.pkg: 100%    5 KiB   4.7kB/s    00:01
Processing entries: 100%
The provides database is up-to-date.
custom repository update completed. 17 packages processed.
All repositories are up to date.
The following 2 package(s) will be affected (of 0 checked):

New packages to be INSTALLED:
        cream: 0.43 [FreeBSD]
        vim-gtk3: 9.1.0764 [FreeBSD]

Number of packages to be installed: 2

The process will require 43 MiB more space.
10 MiB to be downloaded.

Proceed with this action? [y/N]:

# pkg ins -r custom vimpager-x11
Updating custom repository catalogue...
Fetching meta.conf: 100%    178 B   0.2kB/s    00:01
Fetching data.pkg: 100%    5 KiB   4.7kB/s    00:01
Processing entries: 100%
The provides database is up-to-date.
custom repository update completed. 17 packages processed.
All repositories are up to date.
Checking integrity... done (0 conflicting)
The following 2 package(s) will be affected (of 0 checked):

New packages to be INSTALLED:
        vim: 9.1.0915 [custom]
        vimpager-x11: 2.06.20241028 [custom]

Number of packages to be installed: 2

The process will require 41 MiB more space.

Proceed with this action? [y/N]:

On 1/3/25 22:02, Yusuf Yaman wrote:

> Hi. I want to add flavors support to sysutils/vimpager but i am unable
> to do it. I need to use x11 flavor of editors/vim because I need
> clipboard support which isn't available in console (default) flavor of
> editors/vim. What I want to do is, When I install vimpager's x11 or any
> other flavor of vimpager, it should pick up editors/vim's x11 flavor,
> not console flavor. Currently, it doesn't work that way, it only picks
> up editors/vim console flavor. So, both flavors of editors/vim and
> sysutils/vimpager should match to each other. I don't know if it's
> possible but I guess it is. Any help appreciated, thanks in advance and
> happy new year!
>
> Here is the bugzilla report URL:
> https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=283220