From nobody Sun Sep 29 15:52:32 2024
X-Original-To: freebsd-ports@mlmmj.nyi.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1])
	by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4XGpcf0ly1z5XqDq
	for <freebsd-ports@mlmmj.nyi.freebsd.org>; Sun, 29 Sep 2024 15:52:34 +0000 (UTC)
	(envelope-from fuz@fuz.su)
Received: from fuz.su (fuz.su [IPv6:2001:41d0:8:e508::1])
	(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
	 key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256
	 client-signature RSA-PSS (2048 bits) client-digest SHA256)
	(Client CN "fuz.su", Issuer "fuz.su" (not verified))
	by mx1.freebsd.org (Postfix) with ESMTPS id 4XGpcd6XXSz4rJ6;
	Sun, 29 Sep 2024 15:52:33 +0000 (UTC)
	(envelope-from fuz@fuz.su)
Authentication-Results: mx1.freebsd.org;
	none
Received: from fuz.su (localhost [127.0.0.1])
	by fuz.su (8.18.1/8.18.1) with ESMTPS id 48TFqWPM008585
	(version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384 bits=256 verify=NO);
	Sun, 29 Sep 2024 17:52:32 +0200 (CEST)
	(envelope-from fuz@fuz.su)
Received: (from fuz@localhost)
	by fuz.su (8.18.1/8.18.1/Submit) id 48TFqW1j008584;
	Sun, 29 Sep 2024 17:52:32 +0200 (CEST)
	(envelope-from fuz)
Date: Sun, 29 Sep 2024 17:52:32 +0200
From: Robert Clausecker <fuz@freebsd.org>
To: Norbert Grundmann <ngrundmann@gmx.de>
Cc: Robert Clausecker <fuz@freebsd.org>,
        FreeBSD Mailing List <freebsd-ports@freebsd.org>
Subject: Re: Using --recursive in Makefile / github clone
Message-ID: <Zvl3wOFekkidH70p@fuz.su>
References: <f9d46a4d-7735-4952-8b88-87021f172b5b@gmx.de>
 <Zvl1j8IV4jfMFNtm@fuz.su>
 <8011bacc-1e59-491a-95e7-042ae6ce162f@gmx.de>
List-Id: Porting software to FreeBSD <freebsd-ports.freebsd.org>
List-Archive: https://lists.freebsd.org/archives/freebsd-ports
List-Help: <mailto:ports+help@freebsd.org>
List-Post: <mailto:ports@freebsd.org>
List-Subscribe: <mailto:ports+subscribe@freebsd.org>
List-Unsubscribe: <mailto:ports+unsubscribe@freebsd.org>
X-BeenThere: freebsd-ports@freebsd.org
Sender: owner-freebsd-ports@FreeBSD.org
MIME-Version: 1.0
Content-Type: text/plain; charset=iso-8859-1
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <8011bacc-1e59-491a-95e7-042ae6ce162f@gmx.de>
X-Rspamd-Pre-Result: action=no action;
	module=replies;
	Message is reply to one we originated
X-Spamd-Result: default: False [-4.00 / 15.00];
	REPLY(-4.00)[];
	ASN(0.00)[asn:16276, ipnet:2001:41d0::/32, country:FR]
X-Rspamd-Queue-Id: 4XGpcd6XXSz4rJ6
X-Spamd-Bar: ----

Hi Norbert,

Am Sun, Sep 29, 2024 at 05:46:16PM +0200 schrieb Norbert Grundmann:
> Hi Robert,
> 
> Thanks :-)  But is it good and recommended to use an explicit
> 
> git clone --recursive repo
> 
> instead of GH_TUPLE?  It would make things more easy...

This is not permitted.  We require that distfiles be fetched in the fetch
phase, then be checked against the distinfo file, and only then be
extracted.  git-clone(1) does not permit us to do so and can thus not be
used to obtain project source.  If you submit a patch with this sort of
stuff in the Makefile, it'll be rejected.

> Cheers, Norebrt

Yours,
Robert Clausecker

-- 
()  ascii ribbon campaign - for an encoding-agnostic world
/\  - against html email  - against proprietary attachments