From nobody Wed Sep 25 22:59:05 2024 X-Original-To: freebsd-ports@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4XDXGp3jPfz5Xpvs for ; Wed, 25 Sep 2024 22:59:14 +0000 (UTC) (envelope-from tatsuki_makino@hotmail.com) Received: from APC01-PSA-obe.outbound.protection.outlook.com (mail-psaapc01olkn2070.outbound.protection.outlook.com [40.92.52.70]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "mail.protection.outlook.com", Issuer "DigiCert Cloud Services CA-1" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4XDXGn34W2z451M; Wed, 25 Sep 2024 22:59:13 +0000 (UTC) (envelope-from tatsuki_makino@hotmail.com) Authentication-Results: mx1.freebsd.org; dkim=pass header.d=hotmail.com header.s=selector1 header.b=INqeQViJ; spf=pass (mx1.freebsd.org: domain of tatsuki_makino@hotmail.com designates 40.92.52.70 as permitted sender) smtp.mailfrom=tatsuki_makino@hotmail.com; dmarc=pass (policy=none) header.from=hotmail.com; arc=pass ("microsoft.com:s=arcselector10001:i=1") ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=JHocPFjdH/fH1/euVcmjkZ/kGisChxFLvx/EOtJjXR4kPYcPcBHU9rwnis5JLq7hWYByfCtcsBC7T0fzkWTtLxm69W0DTSi3N8WTnvFlXsUyg5D+erYvOfZBO5RRhLDxwyc4+mH4fQNUQbPS2ySlIEWhwXW6rSEgcjRT4WeVKgMSwKxBUTNCsYnLcM+uH4Tjzj8dYRmOgUcCVgnCPkg8Y7/+z/W1+Z0F4OxpDuD3WskRnrOVzo+D3icx7RfdZuIRnxWsUrO3A4uinf3oFELGSGJIwEv1grOjMY77gXRsVC3PXWvSaT4CrpndKfKZrnQjz3FigQgeldSiq111rGd0nw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=bnbjXzsVbO3GnHtTS5iuUkgQqU8DBGHAscbhFRMh1NI=; b=XQ25xiXKwdFkmlEwhVl+GXlnMJJuAHl7h1f9RS8O2hRdIEvi3dz+a7gU3SPnr5TtjwkPRnTC3Ie8aFnQHe6Btj9DRReuct1D+Ch/8vtcsUoidnF0ktmQHaQbxnFyIDrlU9YkjBOXeg2oe4tsEsBYG3KoD79tje1euNU2M4kwZIfL6jD//PCHm8klEjg+v/wo5iVRAy0A4k83hUOB4MS25JCDMKzBjvyXR7loHYJjzv4DpNrYWM0JGZlap+OA3wld9CZEoJdTZSA9PjylwCkdrsqq7NHq/EUU+BpSzRxjp02g30E1/KRtXIyN4mfiMXYmay9FxftaW8Sn2qQoFIduaQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=hotmail.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=bnbjXzsVbO3GnHtTS5iuUkgQqU8DBGHAscbhFRMh1NI=; b=INqeQViJsdh6RhU6pbbpxpAqqPdfqHrCa5WmVuec+UKE/eI+qztNJBUDJ/tCnf/H5aeJmBDO3Nm6ZO9Fiy9bRlhGffLcQPtXcsBO3WPsK0GK74f7yofdLCYWO73Y2RKBXwHdRO+iZjYS/QHwrOEMp7I50RILrgYRiB6groik8muaJhDd0G4PYG2z+4HNKWhuyJunpQC6mOBNOqB1bU2+cAbYoXzJm/oWRv1ELQg8etVqoRGlpOR3DwPzcybO/0eAZdtSNuD8/aw00NwLJJJlawWMwiGUIQ/8cRyPukqq2/nx8cNEj5pZur7ALMhBuZ76eq8QY3MJXX9BQvI82Ib9ag== Received: from TYZPR01MB5037.apcprd01.prod.exchangelabs.com (2603:1096:400:25d::14) by SEYPR01MB4974.apcprd01.prod.exchangelabs.com (2603:1096:101:b9::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7982.25; Wed, 25 Sep 2024 22:59:09 +0000 Received: from TYZPR01MB5037.apcprd01.prod.exchangelabs.com ([fe80::c7d4:ec76:4df3:557c]) by TYZPR01MB5037.apcprd01.prod.exchangelabs.com ([fe80::c7d4:ec76:4df3:557c%6]) with mapi id 15.20.8005.017; Wed, 25 Sep 2024 22:59:09 +0000 Message-ID: Date: Thu, 26 Sep 2024 07:59:05 +0900 User-Agent: Mozilla Thunderbird Subject: Re: ports-mgmt/pkg: condition for a devnullfd that can be closed To: =?UTF-8?Q?Dag-Erling_Sm=C3=B8rgrav?= , "freebsd-ports@FreeBSD.org" References: <86ldzoywdp.fsf@ltc.des.dev> Content-Language: en-US From: Tatsuki Makino In-Reply-To: <86ldzoywdp.fsf@ltc.des.dev> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-ClientProxiedBy: OSTP286CA0079.JPNP286.PROD.OUTLOOK.COM (2603:1096:604:227::16) To TYZPR01MB5037.apcprd01.prod.exchangelabs.com (2603:1096:400:25d::14) X-Microsoft-Original-Message-ID: <05a9c419-8d6e-490f-be20-de1100ddfa5d@hotmail.com> List-Id: Porting software to FreeBSD List-Archive: https://lists.freebsd.org/archives/freebsd-ports List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: freebsd-ports@freebsd.org Sender: owner-freebsd-ports@FreeBSD.org MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: TYZPR01MB5037:EE_|SEYPR01MB4974:EE_ X-MS-Office365-Filtering-Correlation-Id: 08cee6b3-3bc4-4984-073f-08dcddb5a9be X-Microsoft-Antispam: BCL:0;ARA:14566002|6090799003|5072599009|461199028|8060799006|19110799003|7092599003|15080799006|440099028|3412199025; X-Microsoft-Antispam-Message-Info: GXUxOhWoSr5tfgy4x+putzUfpv9z68b2ILt0GKoJrTJp8boztk94VsbCWHTDk3FGw4np0bJxISydzAb5/LjaiDbU0C+jr+GsQqXx52Gem+q9zGGNlsT9AWppQFg438LXz+C4pa2UrkmmqWD3dznJq1GcudLtHVF9jimb2Y2crkrG7gKVE+MQDArVKBNIzYnl62xAY0f/ccmG093xktmfiSUgGPkzlmhoyY6VGvkpA34YYKodtu34OsBXc3tc/Ih0YfCb5nNxb6xiA9CLYySF0dTJ6mYJE/C7NoLbcO25lah/8Il5Nuiez/R64caQOTWTZtWATFojtbTaVGCiss/dFcvzVsdQQTqUfGWJC8sE3sTzT7FNhrWf/m5YGxNOtWLPCpvj7ysQ17FYmZmGZDnKre1udAZlM+dFgU1Z5PeUlHYc8czmdxOlHVc/V/AEO7vrawKdr6MzKNobUo0UIXs9S8FuHmVRV3tpliYHlw5O/ReSEwyCDcX08iWkb5NzQ9OIDNA+yDcsCBTZYWZkUZBvzDHGjt9/PQWeO9rYbdaXESx2MmU/HuxlEzGNdVLPKUYGrvVrXKlSNVgL/JfWPIBTxmfPYOLAH/tXrUXCS5W6HTibPq4f5vyRZTFJdXtCmL0X867ogN05KhjsqkOnvX1GhU+dv90hMTBW2nQPvrU+Trc0dk0X/tCCTtgSfCMW1pLT6vlmgahgGZSi3RPRxKgq1ehHKvV6jFjj8r+tGEJHzJCnR/RerkToS7xM2w9I46J3kB+cme4b9ewerF3y6nHbhg== X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?SlpBRXNpMGI2TzQ0UVBvV2tXdnRRVENQOEJIRXJTTG5WRmQzWk11NldPRC8z?= =?utf-8?B?cTZQMXlMTlhJOGNGUEUwbE9JdTRHdkl0Z3ppWERkUDFWWjVqYVIrNFE4TTFr?= =?utf-8?B?MDVONCtrMmZld3lrYU93ZHFqMTRPRWh6SzhrSzloeUcyczlOUjI5YjVNQzdW?= =?utf-8?B?c25VRHQ5ZTVURy9iTm8vQVV1cEV3alVSMXpzMkpFUnk0dkVEQ2pQZzYxNGQz?= =?utf-8?B?K0oybTh2RlZtYjNaN3lPOVlkU3JwaFhmMTlEOFo3WFlpTEd4YXJoOUNKakNT?= =?utf-8?B?MGZKTlZ5TFo0TndPVHl3ZDhnRGJFUytJckgwUXFlU3BOWTcrRHl0OG9EZFJN?= =?utf-8?B?cE9HbUk5NGIxWjZQYkwzUW9TRlJsVVVHTEdFZjh1ekVwOGwwRkgwZHlRUHhC?= =?utf-8?B?VlkvMEpsU0N1cnpONkJheVUySGhCSnVFdHFkRlE2ZnNyaHVWNDNXTlY4allF?= =?utf-8?B?MlAwTFFmeVB0bDNHNHl2WitITzhmWTZwMlRQaWorRWM5MDBRdHR6UlIxUkcx?= =?utf-8?B?a3ZiZFJmYjI2Vjh1cjJ4YXMvd3MwZmF3MFYyaERkcHRZYWZaRGJIT1FYcHQ3?= =?utf-8?B?RlN2dkxRejRtb0lnU1hIVjhFNWlFbWN2VzN2cHg1MG1pRmlBZlJBVm1GRjA5?= =?utf-8?B?QnphMG5qTUJQclVtVHFPN2JlbEtrcXc5MWduZC9tNFp1S1B2OE5jU1JQT3Y3?= =?utf-8?B?UEZ4dXo4UklrMGFiRHh4V003aFBBdzlHUmJTNFQzRHZOQ2swTXZjTGZ4UHNX?= =?utf-8?B?dDFLWjlmWXZpVHJqemh0SVhWZkMrTlhqU1FtVFJPTDVRWnRxQkFzZnBYTG1O?= =?utf-8?B?a0ticjRwZHdZZkQxUlA0Y2FFVlJCUlBQZXIwdm8yNXlhZUhGRW1zYk80Qk1S?= =?utf-8?B?NlhiblBXekxMREVBVDB5NGRRSm05VXV0NUJOaHY5N1hqeW1sNzBJVWYzckV6?= =?utf-8?B?NlNEa1pzbU5WUkp5aWVoV1NQSXMvN3FCTFUyZVlhdXNBVjhuczd3cTlMbjBD?= =?utf-8?B?c1Z1NUY0Uk5OTXl6V0V1NFBPbEpsNlMzTVE1VFkxSXVFYUVFb01ISXdHUEhm?= =?utf-8?B?OUhpbEhLYUFwTS9xNTRmV1pvME50b2lRakQxYlRhcVdiU29lZTQrMDRoSDhV?= =?utf-8?B?T0hiais5QkorWGd2L3g3cENSc2tlUzJnYXVldTFBaG5adFFVYk5maDN5VjJC?= =?utf-8?B?dWxEcW1OZHEybHd3M1p1SmRvRVZnZFpNNkF1eDduNEo4eGJQVElsMzRMS2Ux?= =?utf-8?B?M1ZYQnVMVG9BWU9IZFU4VUVCS1d1Q2hwcHR0SitGYTdCc3I2RFBXNXZaUWVu?= =?utf-8?B?Rld6QTNiYThwUXFheHNjOVFBeG42Uk9OTUZaOVZmUTJRQ1dlamJFVk8vaHhE?= =?utf-8?B?dDB0L2dQa3l0RXZVZ1lJenhIa0E5RGZTckN0cW9zTUQveStLeUpueXFHZi9X?= =?utf-8?B?aHFXUEdhandWbmpmR3BaaXU2WlBZNVNPMHNFQklEM3dDNmpYaHV5ZGt5bU1j?= =?utf-8?B?UHJCZzR5Ry9ZUFg0ODJEa29kWXBSTTVUZFp1UGVCbWdwMUw3WHUzNjlnRUlj?= =?utf-8?B?bDhRUURUMytZSFV6RVF1ekxnd3l1c2tpenhoc3FTWVlPTFdUTkFLT2lhTS9F?= =?utf-8?B?c3pBNmVuSDBuUHFTQ2U1aEd3N2V3cW0vTWdZZmZqL2pSRXhMbXJtN2h3elNs?= =?utf-8?Q?hp2dh8Wj+xtCB2kbwJIi?= X-OriginatorOrg: sct-15-20-7719-20-msonline-outlook-b4c57.templateTenant X-MS-Exchange-CrossTenant-Network-Message-Id: 08cee6b3-3bc4-4984-073f-08dcddb5a9be X-MS-Exchange-CrossTenant-AuthSource: TYZPR01MB5037.apcprd01.prod.exchangelabs.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 25 Sep 2024 22:59:08.9277 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa X-MS-Exchange-CrossTenant-RMS-PersistedConsumerOrg: 00000000-0000-0000-0000-000000000000 X-MS-Exchange-Transport-CrossTenantHeadersStamped: SEYPR01MB4974 X-Spamd-Result: default: False [-2.46 / 15.00]; FORGED_MUA_THUNDERBIRD_MSGID_UNKNOWN(2.50)[]; NEURAL_HAM_LONG(-1.00)[-1.000]; ARC_ALLOW(-1.00)[microsoft.com:s=arcselector10001:i=1]; NEURAL_HAM_MEDIUM(-1.00)[-1.000]; NEURAL_HAM_SHORT(-0.97)[-0.971]; DMARC_POLICY_ALLOW(-0.50)[hotmail.com,none]; R_SPF_ALLOW(-0.20)[+ip4:40.92.0.0/16]; R_DKIM_ALLOW(-0.20)[hotmail.com:s=selector1]; MIME_GOOD(-0.10)[text/plain]; XM_UA_NO_VERSION(0.01)[]; DWL_DNSWL_NONE(0.00)[hotmail.com:dkim]; FREEMAIL_ENVFROM(0.00)[hotmail.com]; MIME_TRACE(0.00)[0:+]; FREEMAIL_FROM(0.00)[hotmail.com]; TO_DN_SOME(0.00)[]; ASN(0.00)[asn:8075, ipnet:40.80.0.0/12, country:US]; RCVD_COUNT_TWO(0.00)[2]; FROM_HAS_DN(0.00)[]; RCVD_TLS_LAST(0.00)[]; TO_MATCH_ENVRCPT_ALL(0.00)[]; TO_DN_EQ_ADDR_SOME(0.00)[]; MLMMJ_DEST(0.00)[freebsd-ports@freebsd.org]; FROM_EQ_ENVFROM(0.00)[]; RCPT_COUNT_TWO(0.00)[2]; DKIM_TRACE(0.00)[hotmail.com:+] X-Rspamd-Queue-Id: 4XDXGn34W2z451M X-Spamd-Bar: -- Hello. It is an exaggeration, because the correction is just to add one character. Wouldn't it be possible to commit it at the same time as other modifications? ... I was thinking about it, but I remembered something that was just convenient :) %% of pkg-query doesn't work. Even if we want to use % as a separator, like pkg query %n%%%v, we can't do it. But I still don't understand how to submit pull request :) Regards. On 2024/09/19 15:45, Dag-Erling Smørgrav wrote: > Tatsuki Makino writes: >> While looking at libpkg/pkg_config.c, I noticed that the condition of >> the conditional branch in function pkg_close_devnull may not be >> correct. > > Feel free to submit a pull request: https: //github.com /freebsd/pkg/ > > DES