From nobody Thu Sep 19 06:45:38 2024 X-Original-To: freebsd-ports@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4X8QyF18d3z5XJ5V for ; Thu, 19 Sep 2024 06:45:41 +0000 (UTC) (envelope-from des@freebsd.org) Received: from smtp.freebsd.org (smtp.freebsd.org [96.47.72.83]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "smtp.freebsd.org", Issuer "R10" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4X8QyF0cnMz3wry; Thu, 19 Sep 2024 06:45:41 +0000 (UTC) (envelope-from des@freebsd.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1726728341; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=ndAAWocIJ1dxTQMu4npAfBNRaFpwAF9SCHhvqgDGbpg=; b=tqqsQl0hiGEnZTb/Cdoc+Ww2JZ5sI+NAs0M5eRC6C5GjBTRzLrVXYxFLiurAvMdr3CFTBR i+tQ0DFifShMpyEjCGjGk76FRGRo8988gTfGdxhTTGPzpF55rFR11wr6+NqKGoVxwZzUKL 3u7n6cnDoAqzZrBVltquPQRZBQB0mj1mOg3eBCVe+D/9IdoKEbw0o3EVbwHwmMPOvXoStV xv7LOa/nigzZUKtZDMpup2uvMg193rqk/MJGfAXaSb1WOt48CWr5QfOsOKcJKjwsoqWCeu uU2jpht7QyV5Puy8sBESgKcGVPVnPsxxOJZSgZL23u4qnYV4VnDHar/v3yz7VQ== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1726728341; a=rsa-sha256; cv=none; b=cDECxTmQeQD2uDNp3bp371tkK9UGgBK/n1cw5jGTUbzEFZqsMMuwEl24zpVISPP/mmjunw DDPdq1MrlwxHs1i3qrauUTY5rhuB5wUnT7lvn1xpwpu4+mGrzoN0/7M70YhulmU4yVA6mm ZXnbID42x6+4qDZiUQVdtauCOSSZi+p9zQ2AeWKp0nWTbMJMoRx/fMtgAqwHu1cykDRY2K eaZKg+wJmdK/iauytY+9WErRwupuqBT4NqoZRB8qBRWFwWQfqusbW79V8H0b3Updm7uAZm EuIpucuvn9+w376fXiT/bam47xk2F9fKY4hg5NI3Tj35O46+2vsXvLeA8Muwew== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1726728341; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=ndAAWocIJ1dxTQMu4npAfBNRaFpwAF9SCHhvqgDGbpg=; b=NROcbc2sfqoCzk5ru902XwPTcqa8yAvYHT/uDHKljtDpxLB4vZA5uqAl9lBqdmNFyMb2Y4 L7NJ36z5JndSFau/Ot+GRU5sSVdSzLN5m6+1wha99rxP32jwMbOPAq7O1OaLOXn7dkBrwp xLSzDHXlHtPQDduQjF4kD2V0kcGRntFwdIu1oU0Gv6xxE/gOFuox6rMbvVDU9nu1IX6Y5c lzLq/FtzlIR43Ul35WWBUerx7ArlFCpkkieOLbPof1wuQavBy0mrjPmVtVUgQ/h22VYjxt I4ot5XLhPIHaPWaeTsz8+WzJuMun+DuH3xGLCQB+yXvWkc67A0XihE7tiaDJ+Q== Received: from ltc.des.dev (unknown [IPv6:2a01:e0a:386:9c20:922e:16ff:fef1:acef]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) (Authenticated sender: des) by smtp.freebsd.org (Postfix) with ESMTPSA id 4X8QyD6fhtzYVj; Thu, 19 Sep 2024 06:45:40 +0000 (UTC) (envelope-from des@freebsd.org) Received: by ltc.des.dev (Postfix, from userid 1001) id F1056BC74E; Thu, 19 Sep 2024 08:45:38 +0200 (CEST) From: =?utf-8?Q?Dag-Erling_Sm=C3=B8rgrav?= To: Tatsuki Makino Cc: "freebsd-ports@FreeBSD.org" Subject: Re: ports-mgmt/pkg: condition for a devnullfd that can be closed In-Reply-To: (Tatsuki Makino's message of "Mon, 16 Sep 2024 20:13:24 +0900") References: User-Agent: Gnus/5.13 (Gnus v5.13) Date: Thu, 19 Sep 2024 08:45:38 +0200 Message-ID: <86ldzoywdp.fsf@ltc.des.dev> List-Id: Porting software to FreeBSD List-Archive: https://lists.freebsd.org/archives/freebsd-ports List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: freebsd-ports@freebsd.org Sender: owner-freebsd-ports@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Tatsuki Makino writes: > While looking at libpkg/pkg_config.c, I noticed that the condition of > the conditional branch in function pkg_close_devnull may not be > correct. Feel free to submit a pull request: https://github.com/freebsd/pkg/ DES --=20 Dag-Erling Sm=C3=B8rgrav - des@FreeBSD.org