Re: thunderbird 128.4.0 build fail on -current

From: Nuno Teixeira <eduardo_at_freebsd.org>
Date: Mon, 28 Oct 2024 12:07:54 UTC
https://github.com/joncampbell123/dosbox-x/issues/5259

Nuno Teixeira <eduardo@freebsd.org> escreveu (domingo, 27/10/2024 à(s)
13:54):

> Hello,
>
> Getting similar results on emulators/dosbox-x:
> ###
> usr/include/c++/v1/string:2861:5: error: implicit instantiation of
> undefined template 'std::char_traits<unsigned short>'
>  2861 |     traits_type::assign(std::__to_address(__p) + __sz, __n, __c);
>       |     ^
> /usr/include/c++/v1/string:3302:5: note: in instantiation of member
> function 'std::basic_string<unsigned short>::append' requested here
>  3302 |     append(__n - __sz, __c);
>       |     ^
> /usr/include/c++/v1/string:1303:84: note: in instantiation of member
> function 'std::basic_string<unsigned short>::resize' requested here
>  1303 |   _LIBCPP_HIDE_FROM_ABI _LIBCPP_CONSTEXPR_SINCE_CXX20 void
> resize(size_type __n) { resize(__n, value_type()); }
> ###
>
> Full log:
> https://pkg-status.freebsd.org/beefy18/data/main-amd64-default/p645a502a4f60_s8b2e7da7085/logs/dosbox-x-2024.10.01.log
>
> Any hints before I open an upstream PR?
>
> Thanks,
>
> Jung-uk Kim <jkim@freebsd.org> escreveu (domingo, 27/10/2024 à(s) 06:57):
>
>> On 24. 10. 26., Michael Butler wrote:
>> > After the llvm19 import and today's thunderbird update, I ran into ..
>> >
>> > In file included from /usr/ports/mail/thunderbird/work/
>> > thunderbird-128.4.0/comm/third_party/rnp/src/lib/crypto/
>> > cipher_botan.cpp:26:
>> > In file included from /usr/include/c++/v1/sstream:317:
>> > In file included from /usr/include/c++/v1/__ostream/basic_ostream.h:16:
>> > In file included from
>> /usr/include/c++/v1/__system_error/error_code.h:18:
>> > In file included from /usr/include/c++/v1/__system_error/
>> > error_category.h:15:
>> > /usr/include/c++/v1/string:820:42: error: implicit instantiation of
>> > undefined template 'std::char_traits<unsigned char>'
>> >    820 |   static_assert(is_same<_CharT, typename
>> > traits_type::char_type>::value,
>> >        |                                          ^
>> > /usr/ports/mail/thunderbird/work/thunderbird-128.4.0/comm/third_party/
>> > rnp/src/lib/crypto/cipher_botan.cpp:83:65: note: in instantiation of
>> > template class 'std::basic_string<unsigned char>' requested here
>> >     83 |     const char *cipher_string =
>> id_str_pair::lookup(cipher_map,
>> > cipher, NULL);
>> >
>> |                                                                 ^
>> > /usr/include/c++/v1/__fwd/string.h:23:29: note: template is declared
>> here
>> >     23 | struct _LIBCPP_TEMPLATE_VIS char_traits;
>> >        |                             ^
>> > 1 error generated.
>> >
>> >   .. which appears to be similar to the issue with devel/poco and fixed
>> > in commit c55157301f317ab8166349340d4cc0765deaac12,
>>
>> FYI, I filed PR282347 with the fix.
>>
>> https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=282347
>>
>> Jung-uk Kim
>>
>>
>
> --
> Nuno Teixeira
> FreeBSD UNIX:  <eduardo@FreeBSD.org>   Web:  https://FreeBSD.org
>


-- 
Nuno Teixeira
FreeBSD UNIX:  <eduardo@FreeBSD.org>   Web:  https://FreeBSD.org