Re: ports-mgmt/portlint vs absent USE_LDCONFIG

From: Tatsuki Makino <tatsuki_makino_at_hotmail.com>
Date: Wed, 09 Oct 2024 06:16:36 UTC
Hello.

I feel like it would be a good to do the following...

if ($makevar{USE_LDCONFIG} ne "") {
   if ($makevar{USE_LDCONFIG} eq "$makevar{PREFIX}/lib" && !$found_prefix_so) {
     &perror("WARN", ... objects into \${PREFIX}/lib.");
   } elsif (!$found_so) {
     &perror("WARN", ... objects.");
   }
}

I don't know if it is the right condition :)

Regards.


On 2024/10/09 11:52, Sergei Vyshenski wrote:
>   Hi,
> 
> ports-mgmt/portlint-2.22.2 seems to be broken.
> 
> If a port does NOT define USE_LDCONFIG,
> and this port does NOT install shared objects,
> then portlint complains with:
> 
> You have defined USE_LDCONFIG, but this port does not install any shared
> objects.
> 
> Example can be found here:
> https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=281925
> 
> Last week line 917 of file ports-mgmt/portlint/src/portlint.pl
> has been altered and now reads as follows:
> 
> if ($makevar{USE_LDCONFIG} ne "$makevar{PREFIX}/lib" && !$found_so) {
> 
> Maybe it should instead be like this:
> 
> if ($makevar{USE_LDCONFIG} ne "" && !$found_so) {
> 
> Regards, Sergei
>