From nobody Tue Oct 08 15:16:49 2024 X-Original-To: ports@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4XNKPJ0L6Hz5ZWbl for ; Tue, 08 Oct 2024 15:16:52 +0000 (UTC) (envelope-from SRS0=EKhA=RE=klop.ws=ronald-lists@realworks.nl) Received: from smtp-relay-int.realworks.nl (smtp-relay-int.realworks.nl [194.109.157.24]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 4XNKPH3HKWz4q0p for ; Tue, 8 Oct 2024 15:16:51 +0000 (UTC) (envelope-from SRS0=EKhA=RE=klop.ws=ronald-lists@realworks.nl) Authentication-Results: mx1.freebsd.org; none Date: Tue, 8 Oct 2024 17:16:49 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=klop.ws; s=rw2; t=1728400610; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=+Uqj5qiykgxnigN9X1xql0jLYcBMN7HHYQyuMlxVc/U=; b=TMk2cnATI0lTOYPhg78VyWQx44f4d+gPew4hpuENHnU2WJSDXX7oCk52FKvm0ipEJ8GNEO 4Dte32LCJRZ07dlzPhjKSWKGjn2PGKSq+/fUsoW5w06zeX0vPCz3zvV1BjEXuyNBizYjgU KTM3CYM3fZVTdQMky1wWbqGvE/GsR/54DM81ix2UfppOAbUxOfjHFPjOgCXcDhBAH3UyIU Kh8Mqm99LSvXLju1Jol6XlJyAD61Tr0i940EyYSZUxFDEMw6PM3NPxIn07RO4nKvB92VEQ zI3W4AbfFXMfflcG5xGlW+Nv/6x9x07F0REwXzTQbLgdH8WXGadde+MP3Sw57g== From: Ronald Klop To: Piotr Smyrak Cc: ports@freebsd.org Message-ID: <1718369388.9678.1728400609900@localhost> In-Reply-To: <20241008144819.34c3803c@daleth.home> References: <722318548.6969.1728390863107@localhost> <20241008144819.34c3803c@daleth.home> Subject: Re: what to do about "FATAL: PLIST_FILES: files cannot contain %%FOO%% variables. Use make variables and logic instead" List-Id: Porting software to FreeBSD List-Archive: https://lists.freebsd.org/archives/freebsd-ports List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: freebsd-ports@freebsd.org Sender: owner-freebsd-ports@FreeBSD.org MIME-Version: 1.0 Content-Type: multipart/alternative; boundary="----=_Part_9677_535086113.1728400609858" X-Mailer: Realworks (722.66) Importance: Normal X-Priority: 3 (Normal) X-Rspamd-Pre-Result: action=no action; module=replies; Message is reply to one we originated X-Spamd-Result: default: False [-4.00 / 15.00]; REPLY(-4.00)[]; ASN(0.00)[asn:3265, ipnet:194.109.0.0/16, country:NL] X-Rspamd-Queue-Id: 4XNKPH3HKWz4q0p X-Spamd-Bar: ---- ------=_Part_9677_535086113.1728400609858 Content-Type: text/plain; charset=us-ascii; format=flowed Content-Transfer-Encoding: 7bit Van: Piotr Smyrak Datum: dinsdag, 8 oktober 2024 14:48 Aan: ports@freebsd.org Onderwerp: Re: what to do about "FATAL: PLIST_FILES: files cannot contain %%FOO%% variables. Use make variables and logic instead" > > On Tue, 8 Oct 2024 14:34:23 +0200 (CEST) > Ronald Klop wrote: > > > I was looking for a change to devel/jna and after running portlint it > > says: > > > > FATAL: PLIST_FILES: files cannot contain %%FOO%% variables. Use make > > variables and logic instead > > > > The lines in the Makefile this is about are: > > PLIST_FILES= %%JAVAJARDIR%%/jna-platform.jar \ > > %%JAVAJARDIR%%/jna.jar > > > > What would be the proper solution for this? > > See x11-fonts/iansui Makefile for an example. > > HTH, > -- > Piotr Smyrak > > > > Ok, I took a look. Does it mean just replacing %%JAVAJARDIR%% with ${JAVAJARDIR}? Rebuild the package now in poudriere and that seems to work fine. Regards, Ronald. ------=_Part_9677_535086113.1728400609858 Content-Type: text/html; charset=us-ascii Content-Transfer-Encoding: 7bit

Van: Piotr Smyrak <ps.ports@smyrak.com>
Datum: dinsdag, 8 oktober 2024 14:48
Aan: ports@freebsd.org
Onderwerp: Re: what to do about "FATAL: PLIST_FILES: files cannot contain %%FOO%% variables. Use make variables and logic instead"

On Tue, 8 Oct 2024 14:34:23 +0200 (CEST)
Ronald Klop <ronald-lists@klop.ws> wrote:

> I was looking for a change to devel/jna and after running portlint it
> says:
>
> FATAL: PLIST_FILES: files cannot contain %%FOO%% variables.  Use make
> variables and logic instead
>
> The lines in the Makefile this is about are:
> PLIST_FILES=    %%JAVAJARDIR%%/jna-platform.jar \
>                 %%JAVAJARDIR%%/jna.jar
>
> What would be the proper solution for this?

See x11-fonts/iansui Makefile for an example.

HTH,
-- 
 Piotr Smyrak
 


Ok, I took a look. Does it mean just replacing %%JAVAJARDIR%% with ${JAVAJARDIR}?

Rebuild the package now in poudriere and that seems to work fine.

Regards,
Ronald.
  ------=_Part_9677_535086113.1728400609858--