From nobody Sat Oct 05 16:27:55 2024 X-Original-To: freebsd-ports@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4XLW9r6NJVz5YXSG for ; Sat, 05 Oct 2024 16:30:40 +0000 (UTC) (envelope-from rwn@mailo.com) Received: from mailo.com (msg-3.mailo.com [213.182.54.8]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 4XLW9r1Y3bz4JF1 for ; Sat, 5 Oct 2024 16:30:40 +0000 (UTC) (envelope-from rwn@mailo.com) Authentication-Results: mx1.freebsd.org; dkim=pass header.d=mailo.com header.s=mailo header.b=FAumF7zm; spf=pass (mx1.freebsd.org: domain of rwn@mailo.com designates 213.182.54.8 as permitted sender) smtp.mailfrom=rwn@mailo.com; dmarc=pass (policy=quarantine) header.from=mailo.com DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=mailo.com; s=mailo; t=1728145838; bh=AsqXyaj3Fl4ui8Yq/fUXNwvaqM222T0ZfsHFzEDHpCY=; h=X-EA-Auth:From:To:Subject:Date:Message-ID:MIME-Version: Content-Type; b=FAumF7zmVNwmLttfBMtH3PsxRd5YSMlYEqnCNdaE4AeBJtyHDt+kU5ugltYwwOhRQ B5PWbJZqUfsiT/4X47vn5qf2mBXQjBcKjO7fGR962/c9MqpxSmoHEtPoGj2Vq+1XQj 5H88eCTdjQKbT0KRUsicXTU9Mpe5pIPoUwy1RAIw= Received: by b221-1.in.mailobj.net [192.168.90.21] with ESMTP via ip-20.mailobj.net [213.182.54.20] Sat, 5 Oct 2024 18:30:38 +0200 (CEST) X-EA-Auth: KPWXyKdEVOLohRNmefK9MFBMCjTFH1zfs4570jUf0uGXscxsUdy+U0Ar6RwJ6LNsciHY/ov8ciL+8GwaadoQ/VJ+XIfUF9DyAI7HsjbPWz8= User-agent: mu4e 1.8.13; emacs 29.4 From: RwN To: freebsd-ports@FreeBSD.org Subject: Update and merge mail/mu and mail/mu4e Date: Sat, 05 Oct 2024 18:27:55 +0200 Message-ID: <86ploe7btk.fsf@mailo.com> List-Id: Porting software to FreeBSD List-Archive: https://lists.freebsd.org/archives/freebsd-ports List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: freebsd-ports@freebsd.org Sender: owner-freebsd-ports@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; format=flowed X-Spamd-Result: default: False [-3.99 / 15.00]; NEURAL_HAM_MEDIUM(-1.00)[-1.000]; NEURAL_HAM_LONG(-1.00)[-1.000]; NEURAL_HAM_SHORT(-0.99)[-0.986]; DMARC_POLICY_ALLOW(-0.50)[mailo.com,quarantine]; R_DKIM_ALLOW(-0.20)[mailo.com:s=mailo]; R_SPF_ALLOW(-0.20)[+ip4:213.182.54.0/24:c]; MIME_GOOD(-0.10)[text/plain]; RCVD_COUNT_ONE(0.00)[1]; ASN(0.00)[asn:8304, ipnet:213.182.32.0/19, country:FR]; RCPT_COUNT_ONE(0.00)[1]; MIME_TRACE(0.00)[0:+]; ARC_NA(0.00)[]; MLMMJ_DEST(0.00)[freebsd-ports@freebsd.org]; RCVD_TLS_LAST(0.00)[]; FROM_HAS_DN(0.00)[]; MID_RHS_MATCH_FROM(0.00)[]; FROM_EQ_ENVFROM(0.00)[]; TO_MATCH_ENVRCPT_ALL(0.00)[]; TO_DN_NONE(0.00)[]; DKIM_TRACE(0.00)[mailo.com:+] X-Rspamd-Queue-Id: 4XLW9r1Y3bz4JF1 X-Spamd-Bar: --- Hi, I send you an email to ask a review for an update to mail/mu at https://reviews.freebsd.org/D46961 It is my first time to deal with port. Let me introduce few context about this review. - mail/mu is a tool to manage maildir. Its frontend is mail/mu4e for emacs. Actually freebsd ports has both ports. - I contact the ports maintainer, by mail, by reporting a bug at https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=280678 and a previous review at https://reviews.freebsd.org/D45539 without any response. - My review consist in an urgent up-to-date and merging mail/mu and mail/mu4e, the latter becomes a build option (activated by default) because the developpment of both packages are intimately construct as well as in the default building system (meson). - Note, I was unable to use USES += emacs which yields an a ninja error thus I pu in in BUILD_DEPENDS. My questions are: - What do you think of merging both package ? - Can you review the code ? Any comments is welcome! Best, RwN.