Re: Heads-up: Removal of devel/kyua port
- Reply: Kristof Provost : "Re: Heads-up: Removal of devel/kyua port"
- In reply to: Igor Ostapenko : "Re: Heads-up: Removal of devel/kyua port"
- Go to: [ bottom of page ] [ top of archives ] [ this month ]
Date: Thu, 07 Nov 2024 11:55:37 UTC
> On Nov 7, 2024, at 12:44, Igor Ostapenko <igoro@FreeBSD.org> wrote: > > Moin Rahman wrote on 11/6/24 3:01 PM: >>> On Nov 6, 2024, at 13:40, Igor Ostapenko <igoro@FreeBSD.org> wrote: >>> Hi, >>> Kyua has been part of base since 13.0, today it means all supported versions. >>> The tests in /usr/tests usually have parity with Kyua in base, i.e. even if we consider older unsupported systems then new features from the latest port offer limited benefits. Anyway, these cases are not supported. >>> So, in order to avoid double work and user confusion, the devel/kyua port is being considered for removal. >>> The motivation of this notification is to collect comments and suggestions in case if the removal is not a good idea for some reasons. >>> Best regards, >>> igoro >> Hi, >> I am not exactly sure if the one in 13/stable is the updated >> one as I merged the latest code into the head and 14/stable. >> That's why I planned to kill it sometimes during the EOL of >> 13. >> But correct me if I am wrong. > > I have not checked the stable/13, but I know that the recent MFC of Kyua changes in head was targeting stable/14 only, i.e. 13 was not considered intentionally. And I think stable/13 must be fine having its old set of tests which must be executable by the version of Kyua in its base. > > That's great to hear that similar reasoning has been applied before and it's already targeted for removal. The only thing I suggest to do is adding DEPRECATED with a message that the base version must be used instead. We've recently faced a fail case when users run the latest test suite with the older Kyua from ports, that leads to unexpected errors developers should not spend time on. The deprecation notice is not going to save us, but it's at least something. > > Please, check this proposal: https://reviews.freebsd.org/D47473 Based on what you have mentioned above I believe your DEPRECATED message is too soft. :/ And I think we should handle it in a different way and mark it to IGNORE for 14 or later also. Kind regards, Moin