From nobody Thu Jun 27 02:29:45 2024 X-Original-To: freebsd-ports@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4W8jGW0lKpz5NK8b for ; Thu, 27 Jun 2024 02:30:27 +0000 (UTC) (envelope-from junho.choi@gmail.com) Received: from mail-lf1-x129.google.com (mail-lf1-x129.google.com [IPv6:2a00:1450:4864:20::129]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "WR4" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4W8jGV2cd3z4v8g for ; Thu, 27 Jun 2024 02:30:26 +0000 (UTC) (envelope-from junho.choi@gmail.com) Authentication-Results: mx1.freebsd.org; dkim=pass header.d=gmail.com header.s=20230601 header.b=cZKL4mfu; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (mx1.freebsd.org: domain of junho.choi@gmail.com designates 2a00:1450:4864:20::129 as permitted sender) smtp.mailfrom=junho.choi@gmail.com Received: by mail-lf1-x129.google.com with SMTP id 2adb3069b0e04-52ccc40e72eso5406276e87.3 for ; Wed, 26 Jun 2024 19:30:26 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1719455424; x=1720060224; darn=freebsd.org; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=r7HUuYWrP7uSHgQHhQtOVJy0O7QRGvSA0/ssaxRxXTc=; b=cZKL4mfuquqkCYEQ/jGRMQrdLVqBM0REmc9JL8Y3K3oBGPL2s/va2N2+NtnCysE9QG S8TEIOvl+9vHzi/Gtpcx9a60WQhbmkyitgZEwvXlRvcU4Ff0aW1aKN1rhaIf/k2/vL3T JX2Sa9M2qKTi/d1fakVNHRqolDlFCa3Uu4NntZF9cFqdty6Ux/ulEiL3f3reozDW/LlC 2WwSu66Un1VGK78f73UXBPalW5+0ZdRb1P6f60xD/rs9sK3WhUTFnxcxUAzxTRT0i7/z ZoEJieasBHfdtIcUsaWDSvAGcDpLaF8oRYyGSKE9ITRnIDWfa+EJx49Q43B9IJUISpVO KzhQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1719455424; x=1720060224; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=r7HUuYWrP7uSHgQHhQtOVJy0O7QRGvSA0/ssaxRxXTc=; b=h8foI+ElVSyVQNUnbw+5NVMJnqi+Y4GMizgiszNmjLb4tSm5ywmfKZDMcBMsOHb7c1 P4dZLdihDS0WBK8n//UL7pbJbAW/MwVLh6FgIrgdYS0nGQuhfl+4JT3EtcPzB+wd7TO/ /eNc9LBBTWNfS5Rq+NfhWy7+BOFvH0arSogZOFV/+7CW1/jZbIR7BfrsxuKu+/Oy8+x2 QIyH3MSqexoGHHvpnLQIXEgzggbFgs0TSd/fuCz44NcsbpjAtdQkWqopXeB7WfOoyKba 2gV56QobU4iWCKpHr4vXRtIg8i5pG0GFKCIzHibCV2MLNKJf0HF6bbEJ9S3EpI0Hz/u4 Klog== X-Gm-Message-State: AOJu0YxlZkmTRsG6qjeIhp7PT3AM6FDEi/mZ4QC7P4FneKi5Z87uV7DF PU94+ygPqmTf0cW5blps3m+UjKbGgMozxCBHTB2NhoNI06ayMMYj0A8GnOkdBr/FK5/qdnWw4jV f+T0goHUn0+gZOBn0551D1NdTN6/ZwsR8 X-Google-Smtp-Source: AGHT+IGBsYpYksAo0wKAPUxzKUPWfe5KwrfFZW8HUietb/z7DVipSBquK3IDByfUIau4u6hq4ZVLwCTm+C/ZaZ4Zw+M= X-Received: by 2002:a05:6512:70d:b0:52c:a0b8:4dc0 with SMTP id 2adb3069b0e04-52ce18369a3mr8472333e87.28.1719455424174; Wed, 26 Jun 2024 19:30:24 -0700 (PDT) List-Id: Porting software to FreeBSD List-Archive: https://lists.freebsd.org/archives/freebsd-ports List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: freebsd-ports@freebsd.org Sender: owner-freebsd-ports@FreeBSD.org MIME-Version: 1.0 References: In-Reply-To: From: Junho Choi Date: Thu, 27 Jun 2024 11:29:45 +0900 Message-ID: Subject: Re: quiche dependency issue in FreeBSD To: =?UTF-8?Q?Yann_Kerherv=C3=A9?= Cc: freebsd-ports@freebsd.org Content-Type: multipart/alternative; boundary="000000000000c3e302061bd5e909" X-Spamd-Bar: --- X-Spamd-Result: default: False [-4.00 / 15.00]; NEURAL_HAM_MEDIUM(-1.00)[-1.000]; NEURAL_HAM_SHORT(-1.00)[-1.000]; NEURAL_HAM_LONG(-1.00)[-0.999]; DMARC_POLICY_ALLOW(-0.50)[gmail.com,none]; R_SPF_ALLOW(-0.20)[+ip6:2a00:1450:4000::/36:c]; R_DKIM_ALLOW(-0.20)[gmail.com:s=20230601]; MIME_GOOD(-0.10)[multipart/alternative,text/plain]; RCPT_COUNT_TWO(0.00)[2]; DWL_DNSWL_NONE(0.00)[gmail.com:dkim]; RCVD_TLS_LAST(0.00)[]; FREEMAIL_FROM(0.00)[gmail.com]; TO_DN_SOME(0.00)[]; TAGGED_FROM(0.00)[]; FREEMAIL_TO(0.00)[gmail.com]; MIME_TRACE(0.00)[0:+,1:+,2:~]; ARC_NA(0.00)[]; FROM_HAS_DN(0.00)[]; MISSING_XM_UA(0.00)[]; FREEMAIL_ENVFROM(0.00)[gmail.com]; PREVIOUSLY_DELIVERED(0.00)[freebsd-ports@freebsd.org]; TO_MATCH_ENVRCPT_SOME(0.00)[]; FROM_EQ_ENVFROM(0.00)[]; DKIM_TRACE(0.00)[gmail.com:+]; MID_RHS_MATCH_FROMTLD(0.00)[]; TAGGED_RCPT(0.00)[]; MLMMJ_DEST(0.00)[freebsd-ports@freebsd.org]; RCVD_COUNT_ONE(0.00)[1]; ASN(0.00)[asn:15169, ipnet:2a00:1450::/32, country:US]; RCVD_IN_DNSWL_NONE(0.00)[2a00:1450:4864:20::129:from] X-Rspamd-Queue-Id: 4W8jGV2cd3z4v8g --000000000000c3e302061bd5e909 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable quiche 0.22.0 with the soname fix released: https://github.com/cloudflare/quiche/releases/tag/0.22.0 On Tue, Apr 30, 2024 at 9:23=E2=80=AFPM Junho Choi w= rote: > I was looking into pkg source and found a relevant line: > > > https://github.com/freebsd/pkg/blob/b0a68a933f42aec97c8f37543bcac41149c28= e2e/libpkg/pkg_elf.c#L402-L410 > > It seems to look for soname in the shared libs to be added to "shlibs > provided" section, but currently > quiche has no soname in the .so file: > https://github.com/cloudflare/quiche/issues/598 > > I made a PR to fix this: > https://github.com/cloudflare/quiche/pull/1769 > > After that, I made a fix on the port and now it looks ok: > > Shared Libs provided: > libquiche.so.0 > > Let's see how it is merged. I'll update the quiche port when it's ready. > > On Tue, Apr 30, 2024 at 12:17=E2=80=AFPM Junho Choi wrote: > > > > (Cross posting to ports@) > > > > Yann - yes I can reproduce it but have no idea why. > > > > It seems quiche doesn't have a "Shared Lib provided" section like > > other libs. (see below) > > > > Other than USE_LDCONFIG, what affects it? Any advice from committers? > > > > % pkg info quiche > > quiche-0.20.1 > > Name : quiche > > Version : 0.20.1 > > Installed on : Tue Apr 30 03:14:32 2024 UTC > > Origin : net/quiche > > Architecture : FreeBSD:14:amd64 > > Prefix : /usr/local > > Categories : net > > Licenses : BSD2CLAUSE > > Maintainer : junho.choi@gmail.com > > WWW : https://crates.io/crates/quiche > > Comment : Savoury implementation of the QUIC transport protocol > > and HTTP/3 > > Options : > > DOCS : on > > QLOG : on > > Annotations : > > FreeBSD_version: 1400097 > > build_timestamp: 2024-04-04T20:02:03+0000 > > built_by : poudriere-git-3.4.1-1-g1e9f97d6 > > port_checkout_unclean: no > > port_git_hash : 0e1153d3a5 > > ports_top_checkout_unclean: no > > ports_top_git_hash: f5d16d08a6 > > repo_type : binary > > repository : FreeBSD > > Flat size : 48.2MiB > > > > > > Other example (libnghttp2 has "Shared Lib Provided" section) > > > > % pkg info libnghttp2 > > libnghttp2-1.61.0 > > Name : libnghttp2 > > Version : 1.61.0 > > Installed on : Sun Apr 21 12:06:36 2024 UTC > > Origin : www/libnghttp2 > > Architecture : FreeBSD:14:amd64 > > Prefix : /usr/local > > Categories : www net > > Licenses : MIT > > Maintainer : sunpoet@FreeBSD.org > > WWW : https://nghttp2.org/ > > Comment : HTTP/2.0 C Library > > Shared Libs provided: > > libnghttp2.so.14 > > Annotations : > > FreeBSD_version: 1400097 > > build_timestamp: 2024-04-11T01:12:38+0000 > > built_by : poudriere-git-3.4.1-1-g1e9f97d6 > > cpe : cpe:2.3:a:nghttp2:nghttp2:1.61.0:::::freebsd14:x64 > > port_checkout_unclean: no > > port_git_hash : 2b3fb39407 > > ports_top_checkout_unclean: no > > ports_top_git_hash: 2910ff97e7 > > repo_type : binary > > repository : FreeBSD > > Flat size : 801KiB > > > > On Fri, Apr 26, 2024 at 11:32=E2=80=AFAM Yann Kerherv=C3=A9 > wrote: > > > > > > Hello, > > > > > > I have an issue with `pkg check` reporting a dependency missing: > > > > > > root@dev:~ # pkg check -d -a > > > Checking all packages: 100% > > > dnsdist is missing a required shared library: libquiche.so > > > > > > (in FreeBSD 13.3 and 14.0) > > > > > > This is bogus: > > > root@dev:~ # ldd /usr/local/sbin/dnsdist | grep quiche > > > libquiche.so =3D> /usr/local/lib/libquiche.so (0x3af8e91e0000) > > > > > > It seems like the package build missed that dependency and doesn't > report as a shared lib provided by quiche? > > > > > > # pkg info -b quiche > > > quiche-0.20.1: > > > > > > Should there be a shared lib provided there: > > > > > > quiche-0.20.1: > > > libquiche.so > > > > > > I thought that the USE_LDCONFIG=3D yes in the Makefile was taking car= e > of that automatically. And this is correctly set in the Makefile... > > > > > > Thanks! > > > > > > Yann > > > > > > > > > > > > > > > -- > > Junho Choi | https://saturnsoft.net > > > > -- > Junho Choi | https://saturnsoft.net > --=20 Junho Choi | https://saturnsoft.net --000000000000c3e302061bd5e909 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
quiche 0.22.0 with the soname fix released: https://github.com/c= loudflare/quiche/releases/tag/0.22.0

On Tue, Apr 30, 2024 at 9:23=E2=80= =AFPM Junho Choi <junho.choi@gma= il.com> wrote:
I was looking into pkg source and found a relevant line:

https://github.com/freebsd/pkg/blob/b0a68a933f42aec97c8f37543bcac41149c2= 8e2e/libpkg/pkg_elf.c#L402-L410

It seems to look for soname in the shared libs to be added to "shlibs<= br> provided" section, but currently
quiche has no soname in the .so file:
https://github.com/cloudflare/quiche/issues/598
I made a PR to fix this:
https://github.com/cloudflare/quiche/pull/1769

After that, I made a fix on the port and now it looks ok:

Shared Libs provided:
=C2=A0 =C2=A0 libquiche.so.0

Let's see how it is merged. I'll update the quiche port when it'= ;s ready.

On Tue, Apr 30, 2024 at 12:17=E2=80=AFPM Junho Choi <junho.choi@gmail.com> wrote:<= br> >
> (Cross posting to ports@)
>
> Yann - yes I can reproduce it but have no idea why.
>
> It seems quiche doesn't have a "Shared Lib provided" sec= tion like
> other libs. (see below)
>
> Other than USE_LDCONFIG, what affects it? Any advice from committers?<= br> >
> % pkg info quiche
> quiche-0.20.1
> Name=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0: quiche
> Version=C2=A0 =C2=A0 =C2=A0 =C2=A0 : 0.20.1
> Installed on=C2=A0 =C2=A0: Tue Apr 30 03:14:32 2024 UTC
> Origin=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0: net/quiche
> Architecture=C2=A0 =C2=A0: FreeBSD:14:amd64
> Prefix=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0: /usr/local
> Categories=C2=A0 =C2=A0 =C2=A0: net
> Licenses=C2=A0 =C2=A0 =C2=A0 =C2=A0: BSD2CLAUSE
> Maintainer=C2=A0 =C2=A0 =C2=A0: junho.choi@gmail.com
> WWW=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 : https://crates.io= /crates/quiche
> Comment=C2=A0 =C2=A0 =C2=A0 =C2=A0 : Savoury implementation of the QUI= C transport protocol
> and HTTP/3
> Options=C2=A0 =C2=A0 =C2=A0 =C2=A0 :
>=C2=A0 =C2=A0 =C2=A0DOCS=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0: on >=C2=A0 =C2=A0 =C2=A0QLOG=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0: on > Annotations=C2=A0 =C2=A0 :
>=C2=A0 =C2=A0 =C2=A0FreeBSD_version: 1400097
>=C2=A0 =C2=A0 =C2=A0build_timestamp: 2024-04-04T20:02:03+0000
>=C2=A0 =C2=A0 =C2=A0built_by=C2=A0 =C2=A0 =C2=A0 =C2=A0: poudriere-git-= 3.4.1-1-g1e9f97d6
>=C2=A0 =C2=A0 =C2=A0port_checkout_unclean: no
>=C2=A0 =C2=A0 =C2=A0port_git_hash=C2=A0 : 0e1153d3a5
>=C2=A0 =C2=A0 =C2=A0ports_top_checkout_unclean: no
>=C2=A0 =C2=A0 =C2=A0ports_top_git_hash: f5d16d08a6
>=C2=A0 =C2=A0 =C2=A0repo_type=C2=A0 =C2=A0 =C2=A0 : binary
>=C2=A0 =C2=A0 =C2=A0repository=C2=A0 =C2=A0 =C2=A0: FreeBSD
> Flat size=C2=A0 =C2=A0 =C2=A0 : 48.2MiB
>
>
> Other example (libnghttp2 has "Shared Lib Provided" section)=
>
> % pkg info libnghttp2
> libnghttp2-1.61.0
> Name=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0: libnghttp2
> Version=C2=A0 =C2=A0 =C2=A0 =C2=A0 : 1.61.0
> Installed on=C2=A0 =C2=A0: Sun Apr 21 12:06:36 2024 UTC
> Origin=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0: www/libnghttp2
> Architecture=C2=A0 =C2=A0: FreeBSD:14:amd64
> Prefix=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0: /usr/local
> Categories=C2=A0 =C2=A0 =C2=A0: www net
> Licenses=C2=A0 =C2=A0 =C2=A0 =C2=A0: MIT
> Maintainer=C2=A0 =C2=A0 =C2=A0: sunpoet@FreeBSD.org
> WWW=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 : https://nghttp2.org/
> Comment=C2=A0 =C2=A0 =C2=A0 =C2=A0 : HTTP/2.0 C Library
> Shared Libs provided:
>=C2=A0 =C2=A0 =C2=A0libnghttp2.so.14
> Annotations=C2=A0 =C2=A0 :
>=C2=A0 =C2=A0 =C2=A0FreeBSD_version: 1400097
>=C2=A0 =C2=A0 =C2=A0build_timestamp: 2024-04-11T01:12:38+0000
>=C2=A0 =C2=A0 =C2=A0built_by=C2=A0 =C2=A0 =C2=A0 =C2=A0: poudriere-git-= 3.4.1-1-g1e9f97d6
>=C2=A0 =C2=A0 =C2=A0cpe=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 : cpe:= 2.3:a:nghttp2:nghttp2:1.61.0:::::freebsd14:x64
>=C2=A0 =C2=A0 =C2=A0port_checkout_unclean: no
>=C2=A0 =C2=A0 =C2=A0port_git_hash=C2=A0 : 2b3fb39407
>=C2=A0 =C2=A0 =C2=A0ports_top_checkout_unclean: no
>=C2=A0 =C2=A0 =C2=A0ports_top_git_hash: 2910ff97e7
>=C2=A0 =C2=A0 =C2=A0repo_type=C2=A0 =C2=A0 =C2=A0 : binary
>=C2=A0 =C2=A0 =C2=A0repository=C2=A0 =C2=A0 =C2=A0: FreeBSD
> Flat size=C2=A0 =C2=A0 =C2=A0 : 801KiB
>
> On Fri, Apr 26, 2024 at 11:32=E2=80=AFAM Yann Kerherv=C3=A9 <yann.kerherve@gmail.= com> wrote:
> >
> > Hello,
> >
> > I have an issue with `pkg check` reporting a dependency missing:<= br> > >
> > root@dev:~ # pkg check -d -a
> > Checking all packages: 100%
> > dnsdist is missing a required shared library: libquiche.so
> >
> > (in FreeBSD 13.3 and 14.0)
> >
> > This is bogus:
> > root@dev:~ # ldd /usr/local/sbin/dnsdist | grep quiche
> > libquiche.so =3D> /usr/local/lib/libquiche.so (0x3af8e91e0000)=
> >
> > It seems like the package build missed that dependency and doesn&= #39;t report as a shared lib provided by quiche?
> >
> > # pkg info -b quiche
> > quiche-0.20.1:
> >
> > Should there be a shared lib provided there:
> >
> > quiche-0.20.1:
> >=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0libquiche.so
> >
> > I thought that the USE_LDCONFIG=3D yes in the Makefile was taking= care of that automatically. And this is correctly set in the Makefile... > >
> > Thanks!
> >
> > Yann
> >
> >
> >
>
>
> --
> Junho Choi <junho dot choi at gmail.com> | https://saturnsoft.net


--
Junho Choi <junho dot choi at gmail.com> | https://saturnsoft.net


--
Junho Choi <junho dot choi at gmail.com> | https://saturnsoft.net
--000000000000c3e302061bd5e909--