From nobody Sun Jul 14 12:49:23 2024 X-Original-To: freebsd-ports@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4WMQCf4QMwz5QXfk for ; Sun, 14 Jul 2024 12:50:06 +0000 (UTC) (envelope-from junho.choi@gmail.com) Received: from mail-lj1-x22e.google.com (mail-lj1-x22e.google.com [IPv6:2a00:1450:4864:20::22e]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "WR4" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4WMQCc4YRxz4rYj for ; Sun, 14 Jul 2024 12:50:04 +0000 (UTC) (envelope-from junho.choi@gmail.com) Authentication-Results: mx1.freebsd.org; dkim=pass header.d=gmail.com header.s=20230601 header.b="MhmP6/M4"; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (mx1.freebsd.org: domain of junho.choi@gmail.com designates 2a00:1450:4864:20::22e as permitted sender) smtp.mailfrom=junho.choi@gmail.com Received: by mail-lj1-x22e.google.com with SMTP id 38308e7fff4ca-2ee77db6f97so54963341fa.2 for ; Sun, 14 Jul 2024 05:50:04 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1720961401; x=1721566201; darn=freebsd.org; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=eTJuQojF2scEX7c1IXxBhxYjF+62dIt98zMn/3kVSm0=; b=MhmP6/M4SliMDXz4omoBwlWaXYv7PqGrlUBsDQ38jrv/Ot5GgUS0G0DlC1OQADa3h3 W9+Z5Euiti8yH5yZvgRSMwNy3rhOSZUqWn6kAzqVbDke+zsNB6PlHK4muZPtVu9V6XLN IfqFGnrJFN2RioblvyYdlbmiWEPlWe4vhAo6G4mRWiqFGMlF/hyClyxvnIHURQwGEmhL FO7aXJr1QZlGJbqT4IRNx0YlbZUF9DP+gdJmWFnzkbvoGEm6Tk8D3Jynvvn39CDfOBAW S4mxuJZk7gAVq7JMDiXSZ8FMiiHPZdzaqwfRC1ulezGruHfezod44UXkeov7OFurfva2 jsbg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1720961401; x=1721566201; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=eTJuQojF2scEX7c1IXxBhxYjF+62dIt98zMn/3kVSm0=; b=XbOmT4CIPWBNZo1FCxRHIboKIABm8DJQoxuztAhjGULawN2B3S49+sYOqbQ1dpDeXD RPwMGVqYVTUYJGlk85HLMjZE09jE6vGLxuCMBkQOykjLQ47g062NJhpLBGvAv6hgX+cn MoB5Jcd0Hm0QqIJBIKGRUsSlgVOAkQG+C5iNoi5o1ZBL1Ef8Nrlxq8DW/7layQsv8zz7 XC56IwXgW0m7B0Z9x1Jle/cYs6NQ9accvC/JBCK7zWVl7b8FMwa4IpLlC3wVg/Zgg7my uBNqF4MrmTx0RubveDplxok+tLl57QLqdK593liV2WAeiAdGsU5toOsgGczl2olKr6Wm o8/A== X-Gm-Message-State: AOJu0Ywwz4xh1XpRmRC/TqVM2mh+e/x3x9uAwQ0E2bilx6OwAK97Etuz dTkHTXWWGciAlRyptI9wq3de6MweF6rPvg6fahK256sR3w+az8lAMeLsFkrgnjT4RdolsnN2pDZ B5EZ901xCoUHl3qicFhPJewmsLbE= X-Google-Smtp-Source: AGHT+IFu8nqfSJuqsRDGIbVh4s9EiNSZ/+pINqUbPmUmgisv+/P6gAGgLtlSAk6RlcGO0kx1WYlBX0HzKc2HyNjCUmc= X-Received: by 2002:a2e:9b4c:0:b0:2ee:8720:b4b8 with SMTP id 38308e7fff4ca-2eeb316b817mr131531031fa.39.1720961401001; Sun, 14 Jul 2024 05:50:01 -0700 (PDT) List-Id: Porting software to FreeBSD List-Archive: https://lists.freebsd.org/archives/freebsd-ports List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: freebsd-ports@freebsd.org Sender: owner-freebsd-ports@FreeBSD.org MIME-Version: 1.0 References: In-Reply-To: From: Junho Choi Date: Sun, 14 Jul 2024 21:49:23 +0900 Message-ID: Subject: Re: quiche dependency issue in FreeBSD To: =?UTF-8?Q?Yann_Kerherv=C3=A9?= Cc: freebsd-ports@freebsd.org Content-Type: multipart/alternative; boundary="000000000000faa0b3061d348c1a" X-Spamd-Bar: --- X-Spamd-Result: default: False [-4.00 / 15.00]; NEURAL_HAM_MEDIUM(-1.00)[-1.000]; NEURAL_HAM_LONG(-1.00)[-0.999]; NEURAL_HAM_SHORT(-1.00)[-0.998]; DMARC_POLICY_ALLOW(-0.50)[gmail.com,none]; R_SPF_ALLOW(-0.20)[+ip6:2a00:1450:4000::/36]; R_DKIM_ALLOW(-0.20)[gmail.com:s=20230601]; MIME_GOOD(-0.10)[multipart/alternative,text/plain]; RCPT_COUNT_TWO(0.00)[2]; FREEMAIL_ENVFROM(0.00)[gmail.com]; RCVD_TLS_LAST(0.00)[]; FREEMAIL_FROM(0.00)[gmail.com]; TO_DN_SOME(0.00)[]; TAGGED_FROM(0.00)[]; FREEMAIL_TO(0.00)[gmail.com]; MIME_TRACE(0.00)[0:+,1:+,2:~]; ARC_NA(0.00)[]; FROM_HAS_DN(0.00)[]; MISSING_XM_UA(0.00)[]; RCVD_IN_DNSWL_NONE(0.00)[2a00:1450:4864:20::22e:from]; PREVIOUSLY_DELIVERED(0.00)[freebsd-ports@freebsd.org]; TO_MATCH_ENVRCPT_SOME(0.00)[]; FROM_EQ_ENVFROM(0.00)[]; DKIM_TRACE(0.00)[gmail.com:+]; MID_RHS_MATCH_FROMTLD(0.00)[]; TAGGED_RCPT(0.00)[]; MLMMJ_DEST(0.00)[freebsd-ports@freebsd.org]; RCVD_COUNT_ONE(0.00)[1]; ASN(0.00)[asn:15169, ipnet:2a00:1450::/32, country:US]; DWL_DNSWL_NONE(0.00)[gmail.com:dkim] X-Rspamd-Queue-Id: 4WMQCc4YRxz4rYj --000000000000faa0b3061d348c1a Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Yann, I filed a patch to update quiche to 0.22.0, with a correct .so installation= . With this port, I don't get "dnsdist is missing a required shared library: libquiche.so" any more. https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D280274 It'd be great if any committer will pick it up! Best, On Thu, Jun 27, 2024 at 11:29=E2=80=AFAM Junho Choi = wrote: > quiche 0.22.0 with the soname fix released: > https://github.com/cloudflare/quiche/releases/tag/0.22.0 > > On Tue, Apr 30, 2024 at 9:23=E2=80=AFPM Junho Choi = wrote: > >> I was looking into pkg source and found a relevant line: >> >> >> https://github.com/freebsd/pkg/blob/b0a68a933f42aec97c8f37543bcac41149c2= 8e2e/libpkg/pkg_elf.c#L402-L410 >> >> It seems to look for soname in the shared libs to be added to "shlibs >> provided" section, but currently >> quiche has no soname in the .so file: >> https://github.com/cloudflare/quiche/issues/598 >> >> I made a PR to fix this: >> https://github.com/cloudflare/quiche/pull/1769 >> >> After that, I made a fix on the port and now it looks ok: >> >> Shared Libs provided: >> libquiche.so.0 >> >> Let's see how it is merged. I'll update the quiche port when it's ready. >> >> On Tue, Apr 30, 2024 at 12:17=E2=80=AFPM Junho Choi wrote: >> > >> > (Cross posting to ports@) >> > >> > Yann - yes I can reproduce it but have no idea why. >> > >> > It seems quiche doesn't have a "Shared Lib provided" section like >> > other libs. (see below) >> > >> > Other than USE_LDCONFIG, what affects it? Any advice from committers? >> > >> > % pkg info quiche >> > quiche-0.20.1 >> > Name : quiche >> > Version : 0.20.1 >> > Installed on : Tue Apr 30 03:14:32 2024 UTC >> > Origin : net/quiche >> > Architecture : FreeBSD:14:amd64 >> > Prefix : /usr/local >> > Categories : net >> > Licenses : BSD2CLAUSE >> > Maintainer : junho.choi@gmail.com >> > WWW : https://crates.io/crates/quiche >> > Comment : Savoury implementation of the QUIC transport protocol >> > and HTTP/3 >> > Options : >> > DOCS : on >> > QLOG : on >> > Annotations : >> > FreeBSD_version: 1400097 >> > build_timestamp: 2024-04-04T20:02:03+0000 >> > built_by : poudriere-git-3.4.1-1-g1e9f97d6 >> > port_checkout_unclean: no >> > port_git_hash : 0e1153d3a5 >> > ports_top_checkout_unclean: no >> > ports_top_git_hash: f5d16d08a6 >> > repo_type : binary >> > repository : FreeBSD >> > Flat size : 48.2MiB >> > >> > >> > Other example (libnghttp2 has "Shared Lib Provided" section) >> > >> > % pkg info libnghttp2 >> > libnghttp2-1.61.0 >> > Name : libnghttp2 >> > Version : 1.61.0 >> > Installed on : Sun Apr 21 12:06:36 2024 UTC >> > Origin : www/libnghttp2 >> > Architecture : FreeBSD:14:amd64 >> > Prefix : /usr/local >> > Categories : www net >> > Licenses : MIT >> > Maintainer : sunpoet@FreeBSD.org >> > WWW : https://nghttp2.org/ >> > Comment : HTTP/2.0 C Library >> > Shared Libs provided: >> > libnghttp2.so.14 >> > Annotations : >> > FreeBSD_version: 1400097 >> > build_timestamp: 2024-04-11T01:12:38+0000 >> > built_by : poudriere-git-3.4.1-1-g1e9f97d6 >> > cpe : cpe:2.3:a:nghttp2:nghttp2:1.61.0:::::freebsd14:x6= 4 >> > port_checkout_unclean: no >> > port_git_hash : 2b3fb39407 >> > ports_top_checkout_unclean: no >> > ports_top_git_hash: 2910ff97e7 >> > repo_type : binary >> > repository : FreeBSD >> > Flat size : 801KiB >> > >> > On Fri, Apr 26, 2024 at 11:32=E2=80=AFAM Yann Kerherv=C3=A9 >> wrote: >> > > >> > > Hello, >> > > >> > > I have an issue with `pkg check` reporting a dependency missing: >> > > >> > > root@dev:~ # pkg check -d -a >> > > Checking all packages: 100% >> > > dnsdist is missing a required shared library: libquiche.so >> > > >> > > (in FreeBSD 13.3 and 14.0) >> > > >> > > This is bogus: >> > > root@dev:~ # ldd /usr/local/sbin/dnsdist | grep quiche >> > > libquiche.so =3D> /usr/local/lib/libquiche.so (0x3af8e91e0000) >> > > >> > > It seems like the package build missed that dependency and doesn't >> report as a shared lib provided by quiche? >> > > >> > > # pkg info -b quiche >> > > quiche-0.20.1: >> > > >> > > Should there be a shared lib provided there: >> > > >> > > quiche-0.20.1: >> > > libquiche.so >> > > >> > > I thought that the USE_LDCONFIG=3D yes in the Makefile was taking ca= re >> of that automatically. And this is correctly set in the Makefile... >> > > >> > > Thanks! >> > > >> > > Yann >> > > >> > > >> > > >> > >> > >> > -- >> > Junho Choi | https://saturnsoft.net >> >> >> >> -- >> Junho Choi | https://saturnsoft.net >> > > > -- > Junho Choi | https://saturnsoft.net > --=20 Junho Choi | https://saturnsoft.net --000000000000faa0b3061d348c1a Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Yann,

I filed a patch to= update quiche to 0.22.0, with a correct .so installation.

With this port, I don't get "dns= dist is missing a required shared library: libquiche.so" any more.


It'd be grea= t if any committer will pick it up!

Best,


On Thu, Jun 27, 2024 at 11:29=E2=80=AFAM Junho Choi <junho.choi@gmail.com> wrote:
q= uiche 0.22.0 with the soname fix released: https://github.com/c= loudflare/quiche/releases/tag/0.22.0

On Tue, Apr 30, 2024 at 9:23=E2=80= =AFPM Junho Choi <junho.choi@gmail.com> wrote:
I was looking into pkg source and found a relevant = line:

https://github.com/freebsd/pkg/blob/b0a68a933f42aec97c8f37543bcac41149c2= 8e2e/libpkg/pkg_elf.c#L402-L410

It seems to look for soname in the shared libs to be added to "shlibs<= br> provided" section, but currently
quiche has no soname in the .so file:
https://github.com/cloudflare/quiche/issues/598
I made a PR to fix this:
https://github.com/cloudflare/quiche/pull/1769

After that, I made a fix on the port and now it looks ok:

Shared Libs provided:
=C2=A0 =C2=A0 libquiche.so.0

Let's see how it is merged. I'll update the quiche port when it'= ;s ready.

On Tue, Apr 30, 2024 at 12:17=E2=80=AFPM Junho Choi <junho.choi@gmail.com> wrote:<= br> >
> (Cross posting to ports@)
>
> Yann - yes I can reproduce it but have no idea why.
>
> It seems quiche doesn't have a "Shared Lib provided" sec= tion like
> other libs. (see below)
>
> Other than USE_LDCONFIG, what affects it? Any advice from committers?<= br> >
> % pkg info quiche
> quiche-0.20.1
> Name=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0: quiche
> Version=C2=A0 =C2=A0 =C2=A0 =C2=A0 : 0.20.1
> Installed on=C2=A0 =C2=A0: Tue Apr 30 03:14:32 2024 UTC
> Origin=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0: net/quiche
> Architecture=C2=A0 =C2=A0: FreeBSD:14:amd64
> Prefix=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0: /usr/local
> Categories=C2=A0 =C2=A0 =C2=A0: net
> Licenses=C2=A0 =C2=A0 =C2=A0 =C2=A0: BSD2CLAUSE
> Maintainer=C2=A0 =C2=A0 =C2=A0: junho.choi@gmail.com
> WWW=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 : https://crates.io= /crates/quiche
> Comment=C2=A0 =C2=A0 =C2=A0 =C2=A0 : Savoury implementation of the QUI= C transport protocol
> and HTTP/3
> Options=C2=A0 =C2=A0 =C2=A0 =C2=A0 :
>=C2=A0 =C2=A0 =C2=A0DOCS=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0: on >=C2=A0 =C2=A0 =C2=A0QLOG=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0: on > Annotations=C2=A0 =C2=A0 :
>=C2=A0 =C2=A0 =C2=A0FreeBSD_version: 1400097
>=C2=A0 =C2=A0 =C2=A0build_timestamp: 2024-04-04T20:02:03+0000
>=C2=A0 =C2=A0 =C2=A0built_by=C2=A0 =C2=A0 =C2=A0 =C2=A0: poudriere-git-= 3.4.1-1-g1e9f97d6
>=C2=A0 =C2=A0 =C2=A0port_checkout_unclean: no
>=C2=A0 =C2=A0 =C2=A0port_git_hash=C2=A0 : 0e1153d3a5
>=C2=A0 =C2=A0 =C2=A0ports_top_checkout_unclean: no
>=C2=A0 =C2=A0 =C2=A0ports_top_git_hash: f5d16d08a6
>=C2=A0 =C2=A0 =C2=A0repo_type=C2=A0 =C2=A0 =C2=A0 : binary
>=C2=A0 =C2=A0 =C2=A0repository=C2=A0 =C2=A0 =C2=A0: FreeBSD
> Flat size=C2=A0 =C2=A0 =C2=A0 : 48.2MiB
>
>
> Other example (libnghttp2 has "Shared Lib Provided" section)=
>
> % pkg info libnghttp2
> libnghttp2-1.61.0
> Name=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0: libnghttp2
> Version=C2=A0 =C2=A0 =C2=A0 =C2=A0 : 1.61.0
> Installed on=C2=A0 =C2=A0: Sun Apr 21 12:06:36 2024 UTC
> Origin=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0: www/libnghttp2
> Architecture=C2=A0 =C2=A0: FreeBSD:14:amd64
> Prefix=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0: /usr/local
> Categories=C2=A0 =C2=A0 =C2=A0: www net
> Licenses=C2=A0 =C2=A0 =C2=A0 =C2=A0: MIT
> Maintainer=C2=A0 =C2=A0 =C2=A0: sunpoet@FreeBSD.org
> WWW=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 : https://nghttp2.org/
> Comment=C2=A0 =C2=A0 =C2=A0 =C2=A0 : HTTP/2.0 C Library
> Shared Libs provided:
>=C2=A0 =C2=A0 =C2=A0libnghttp2.so.14
> Annotations=C2=A0 =C2=A0 :
>=C2=A0 =C2=A0 =C2=A0FreeBSD_version: 1400097
>=C2=A0 =C2=A0 =C2=A0build_timestamp: 2024-04-11T01:12:38+0000
>=C2=A0 =C2=A0 =C2=A0built_by=C2=A0 =C2=A0 =C2=A0 =C2=A0: poudriere-git-= 3.4.1-1-g1e9f97d6
>=C2=A0 =C2=A0 =C2=A0cpe=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 : cpe:= 2.3:a:nghttp2:nghttp2:1.61.0:::::freebsd14:x64
>=C2=A0 =C2=A0 =C2=A0port_checkout_unclean: no
>=C2=A0 =C2=A0 =C2=A0port_git_hash=C2=A0 : 2b3fb39407
>=C2=A0 =C2=A0 =C2=A0ports_top_checkout_unclean: no
>=C2=A0 =C2=A0 =C2=A0ports_top_git_hash: 2910ff97e7
>=C2=A0 =C2=A0 =C2=A0repo_type=C2=A0 =C2=A0 =C2=A0 : binary
>=C2=A0 =C2=A0 =C2=A0repository=C2=A0 =C2=A0 =C2=A0: FreeBSD
> Flat size=C2=A0 =C2=A0 =C2=A0 : 801KiB
>
> On Fri, Apr 26, 2024 at 11:32=E2=80=AFAM Yann Kerherv=C3=A9 <yann.kerherve@gmail.= com> wrote:
> >
> > Hello,
> >
> > I have an issue with `pkg check` reporting a dependency missing:<= br> > >
> > root@dev:~ # pkg check -d -a
> > Checking all packages: 100%
> > dnsdist is missing a required shared library: libquiche.so
> >
> > (in FreeBSD 13.3 and 14.0)
> >
> > This is bogus:
> > root@dev:~ # ldd /usr/local/sbin/dnsdist | grep quiche
> > libquiche.so =3D> /usr/local/lib/libquiche.so (0x3af8e91e0000)=
> >
> > It seems like the package build missed that dependency and doesn&= #39;t report as a shared lib provided by quiche?
> >
> > # pkg info -b quiche
> > quiche-0.20.1:
> >
> > Should there be a shared lib provided there:
> >
> > quiche-0.20.1:
> >=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0libquiche.so
> >
> > I thought that the USE_LDCONFIG=3D yes in the Makefile was taking= care of that automatically. And this is correctly set in the Makefile... > >
> > Thanks!
> >
> > Yann
> >
> >
> >
>
>
> --
> Junho Choi <junho dot choi at gmail.com> | https://saturnsoft.net


--
Junho Choi <junho dot choi at gmail.com> | https://saturnsoft.net


--
Junho Choi <junho dot choi at gmail.com> | https://saturnsoft.net


--
Junho Choi <junho dot choi at gmail.com> | https://saturnsoft.net
--000000000000faa0b3061d348c1a--