From nobody Mon Jan 29 12:48:50 2024 X-Original-To: freebsd-ports@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4TNp5N59X7z58fb6 for ; Mon, 29 Jan 2024 12:48:56 +0000 (UTC) (envelope-from junchoon@dec.sakura.ne.jp) Received: from www121.sakura.ne.jp (www121.sakura.ne.jp [153.125.133.21]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 4TNp5M6DSSz4B1X; Mon, 29 Jan 2024 12:48:55 +0000 (UTC) (envelope-from junchoon@dec.sakura.ne.jp) Authentication-Results: mx1.freebsd.org; none Received: from kalamity.joker.local (123-1-91-49.area1b.commufa.jp [123.1.91.49]) (authenticated bits=0) by www121.sakura.ne.jp (8.17.1/8.17.1/[SAKURA-WEB]/20201212) with ESMTPA id 40TCmo8O038873; Mon, 29 Jan 2024 21:48:51 +0900 (JST) (envelope-from junchoon@dec.sakura.ne.jp) Date: Mon, 29 Jan 2024 21:48:50 +0900 From: Tomoaki AOKI To: Nuno Teixeira Cc: FreeBSD Mailing List Subject: Re: LDFLAGS= -pthread situation Message-Id: <20240129214850.2e0a615875eacc6fae995b3d@dec.sakura.ne.jp> In-Reply-To: References: <20240129201052.3520bea9850f96c9180b3bbc@dec.sakura.ne.jp> Organization: Junchoon corps X-Mailer: Sylpheed 3.7.0 (GTK+ 2.24.33; amd64-portbld-freebsd14.0) List-Id: Porting software to FreeBSD List-Archive: https://lists.freebsd.org/archives/freebsd-ports List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-freebsd-ports@freebsd.org X-BeenThere: freebsd-ports@freebsd.org Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Rspamd-Queue-Id: 4TNp5M6DSSz4B1X X-Spamd-Bar: ---- X-Rspamd-Pre-Result: action=no action; module=replies; Message is reply to one we originated X-Spamd-Result: default: False [-4.00 / 15.00]; REPLY(-4.00)[]; ASN(0.00)[asn:7684, ipnet:153.125.128.0/18, country:JP] On Mon, 29 Jan 2024 12:28:01 +0000 Nuno Teixeira wrote: > Interesting that it using same fix of around 300 ports for a quick grep of > LDFLAGS. > > Maybe I will take a look of what someone said upstream: > "There is a case statement on $host_os near the beginning of configure.ac, > with freebsd as a possible choice. > Could you test whether it would be enough to add there a SYSLIBS="-lpthread" > like we do for Solaris or Darwin ?" > > It seems interesting dealing this upstream like they do for other OSes. > > Also, I've saw similar fixes by upstream with cmake. > > What you think? Frankly, I'm open about what kind of fixes are applied. If SYSLIBS= way works for the specific port (in the case I've bitte, devel/libayatana-indicator). I'm not yet sure enough to determine what way exists and in those ways which actually works. But it would need more deeper investivations. The choices for now would be *Temporarily fix with ad-hoc way and fix again when really correct fix is found. or *Investigate from now on for logically and actually correct fix and wait until it finishes. If I myself is the maintainer and a committer, I would prefer the former way. As leaving port(s) unbuildable for a long time even though a working wourkaround is known isn't a good thing. Keeping PR as New/Open/In Progress until logically correct is found would be not too bad idea, though, pkg should be better "buildable". Regards. > > Tomoaki AOKI escreveu (segunda, 29/01/2024 à(s) > 11:11): > > > On Mon, 29 Jan 2024 09:27:02 +0000 > > Nuno Teixeira wrote: > > > > > Hello all! > > > > > > I was updating games/exult-devel and I found that build failed with: > > > > > > ld: error: undefined symbol: pthread_create > > > >>> referenced by LowLevelMidiDriver.cpp > > > >>> LowLevelMidiDriver.o:(std::__1::thread::thread > (&)(LowLevelMidiDriver*) > > > > > > > > > Related to a upstream change about threading support from C++11... > > > > > > Using LDFLAGS= -pthread fixed build and it is present in lot of ports. > > > > > > My question is if upstream could do anything to avoid this LDFLAGS > > addition. > > > This is being discussed at https://github.com/exult/exult/issues/436 > > > > > > Any sugestions are welcome! > > > > > > Thanks, > > > > > > -- > > > Nuno Teixeira > > > FreeBSD Committer (ports) > > > > Different port, but looks very similar situation with Bug 275950 [1], > > which I've filed but still not yet triaged (Status: New). > > > > > > [1] https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=275950 > > > > -- > > Tomoaki AOKI > > > > > -- > Nuno Teixeira > FreeBSD Committer (ports) -- Tomoaki AOKI