From nobody Sun Feb 25 17:53:24 2024 X-Original-To: freebsd-ports@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4TjWZV6X6Yz5BhLd for ; Sun, 25 Feb 2024 17:53:38 +0000 (UTC) (envelope-from trashcan@ellael.org) Received: from mx1.enfer-du-nord.net (mx1.enfer-du-nord.net [IPv6:2001:41d0:20a:800::464]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 4TjWZV3THqz44Zr; Sun, 25 Feb 2024 17:53:38 +0000 (UTC) (envelope-from trashcan@ellael.org) Authentication-Results: mx1.freebsd.org; none Received: from smtpclient.apple (p200300fB4f0E120120391a3a224C28cB.dip0.t-ipconnect.de [IPv6:2003:fb:4f0e:1201:2039:1a3a:224c:28cb]) (using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mx1.enfer-du-nord.net (Postfix) with ESMTPSA id 4TjWZR2cYPzrCr; Sun, 25 Feb 2024 18:53:35 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ellael.org; s=dkim; t=1708883616; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=2i41eWc/rARPF6UKsn3kKer99X4Djh0ziL0xi4kHJ4k=; b=IT3JECKcTM/VWY96r5tl6fAIfkXGmGE06r+ljpwuC/0+sf1oW81bIvjAVTsU4g6QPKc6Js MGD3aFOEtICIxsIRYWTuw8U0RqaUXwygzGfabj1S3XW/JjqZSZFtO4HKGzQ6m1WUqqsxrD oqEVdQxfaYJU0XrJTV1rjOmLcn38N/W1eSQ8oJVbt82E3QEjPG95S+DxoKdZk8KtWL8GH6 +oCeR9CYMlA0KmwzJ2KiBmldLl2fpuY89LrAbZPCENDep6hjJcBziITwnFrjF7avsOrpol u7kQEUnsJLfnfsN6PdWMfKGfSIN/Hnv9GyVTLouSGxX65eZx4jygFaSpETOwaA== Content-Type: text/plain; charset=us-ascii List-Id: Porting software to FreeBSD List-Archive: https://lists.freebsd.org/archives/freebsd-ports List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-freebsd-ports@freebsd.org X-BeenThere: freebsd-ports@freebsd.org Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3774.400.31\)) Subject: Re: dns/knot-resolver security update to 5.7.1 From: Michael Grimm In-Reply-To: Date: Sun, 25 Feb 2024 18:53:24 +0100 Cc: FreeBSD Mailing List Content-Transfer-Encoding: quoted-printable Message-Id: References: <14DA84EE-3CC0-454E-967A-CBFF40C06ABD@ellael.org> <232E3D69-782B-49A7-9B82-AA59765DA98B@freebsd.org> <689E4249-F841-4B39-94E0-F2725518BFA0@ellael.org> To: Moin Rahman X-Mailer: Apple Mail (2.3774.400.31) X-Spamd-Bar: ---- X-Rspamd-Pre-Result: action=no action; module=replies; Message is reply to one we originated X-Spamd-Result: default: False [-4.00 / 15.00]; REPLY(-4.00)[]; ASN(0.00)[asn:16276, ipnet:2001:41d0::/32, country:FR] X-Rspamd-Queue-Id: 4TjWZV3THqz44Zr Moin Rahman wrote: >> On Feb 25, 2024, at 6:15 PM, Michael Grimm = wrote: >> P.S. Please forgive my lack in experience with PRs ;-) >> Please let me know, what to correct if neccessary >=20 > Well as a starter: > 1. You do not need PORTREVISION when you already bumping PORTVERSION = or updating versions. I will fix it while committing. > 2. Follow this process: > a. Initially create the PR with synopsis and description. > b. Create git-formatted patch > c. Read this section of the documentation: > = https://docs.freebsd.org/en/articles/committers-guide/#git-mini-daily-use > d. Specially the git hook part and try to use the hook from here: > https://cgit.freebsd.org/ports/tree/.hooks/prepare-commit-msg > e. Now make a commit to your local branch with the description, PR = etc whatever is relevant. > f. Create a git formatted patch and attach it to the PR. >=20 > While people think this is difficult workflow it actually makes our = life easier as we also have to do the same and also helps us attributing = external developers more easily. Many thanks, I will follow your advice in the future! Especially about d) (hook) I have been totally unaware. Regards, Michael=