From nobody Sat Feb 17 09:29:04 2024 X-Original-To: freebsd-ports@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4TcNmF0GNHz59pWY for ; Sat, 17 Feb 2024 09:29:17 +0000 (UTC) (envelope-from eduardo@freebsd.org) Received: from smtp.freebsd.org (smtp.freebsd.org [IPv6:2610:1c1:1:606c::24b:4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "smtp.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4TcNmD6ZRfz4sDw; Sat, 17 Feb 2024 09:29:16 +0000 (UTC) (envelope-from eduardo@freebsd.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1708162156; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=pS0v7wlWjXYa2Q7/yMuVkkXvR/iCYkx5lKiRk4ty7zo=; b=Kavg1+AO711lT0Kd/k+wDH1bdwIZ4KCiRmkQZkntsUnuOnBYL6pDXhCvHhNjM95EJTfen3 xuIXylMaCN4yjccw94Nb4tVrtsVw5TSrCt5sen3G7F3LtMPw0VmLmg7MQqJ2cO2CInxc+a iwDlU3ROwtk0G3WncXRJkKHiwTtSYylSqckYozWxYxDs9zgtPu39g8+n4VLSPYlLwaM23V CJYZUy7SntEO38C4vSfjz6pYEQ4T0NE/mA4aAtmXdfria4gKT6VqfJASEjr60uZVRdg7j9 fy+xZ6zDdzhafoin3Z7mvfzaFnNr7Qz6JTRAwlskxE3ZMkfasxI7g5e4jaLFHA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1708162156; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=pS0v7wlWjXYa2Q7/yMuVkkXvR/iCYkx5lKiRk4ty7zo=; b=pL4V0SdHRLvhDzg7LuNRMt/zHevggmGNvsFjpcBydjk8znrNgV3bzFJZRK9qV8e3axUbEf SRMO6rfIQvv2qZRODxN2roYR3Jq2oUCwsxGXVvib91gg2sAozYVu3jGA/Y4sxFq7aw/OwU oKXIbu/RR51QxFMgwBx0dRO6Cm3Hp2d0osP5dddxBw9BZNvERctOmzXqEu9S2z8iaJIJ8s JNy0KInOpjdmdVbdV77ZN5iH3Z4Mb6Y4zYl62mjMuU6+B092GhvrITORaOTeuHMUzsAh5P JxYDz7z7Ybk731HJMcy9rs1JoJ4Nv8b6l115PWvJ7HmfWEVJlItzd14GZHItUg== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1708162156; a=rsa-sha256; cv=none; b=gxU1oEBlG65sI+JNwEsGzwomjyXEz2xhaxxdvrv1Oji4u/uKwLldY1w4uSRK4I9nH3RbFZ KKiJWO2RQli7mYW5ONwdmKitLeVuPA3r73Z4Tkgsf1l35S6Mp1hx4yJrjCIkOsg0awPq7G YUHFbfm8wMmqtLFE/pbZlDX+aPNs97IFfpvBK8UtMHCnP5dOxXdxBjyGgc6vQQpaM55vGl Do6dUM5j4xXq2bOLjyJ+1+HlbG9H5E6xLpaHRmZS99lwtTwi4Kaq6us5DFSg5E0ECwjg7/ Ibd45xwmO65bArY7m3LnceJvfU2cW//duIIj6hJfvuBPpm68g2+o/RIDOeKARw== Received: from mail-qt1-f179.google.com (mail-qt1-f179.google.com [209.85.160.179]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1D4" (verified OK)) (Authenticated sender: eduardo) by smtp.freebsd.org (Postfix) with ESMTPSA id 4TcNmD5MMdzhvJ; Sat, 17 Feb 2024 09:29:16 +0000 (UTC) (envelope-from eduardo@freebsd.org) Received: by mail-qt1-f179.google.com with SMTP id d75a77b69052e-42dd5c6c774so10375801cf.2; Sat, 17 Feb 2024 01:29:16 -0800 (PST) X-Gm-Message-State: AOJu0YyJMT/EKeDVrptQV4npPj+4CLcEFs8A0F8L9JxkU8RDKULwxQEx 2fKMJgExMvy5NPgkNRyiSY2gLDU07cqzHeaOwSMLdYmFMDHjjqkLZG7xCX7qWo7nOOvp2/+qDRL 8deZLlFD7nhPUz5OH6l0Z9FtEZEM= X-Google-Smtp-Source: AGHT+IGWbDAP1bm92dpfIRNV0kKRIEYGzZoHvTrt5atCpInoeQ5oIGSnU9q8ZIVgvY6S4Pt6FPsPCbwbpICGqh23ke8= X-Received: by 2002:a05:622a:1307:b0:42d:bf9c:3689 with SMTP id v7-20020a05622a130700b0042dbf9c3689mr7865498qtk.28.1708162155912; Sat, 17 Feb 2024 01:29:15 -0800 (PST) List-Id: Porting software to FreeBSD List-Archive: https://lists.freebsd.org/archives/freebsd-ports List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-freebsd-ports@freebsd.org X-BeenThere: freebsd-ports@freebsd.org MIME-Version: 1.0 References: <47C52E85-141A-4FF1-BCD2-9ACBE50CDE27@freebsd.org> <2F2001CB-8433-4B56-8303-23D3C8E40E42@freebsd.org> In-Reply-To: <2F2001CB-8433-4B56-8303-23D3C8E40E42@freebsd.org> From: Nuno Teixeira Date: Sat, 17 Feb 2024 09:29:04 +0000 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: libX changed its libnameA.h to libnameB.h To: Moin Rahman Cc: FreeBSD Mailing List Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Yes, a new api for sure. Replacing .h file: ../src/backend_libnsgif.c:17:3: error: unknown type name 'gif_animation' 17 | gif_animation gif; | ^ ../src/backend_libnsgif.c:55:8: error: unknown type name 'gif_bitmap_callback_vt' 55 | static gif_bitmap_callback_vt bitmap_callbacks =3D { | ^ ../src/backend_libnsgif.c:72:3: warning: call to undeclared function 'gif_finalise'; ISO C99 and later do not support implicit function declarations [-Wimplicit-function-declaration] 72 | gif_finalise(&private->gif); | ^ ../src/backend_libnsgif.c:100:3: error: use of undeclared identifier 'gif_result' 100 | gif_result code =3D gif_decode_frame(&private->gif, private->current_frame); | ^ ../src/backend_libnsgif.c:101:7: error: use of undeclared identifier 'code'; did you mean 'close'? 101 | if (code !=3D GIF_OK) { | ^~~~ | close /usr/include/unistd.h:324:6: note: 'close' declared here 324 | int close(int); | ^ ../src/backend_libnsgif.c:101:15: error: use of undeclared identifier 'GIF_OK'; did you mean 'NSGIF_OK'? 101 | if (code !=3D GIF_OK) { | ^~~~~~ | NSGIF_OK I will see if lib have some kind of compability with old version and if not I will disable this port option and put it as broken. Moin Rahman escreveu (s=C3=A1bado, 17/02/2024 =C3=A0(s) = 08:46): > > > > > On Feb 17, 2024, at 9:43 AM, Nuno Teixeira wrote: > > > > Hello Moin! > > > > I will try rename on src code and check if functionality is ok. > > > > Just a question: is it normal a lib do such changes? > Not at all. > > > Taking a look at changelog I can't see nothing related: > > https://www.mail-archive.com/netsurf-commits@netsurf-browser.org/msg173= 36.html > > > > It smells like new API... In that case, consumers should change to supp= ort it. > In that case you have run out of luck. :D > > > Cheers, > > > > > > Moin Rahman escreveu (s=C3=A1bado, 17/02/2024 =C3=A0= (s) 08:11): > >> > >> > >> > >>> On Feb 17, 2024, at 9:08 AM, Nuno Teixeira wrot= e: > >>> > >>> Hello all, > >>> > >>> I'm facing a build error causes from graphics/libnsgif that changed > >>> from 0.2.1 to 1.0.0: > >>> -include/libnsgif.h > >>> +include/nsgif.h > >>> > >>> Now graphics/imv complains: > >>> > >>> ./src/backend_libnsgif.c:9:10: fatal error: 'libnsgif.h' file not fou= nd > >>> 9 | #include > >>> | ^~~~~~~~~~~~ > >>> 1 error generated. > >>> > >>> While I'm looking from upstream recomendation on fix, how do I quick = fix it? > >>> Is it possible to rename libnsgif.h -> nsgif.h in source code? > >>> > >>> Also googling about this issue didn't get results since most img pkgs > >>> do not have this lib default on. > >>> > >>> Thanks, > >>> > >>> -- > >>> Nuno Teixeira > >>> FreeBSD Committer (ports) > >>> > >> > >> Depends. If the function names and arguments are also same you can jus= t > >> rename in the source code. > >> > >> > > > > > > -- > > Nuno Teixeira > > FreeBSD Committer (ports) > --=20 Nuno Teixeira FreeBSD Committer (ports)