Re: Building certain ports fails with errors in system C++ libraries

On 30 Aug 2024, at 20:45, J David <j.david.lists@gmail.com> wrote:
> 
> On Fri, Aug 30, 2024 at 2:36 PM Dimitry Andric <dim@freebsd.org> wrote:
>> Try using the attached patch.
> 
> Wow. That's... nasty... but effective. Haven't tested (I'm not the end
> user) but it does build that way. I guess it's probably safe because
> it's not like the code could have also been using std::hex somewhere.

This program is written in a bit of a weird mixed C and C++ style. It
looks like somebody tried to modernize an aging C codebase, then stopped
halfway through. :)

It is not really anything special though, there are loads of programs in
ports that have strange or sloppy coding styles. If there is still an
active upstream you can always try to prod them to fix it, but if they
are grumpy or if upstream is dead, you can either patch out all the
nastiness, or delete the port.


> Do you want to open a bug report about it? It's your patch.

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=281141

-Dimitry