From nobody Fri Apr 19 07:29:52 2024 X-Original-To: freebsd-ports@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4VLRB41Gjlz5J26k for ; Fri, 19 Apr 2024 07:30:04 +0000 (UTC) (envelope-from eduardo@freebsd.org) Received: from smtp.freebsd.org (smtp.freebsd.org [IPv6:2610:1c1:1:606c::24b:4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "smtp.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4VLRB40kxvz4X85; Fri, 19 Apr 2024 07:30:04 +0000 (UTC) (envelope-from eduardo@freebsd.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1713511804; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type; bh=gGkxZtUNW6LuGvgSzaComH0jOFwxzOe/Ol+5lFBJ344=; b=H25BvlFbJgmXfrntbfb9uO/bf6hZ7gpz2XMy8BBnXIA9bJ5hYNA5N3psCDopCkG1/oRLyd GPGENyyoNZSy42U8+HoqU7ID4GwJxfrbu+ngPGmBEFOZ5X0I1js+xcHyeaIVszxszjWMf5 +mrTKa9R+VA1rY5O+CnhluCHeNUgHafjo4Cvr7uexhrjemEOMKaG/i5PY/xVPt9A2vIgGR 7KPA7eo1S2rLSJY1B2X0EfQz8E4jYuxM9wGfJvyheZt4vSNzg54Xw1hHmnDtm+agFq1tfr Y0Jy1X9nSTnDGlrIYPvCdXoPl8GFtx1N3PqFLXYP6cX4LMa6mbBugtM4APZjTA== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1713511804; a=rsa-sha256; cv=none; b=QWoIYpt6290azmPb6mZVIcO5z5sJSE0RzDwmAftUnkI+FmlLW2hMFSN3zKy4Yh3MuDjLPQ bbZ2+4h6VasCr64/K0MAWwI44yueqAOTjzWO9IeBNvXi4BtG3PC33GEZ/yKsc6uw06PGa3 NVfUORFRkV8z4jsxIo767x43jmDCBBegZ6ZNroZG3KR1WI3wIdGbwpOu0bhFPimq7j6+5r UUckyGDoJQd+zrwpqsn1hldueJRhgRo0HP2sCl0qKcaiuNguYdtOz27cZnP660dFYLaToN 4nithgcPOSw+7nRMZatTLWYTNPYFz5KluiHsYGdOP4m9p87ifPjT7U15V8Ng0Q== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1713511804; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type; bh=gGkxZtUNW6LuGvgSzaComH0jOFwxzOe/Ol+5lFBJ344=; b=Ui8ycEfjT1MB/XiqKmFSVZNuaSXLl/cSvQpOaYsSSVdZLE5xPkqw3nmSwXTXULPJnKdXEJ hAK1iV2o8cPwLgrPH9mXB6SfKbkD/N+z9GosC3KkhsTciGMagu796zKE6d+pXgj8aHiCU5 hlp/KbyOSIAVaUNJgYp/QOu9d6Q23bI18RH88UMbxmLsBfBV5lIyilorlEmDmCSeQoQhgF Jjho/XWoR5xh2dA5u4oPMdsYHV/3WWCriULSoBImanCO6V/wtP4beoIK1F6KxEiJu5Eah6 RNp4pUVUwd+BM2eh8HOlF2XmoOV2byIsiUt+39XkXPubeu0k8JiiS+11OepQRw== Received: from mail-qt1-f174.google.com (mail-qt1-f174.google.com [209.85.160.174]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1D4" (verified OK)) (Authenticated sender: eduardo) by smtp.freebsd.org (Postfix) with ESMTPSA id 4VLRB40CnvzTq2; Fri, 19 Apr 2024 07:30:04 +0000 (UTC) (envelope-from eduardo@freebsd.org) Received: by mail-qt1-f174.google.com with SMTP id d75a77b69052e-4365c1451d4so9438781cf.2; Fri, 19 Apr 2024 00:30:03 -0700 (PDT) X-Forwarded-Encrypted: i=1; AJvYcCVztgJXgkGvMORTGE9mrUn7sAV1xFirP9R0FxbKaq/zlxYTp1wppEXgk7DfPAZ7gzcoHElLNgJw4R7wgTH5tDs= X-Gm-Message-State: AOJu0Ywrj9zuhLcTslHE7dSuWdThokbyEX82uVtcmuZaWRikzygsyx5M eDmO2D3C+kJLBleSVGVpvFvbg98SE97TafqSzOvJleUR68h3+40Xbc9ajCXPDTQHyB8rxxustVi S9b/VM9S+RTIbD8kp+1/SrjgB+tM= X-Google-Smtp-Source: AGHT+IE94Khu34DtJMebFxSEXY4ri667tz3HgHIWlFLgFL1KHL/4Ip4npYP+8KtSwek+xIRoMDGTmHUbklSpsjjqFto= X-Received: by 2002:a05:622a:1822:b0:434:7c49:a94e with SMTP id t34-20020a05622a182200b004347c49a94emr1281275qtc.27.1713511803396; Fri, 19 Apr 2024 00:30:03 -0700 (PDT) List-Id: Porting software to FreeBSD List-Archive: https://lists.freebsd.org/archives/freebsd-ports List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: freebsd-ports@freebsd.org Sender: owner-freebsd-ports@FreeBSD.org MIME-Version: 1.0 From: Nuno Teixeira Date: Fri, 19 Apr 2024 08:29:52 +0100 X-Gmail-Original-Message-ID: Message-ID: Subject: R: size of long on all supported arches To: FreeBSD Mailing List , Joseph Mingrone Content-Type: multipart/alternative; boundary="0000000000005c342906166e0ed6" --0000000000005c342906166e0ed6 Content-Type: text/plain; charset="UTF-8" Hello all, I'm testing a fix for tests on a R port (math/R-cran-RcppArmadillo): https://github.com/RcppCore/RcppArmadillo/issues/408 Resuming: test is failing because "tolerance" needs to get adjusted to work: ---- FAILED[data]: test_cube.R<44--45> call| expect_equivalent(cx_fcube_test(cplx_cube), (cplx_cube^2), tolerance = critTol) diff| Mean relative Mod difference: 1.512537e-07 ----- FAILED[data]: test_cube.R<81--82> call| expect_equivalent(as_cx_fcube(cplx_cube), (cplx_cube^2), tolerance = critTol) diff| Mean relative Mod difference: 1.512537e-07 Error: 2 out of 314 tests failed is fixed by patching: .onWindows <- .Platform$OS.type == "windows" -critTol <- if (.onWindows) 1.0e-6 else 1.5e-7 +critTol <- if (.onWindows || .Machine$sizeof.long == 4 || .Machine$sizeof.long == 8) 1.0e-6 else 1.5e-7 i.e., setting "tolerance" to 1.0e-6 value, test is ok (on systems bellow) With my hardware i7 and rpi4 I noted that long are: amd64 .Machine$sizeof.long == 8 i386 .Machine$sizeof.long == 4 aarch64 .Machine$sizeof.long == 8 armv7 .Machine$sizeof.long == 4 and suppose that is the same to all 32/64 bit supported systems? Upstream are sugesting using OS agnostic check to fix test, so, any better approach or sugestion is welcome. Thanks :) -- Nuno Teixeira FreeBSD Committer (ports) --0000000000005c342906166e0ed6 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Hello all,

I'm testing a= fix for tests on a R port (math/R-cran-RcppArmadillo):

Resuming: = test is failing because "tolerance" needs to get adjusted to work= :

---- FAILED[data]: test_cube.R<44--45>
   call| expect_equivalent(cx_fcube_test(cplx_cube), (cplx_cube^2), toleran=
ce =3D critTol)
   diff| Mean relative Mod difference: 1.512537e-07
  ----- FAILED[data]: test_cube.R<81--82>
   call| expect_equivalent(as_cx_fcube(cplx_cube), (cplx_cube^2), tolerance=
 =3D critTol)
   diff| Mean relative Mod difference: 1.512537e-07
  Error: 2 out of 314 tests failed

is fixed by patching= :

=C2=A0.onWindows <- .Platform$OS.type =3D=3D = "windows"
-critTol <- if (.onWindows) 1.0e-6 else 1.5e-7+critTol <- if (.onWindows || .Machine$sizeof.long =3D=3D 4 || .Machine= $sizeof.long =3D=3D 8) 1.0e-6 else 1.5e-7

i.e., se= tting "tolerance" to 1.0e-6 value, test is ok (on systems bellow)=

With my hardware i7 and rpi4 I noted that lon= g are:

amd64 =C2=A0 .Machine$sizeof.long =3D=3D 8<= br>i386 =C2=A0 =C2=A0.Machine$sizeof.long =3D=3D 4
aarch64 .Machine$size= of.long =3D=3D 8
armv7 =C2=A0 .Machine$sizeof.long =3D=3D 4
and suppose that is the same to all 32/64 bit supported system= s?

Upstream are sugesting using OS agnostic check = to fix test, so, any better approach or sugestion is welcome.

=
Thanks :)

-- =
Nuno = Teixeira
FreeBSD Committer (ports)
--0000000000005c342906166e0ed6--