From nobody Mon Apr 15 05:11:33 2024 X-Original-To: freebsd-ports@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4VHwJ827bDz5HmNC for ; Mon, 15 Apr 2024 05:11:36 +0000 (UTC) (envelope-from mfechner@freebsd.org) Received: from smtp.freebsd.org (smtp.freebsd.org [IPv6:2610:1c1:1:606c::24b:4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "smtp.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4VHwJ81TmQz4Yvx; Mon, 15 Apr 2024 05:11:36 +0000 (UTC) (envelope-from mfechner@freebsd.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1713157896; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=MyzZIcMWK0gAxKWvD22Bu2Mkwu9WEPHVSxIBZqwMqOM=; b=fgX9y0q78YB79Ska854u7X2vqqL7e4Z0xhLZoSP+OR8I+PE2mjnQ7+p15Qdh6A9/E2APuQ 71ABi7KutMY9cdOaajPK/JG7S8wNC+HLuIedltfVQgTjkggGc03mr7h7WGK5ycAX+GE5VB BGg+haBeQiuXZ15i5MpM0SdxlPMoLKp4kiwlQLYPNSqMFnnJ1VvddWblLmV44VX+gEXUto jM7ZVYLC/ACeBXkZJmHykAkCzyAclLYhXvO1aDWQ5T8fLAjhvSA/DM8I+pIClfoUUT6a9F hz5JcGeBffLzWi+IHN3LeLJdTZBrv3uJPbNpm6I+ANNuC4sYUzRXikKsbtcsyQ== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1713157896; a=rsa-sha256; cv=none; b=KEi2PZj5VpJtPU4/dZDWeMn4frpr2JfyIFPOksZ5ehMWi8Dli6mvBJDjVIm1o38+BiimcU MEKiwpc+YbNLScN+bkb7WkqO+p3U/b2SOkfzcs4u/GZz004X11a4n0A28Ktj1SqQTFTaXY dxeYTUC8vemLY/SVE3mXit78sEe7wAPvDSMBetyTI9mMiHFguYFtcHfxvMRM29J4ZGgCeA s4CkKlhk4X+0yirTnTXLBYfqp5U/8ogSg8/u2OiKhAMoR7/a2jl3bEfpGa3+ORdIuVuWmK BjirIIA99KXET6SsfIfD2q/9MEFuGCVq7l5QLLJkA5JhLmEvy/VjZRx2a5gnwQ== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1713157896; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=MyzZIcMWK0gAxKWvD22Bu2Mkwu9WEPHVSxIBZqwMqOM=; b=KuqiHF4r34WUHvTWewaYrzM3pHqreyf4sXqnnmm56ClrCTiCe9Kho3tC/ZlIqOP+F2d63d MJ9MwQDsqZXyXIqAHw6Nj9fBE3jka7kQlBQ/DGoFZC+b8Ag6QdxlbMg9ZsxBGfWl3ftuOu JzRtCzQAlkoB71nfmndzW6w8Wpmr2JKUxNEiWKOplWVZ7h0kTyT6MyCnXJpi/wDI039vpL bD4aFuVRiF+ubH+nbsFWTwlMhAgdvtA+t8gLsRifRqK0ztP0IJLkWaejEEL66rfBL5eWdO ObrfYf4TpYD2+hADv3ySUXUX6FxwVfvfp/dg9Syxv41L80imcjlLSUBZPA5Z5A== Received: from [192.168.0.151] (unknown [212.108.150.113]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) (Authenticated sender: mfechner) by smtp.freebsd.org (Postfix) with ESMTPSA id 4VHwJ73XvRzhGL; Mon, 15 Apr 2024 05:11:35 +0000 (UTC) (envelope-from mfechner@freebsd.org) Content-Type: multipart/alternative; boundary="------------Mx6JEZfFl1DVgeEbKL0qc5jA" Message-ID: Date: Mon, 15 Apr 2024 08:11:33 +0300 List-Id: Porting software to FreeBSD List-Archive: https://lists.freebsd.org/archives/freebsd-ports List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: freebsd-ports@freebsd.org MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: Package a second port (gitlab-ee instead of gitlab-ce) To: Gleb Popov Cc: "freebsd-ports@FreeBSD.org" References: <58745d45-46f3-4152-bc30-eee0794fe55c@freebsd.org> <0da7afa3-465f-4364-aad0-5b0932283b21@freebsd.org> Content-Language: en-US From: Matthias Fechner In-Reply-To: This is a multi-part message in MIME format. --------------Mx6JEZfFl1DVgeEbKL0qc5jA Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Am 12.04.2024 um 19:47 schrieb Gleb Popov: > The ${FLAVOR:U...} expression looks a bit weird to me. You have > FLAVOR?= ... in your Makefile, so this var can't really be undefined thanks a lot for your time having a look to it. You are right, it has as default ce defined. I simplified it now with: |.if ${FLAVOR:U} == ee| | | > Yes, see man 8 poudriere, the FLAVORS section. When running poud bulk > -a, all flavors are built. Otherwise, the behavior is controlled by > FLAVOR_DEFAULT_ALL option in the poudriere.conf thanks, I fixed it now by adding just the following two lines into my pkglist (as I do not build all ports on my local poudriere and I do not want to interfere with my other builds): www/gitlab www/gitlab@ee I think I will make the Gitlab EE port available together with the next Gitlab 16.11 upgrade. The current tests are looking nice and I think the flavor support for Gitlab is ready. Gruß Matthias -- "Programming today is a race between software engineers striving to build bigger and better idiot-proof programs, and the universe trying to produce bigger and better idiots. So far, the universe is winning." -- Rich Cook --------------Mx6JEZfFl1DVgeEbKL0qc5jA Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: 8bit
Am 12.04.2024 um 19:47 schrieb Gleb Popov:
The ${FLAVOR:U...} expression looks a bit weird to me. You have
FLAVOR?= ... in your Makefile, so this var can't really be undefined


thanks a lot for your time having a look to it.
You are right, it has as default ce defined. I simplified it now with:
.if ${FLAVOR:U} == ee


 

Yes, see man 8 poudriere, the FLAVORS section. When running poud bulk
-a, all flavors are built. Otherwise, the behavior is controlled by
FLAVOR_DEFAULT_ALL option in the poudriere.conf

thanks, I fixed it now by adding just the following two lines into my pkglist (as I do not build all ports on my local poudriere and I do not want to interfere with my other builds):
www/gitlab
www/gitlab@ee

I think I will make the Gitlab EE port available together with the next Gitlab 16.11 upgrade.
The current tests are looking nice and I think the flavor support for Gitlab is ready.

Gruß
Matthias

-- 

"Programming today is a race between software engineers striving to
build bigger and better idiot-proof programs, and the universe trying to
produce bigger and better idiots. So far, the universe is winning." --
Rich Cook
--------------Mx6JEZfFl1DVgeEbKL0qc5jA--