From nobody Fri Apr 12 19:50:01 2024 X-Original-To: ports@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4VGRx91G5Rz5G0Z8 for ; Fri, 12 Apr 2024 19:50:05 +0000 (UTC) (envelope-from matthew@matthewphillips.info) Received: from wfhigh3-smtp.messagingengine.com (wfhigh3-smtp.messagingengine.com [64.147.123.154]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 4VGRx86RPFz4W0C; Fri, 12 Apr 2024 19:50:04 +0000 (UTC) (envelope-from matthew@matthewphillips.info) Authentication-Results: mx1.freebsd.org; none Received: from compute3.internal (compute3.nyi.internal [10.202.2.43]) by mailfhigh.west.internal (Postfix) with ESMTP id 1A1C31800115; Fri, 12 Apr 2024 15:50:03 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute3.internal (MEProxy); Fri, 12 Apr 2024 15:50:03 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= matthewphillips.info; h=cc:cc:content-transfer-encoding :content-type:content-type:date:date:from:from:in-reply-to :in-reply-to:message-id:mime-version:references:reply-to:subject :subject:to:to; s=fm3; t=1712951402; x=1713037802; bh=415krdbQuE p5HCkSRew48/P2EIDQ3C3c/j6F+bLuDbU=; b=klF7Fq4hXX6mxDPBqxlqQ9XiVl fW+CUrLvUReutUUJ2kT11cJQo0Co6GicQhmuKI7eJZjCEjT2PSiqwFKNjz2yU3aJ lKMpuXewi3SbmtjyO1NprFa7DbW/Z431DtqK7NaTAeUT5ebW43WbgV/ZsrtlW31e b8Rqjc1FxX8Z3tdkOOkVpovOsBOuI+/tuzXjI5++Y481jsq+oCGE6PHvbaVnh/8E bOOh1wuyYlpLNXjurvUL+0aVCmWiQYJtSSU+4a9WMbx9HB7B3if6ebwa0KuGbetz gBFxKMQ5d3RG8ONWOMSnsOjRvuZuRsSALnxg0qE4ZGBnQ5iZxh5oYnIPUWPQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:content-type:date:date:feedback-id:feedback-id :from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:subject:subject:to:to:x-me-proxy:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm2; t=1712951402; x= 1713037802; bh=415krdbQuEp5HCkSRew48/P2EIDQ3C3c/j6F+bLuDbU=; b=Z vfeuSA1oqE11MvazX1OWOjc7dRhRTBfEYGOPJpktquXSMA7Dvkmpbd/n5KodXdQR 8S1kwtX6ZzrTlFyTlfB/yXH/deYbUWjUfVkuq9e/P39JhJ58/73u6Cvriygtvuf3 MhQmtcsh7TsAg4lep62hwM1IfRhK38nwMHKqgCqh1/yKvV/2gFdmYGiVzYKoRK6V 6zlCfRIaCl9bOOfGlFOsPjqHkoB9SHz5WjG32hXE6iQ51aAQ6P+ShR1YxaGFCoet XSj7Z/DrOHRUP0M3euBzYFUj4KMERu9noMVM7uSDdbgDE4JbQ92BHo2cUdEX+MJx kvFj/GzZTkFtdBUUUtn/Q== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvledrudeiuddgudeggecutefuodetggdotefrod ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfgh necuuegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmd enucfjughrpeffhffvvefukfhfgggtugfgjgestheksfdttddtudenucfhrhhomhepofgr thhthhgvficurfhhihhllhhiphhsuceomhgrthhthhgvfiesmhgrthhthhgvfihphhhilh hlihhpshdrihhnfhhoqeenucggtffrrghtthgvrhhnpeevjeefhfduvdejvdetgfegjedv iedugffflefgheetjeelgeduledviefhieffgfenucffohhmrghinhepihhtshgvlhhfrd htohenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpehm rghtthhhvgifsehmrghtthhhvgifphhhihhllhhiphhsrdhinhhfoh X-ME-Proxy: Feedback-ID: i4e5840b4:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Fri, 12 Apr 2024 15:50:01 -0400 (EDT) Date: Fri, 12 Apr 2024 15:50:01 -0400 From: Matthew Phillips To: Dag-Erling =?utf-8?B?U23DuHJncmF2?= Cc: Kurt Hackenberg , ports@freebsd.org Subject: Re: Confused by what make package should do Message-ID: References: <43xrg75pzztfrhlszhekdlfqyiqfmbkgimfdjosrjbbr4sjzfq@fnyqc35f6zyw> <76c14675-a782-49cc-8d61-ff96eaab83c8@panix.com> <86mspycrax.fsf@ltc.des.dev> List-Id: Porting software to FreeBSD List-Archive: https://lists.freebsd.org/archives/freebsd-ports List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: freebsd-ports@freebsd.org MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <86mspycrax.fsf@ltc.des.dev> X-Spamd-Bar: ---- X-Rspamd-Pre-Result: action=no action; module=replies; Message is reply to one we originated X-Spamd-Result: default: False [-4.00 / 15.00]; REPLY(-4.00)[]; ASN(0.00)[asn:29838, ipnet:64.147.123.0/24, country:US] X-Rspamd-Queue-Id: 4VGRx86RPFz4W0C On Fri, Apr 12, 2024 at 09:30:14PM +0200, Dag-Erling Smørgrav wrote: > Kurt Hackenberg writes: > > Matthew Phillips writes: > > > It's trying to install the port itself. To /usr/local/bin specifically. > > > It seems like it's running `make install` on the ports Makefile. > > From man ports(7): "package Make a binary package for the port. The > > port will be installed if it has not already been." > > This is both true, in that the `package` target implies the `stage` > target with does run `make install` in $WRKSRC, and highly misleading, > because the `stage` target does not install the port to your machine, > which would require superuser privileges, but to a staging directory, > which does not. The `install` target, which implies the `package` > target, uses `pkg add` to install the package to your machine. Thank you! This is the missing piece I didn't understand. It's starting to come together for me. So now I think it's a problem with the port's Makefile `install` target. The install target does this: install -m 755 snac $(PREFIX)/bin/snac So I think what I need to do is patch the Makefile to include DESTDIR like so: install -m 755 snac $(DESTDIR)$(PREFIX)/bin/snac Does that sound right?