From nobody Fri Apr 12 06:53:20 2024 X-Original-To: freebsd-ports@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4VG6hz4V4rz5Gnrc for ; Fri, 12 Apr 2024 06:53:23 +0000 (UTC) (envelope-from mat@freebsd.org) Received: from smtp.freebsd.org (smtp.freebsd.org [IPv6:2610:1c1:1:606c::24b:4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "smtp.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4VG6hz3qPPz4vg9; Fri, 12 Apr 2024 06:53:23 +0000 (UTC) (envelope-from mat@freebsd.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1712904803; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=znSYN0AcO4Wf6ICB1xOhSdtPjIV9TJDYAEm4UduQ9Q8=; b=dykIEtEYKMLp2Yel870j5h+H+5lEBlN0W68yMWvmXWoFc/nATYRpXLyDW3m7K0hDNtgDa1 fpuHdCuYv6pkaCz+JIRSSf4w/LLIfKDMSifE+Qe8EVXXmrQknOqSCXrHvTWIkArLMnADXq he9Ux3rXYWr8rBSlRdqZ491rq3yLtELZNLXABrMjbAjKKqJMN8uaS1MDi5DhIV90n6n1Y7 uYGE7OsTC8/L93CDdK2M82qjKqlcU5gvqwT1GwDy8cxEVEU7Dx8mhfAdnQBXV8uJ0NfBRN was1e1rYZr1gzAqvi+A2mB63zZvgAz9HKGXih0ivCG0CIttz+mM0Ehssa3VYRg== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1712904803; a=rsa-sha256; cv=none; b=eWB6+NQLHNZzNr0ioz9aGlC+Offv9SZYzumkKPz6e3PAduAAvGzyApEBmTJIl3J3jZ81aJ QyCmb9M8GWjuRP3D7Ix1wGcrsvqGLOsAoh5SJ5ZXT286mmv3919HM0swPhvCRMAS9Ubbpk 8qW8DyEfU6RdIEjhXd4YH9OOk7BOOfIW6glBQG8qooDJEaOn74dRLvElT+qKzSBT0W0H7+ y9jO66Fhv/e7YkCcnEAdxV6ms5+VCPQvnIteJuvhtVHI0MBtj93SbUVACa9gUdt/vUYTkh UvYHy00ayofjyXRqfRfFkrgMF4K3hXqnRICR0pRq+AQSCavY5p7asWJ1hyCBoA== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1712904803; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=znSYN0AcO4Wf6ICB1xOhSdtPjIV9TJDYAEm4UduQ9Q8=; b=oHA+Wl2VAuAVQvV6kaeXNlg6g2TQ9KkM3tHCEUt6OSPJ0mbJpY4TbXYQ5OAWKBHsb94ZUk PrYyX1YMPhwmonXKC9bNs+OtH9mABNBlxHrQHjzhMj6SWvn7GXW9XqAcKqGG0LcvPtM/Zl HkXRV/XW4BI9iZDDTTLiRVbA7q/WJI2O1MGUBu8rzw3X0R78hSxgmSwWHunwtvg9WACv0a tXOMrhEbikmK5ktUAodmqnugBmRYwzH4dpMQPfFL+I5yzcfy5ePv0uZ4AK/rTx7w7gOzFp DsmMTKn+n0bD4CHbrNV6lbNiDMUdSPUySNbeNUHKrxSH5a0pLG49cq4N+udNmQ== Received: from relay.mat.cc (eqx1.mat.cc [IPv6:2a01:678:2:200::49]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "cow.mat.cc", Issuer "R3" (verified OK)) (Authenticated sender: mat/mail) by smtp.freebsd.org (Postfix) with ESMTPSA id 4VG6hz2k09z1SM8; Fri, 12 Apr 2024 06:53:23 +0000 (UTC) (envelope-from mat@freebsd.org) Received: from aching.in.mat.cc (unknown [IPv6:2a01:e0a:836:f670:856c:1fc:4037:9edd]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (prime256v1) server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by relay.mat.cc (Postfix) with ESMTPSA id 64E1221549; Fri, 12 Apr 2024 08:53:22 +0200 (CEST) Date: Fri, 12 Apr 2024 08:53:20 +0200 From: Mathieu Arnold To: Tatsuki Makino Cc: Gleb Popov , "freebsd-ports@FreeBSD.org" Subject: Re: In some places, WITH_${feature}_PORTS doesn't work Message-ID: <6dzfc6cvav4ruai6yzeeqhy5o6pkcfxif6y5tj4vuezhay2uqe@dshkqacwra3m> References: List-Id: Porting software to FreeBSD List-Archive: https://lists.freebsd.org/archives/freebsd-ports List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-freebsd-ports@freebsd.org X-BeenThere: freebsd-ports@freebsd.org MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="fynwscg4w4xcs3bo" Content-Disposition: inline In-Reply-To: --fynwscg4w4xcs3bo Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Fri, Apr 12, 2024 at 06:31:45AM +0900, Tatsuki Makino wrote: > Gleb Popov wrote on 2024/04/12 02:57: > > Should be fixed now by > > https://cgit.FreeBSD.org/ports/commit/?id=3D665b0219e541019b849fd5a1efd= f032081dcf610 >=20 > Thank you very much. >=20 > This would mean that there is more support for the use of _WITH_${feature= } and _WITHOUT_${feature} in the future. > It is expected that an underscore should be added before the variable WIT= H, i.e., if the following part is present in individual ports. No, no, you should not do that, variables starting with an underscore are private and should not be used outside of the file they were defined in. The commits in question have been reverted and we're working on a solution. --=20 Mathieu Arnold --fynwscg4w4xcs3bo Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQITBAABCgB9FiEE9XJBpJetWizkEBUef2IOCp6dQb4FAmYY2l9fFIAAAAAALgAo aXNzdWVyLWZwckBub3RhdGlvbnMub3BlbnBncC5maWZ0aGhvcnNlbWFuLm5ldEY1 NzI0MUE0OTdBRDVBMkNFNDEwMTUxRTdGNjIwRTBBOUU5RDQxQkUACgkQf2IOCp6d Qb6Fbwv/ZwgpiCYYjQYgH6AvloknChZ017AUBdwSTG+TQRfPfImbt5nbtpUEkH84 DOMC9Dq4PF/DwqLBDa4Cc3e3wfw/d8lgkvocfv4drHzjmftgSo4M7K2jBOt2KYsy iUYHcaBniNCQK3V5XqsX8GRZbnAHA5PQVtBfZxqLKItY9p8bAHZoQxhUKxZr7vi6 b4xbdEG4JCyt31KntoX5CrIIQtP+eqpEKMG/oAG5QZBNHcdd+GzkxxiX17+DmSk0 29TvWz4+zqEQ1Xrq164DsBw9B2bIpJ5KcRcjC63QOrgzerqufBZDOPEodKMyYuEy W0yqLil8WtFsAak2lgGlXOg99NqhWDZPH/ywKt9XBokQ060giKyXyTLrIxCKCFS6 KB/a/Du76UpZ0pDND7kJixsG9W9Br8Md27ZoWrcSAKRebN+z2IySG2xG8NgLqFz+ ssjhJRzGkOIbJXSxrcBfDdXOny+gm4wILlrUr54/UUh424/km8G+slrXjJAOOr6W HrJZXW9P =WKpX -----END PGP SIGNATURE----- --fynwscg4w4xcs3bo--