In some places, WITH_${feature}_PORTS doesn't work

Reply: Gleb Popov : "Re: In some places, WITH_${feature}_PORTS doesn't work"
Go to: [ bottom of page ] [ top of archives ] [ this month ]

From: Tatsuki Makino <tatsuki_makino_at_hotmail.com>
Date: Thu, 11 Apr 2024 06:15:24 UTC

Hello.

Since everyone does not need to debug all ports, I assume the definition is made like WITH_DEBUG_PORTS+=audio/libopenshot-audio .
This has changed the variable defined from WITH_DEBUT to _WITH_DEBUG, so the part that switches when WITH_DEBUG is defined is malfunctioning.
e.g. https: //cgit.freebsd.org /ports/tree/Mk/Uses/cmake.mk?id=eafdc2db185d15b8c12e09afb24ae3c2cec65cea#n86
I feel like we could add some behavior conditional on WITH_DEBUG being defined on individual ports, but should it be _WITH_* from now on?

Regards.