From nobody Fri May 05 15:12:37 2023 X-Original-To: ports@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4QCZ1L2cdcz49RYS for ; Fri, 5 May 2023 15:12:38 +0000 (UTC) (envelope-from cperciva@freebsd.org) Received: from mail.tarsnap.com (mail.tarsnap.com [54.86.246.204]) by mx1.freebsd.org (Postfix) with SMTP id 4QCZ1L1ybmz3sHS for ; Fri, 5 May 2023 15:12:38 +0000 (UTC) (envelope-from cperciva@freebsd.org) Authentication-Results: mx1.freebsd.org; none Received: (qmail 11316 invoked from network); 5 May 2023 15:12:37 -0000 Received: from unknown (HELO dell7390.daemonology.net) (127.0.0.1) by mail.tarsnap.com with SMTP; 5 May 2023 15:12:37 -0000 Received: (qmail 9127 invoked from network); 5 May 2023 15:12:37 -0000 Received: from unknown (HELO ?127.0.0.1?) (127.0.0.1) by localhost with SMTP; 5 May 2023 15:12:37 -0000 Message-ID: <2b8b3940-4ffd-bb76-ba87-bb5d01b610a6@freebsd.org> Date: Fri, 5 May 2023 08:12:37 -0700 List-Id: Porting software to FreeBSD List-Archive: https://lists.freebsd.org/archives/freebsd-ports List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-freebsd-ports@freebsd.org X-BeenThere: freebsd-ports@freebsd.org MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; FreeBSD amd64; rv:102.0) Gecko/20100101 Thunderbird/102.9.0 Subject: Re: INDEX-12 gotten by portsnap is not updated Content-Language: en-US To: Felix Palmen , ports@freebsd.org References: <9c811d52-653b-14d7-3001-ec10046c7914@freebsd.org> <4566c4fd-690e-91e0-e2fd-1a4b419e146b@freebsd.org> <38a018a5-73d3-43a1-5ac2-fa5aeabcd44c@freebsd.org> From: Colin Percival In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Rspamd-Queue-Id: 4QCZ1L1ybmz3sHS X-Spamd-Bar: ---- X-Spamd-Result: default: False [-4.00 / 15.00]; REPLY(-4.00)[]; ASN(0.00)[asn:14618, ipnet:54.86.0.0/16, country:US] X-Rspamd-Pre-Result: action=no action; module=replies; Message is reply to one we originated X-ThisMailContainsUnwantedMimeParts: N On 5/5/23 07:53, Felix Palmen wrote: > * Colin Percival [20230505 07:46]: >> On 5/4/23 23:47, Colin Percival wrote: >>> Indeed.  I think I've fixed it by copying a newer /usr/bin/make into the >>> build environment -- I should be able to confirm whether it works soon. >> >> Confirmed, portsnap's INDEX is working again. :-) > > Thanks for letting me know! > > I think I'll still rework that particular commit, just for the sake of > readability. It *seems* the issue was older make not correctly handling > AT&T style expansions, but then, they're not that readable either ;) Older bmake handles ${FOO:%=bar%} with an empty FOO by matching % to the empty string. In 2020, NetBSD changed this to non-matching "for gmake compatibility". I don't think either approach is wrong per se, but obviously problems can arise when the behaviour changes. ;-) -- Colin Percival FreeBSD Deputy Release Engineer & EC2 platform maintainer Founder, Tarsnap | www.tarsnap.com | Online backups for the truly paranoid