From nobody Fri May 05 05:04:00 2023 X-Original-To: freebsd-ports@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4QCJWF3jy2z49ZDd for ; Fri, 5 May 2023 05:04:09 +0000 (UTC) (envelope-from kozlov@ravenloft.kiev.ua) Received: from ravenloft.kiev.ua (ravenloft.kiev.ua [46.173.149.13]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 4QCJWD74R4z3tqb for ; Fri, 5 May 2023 05:04:08 +0000 (UTC) (envelope-from kozlov@ravenloft.kiev.ua) Authentication-Results: mx1.freebsd.org; none Date: Fri, 5 May 2023 07:04:00 +0200 From: Alex Kozlov To: Derek Schrock Cc: freebsd-ports@freebsd.org Subject: Re: removing mutt patches Message-ID: <20230505050400.GA96444@ravenloft.kiev.ua> References: List-Id: Porting software to FreeBSD List-Archive: https://lists.freebsd.org/archives/freebsd-ports List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-freebsd-ports@freebsd.org X-BeenThere: freebsd-ports@freebsd.org MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Rspamd-Queue-Id: 4QCJWD74R4z3tqb X-Spamd-Bar: ---- X-Spamd-Result: default: False [-4.00 / 15.00]; REPLY(-4.00)[]; ASN(0.00)[asn:34743, ipnet:46.173.128.0/19, country:UA] X-Rspamd-Pre-Result: action=no action; module=replies; Message is reply to one we originated X-ThisMailContainsUnwantedMimeParts: N On Thu, May 04, 2023 at 06:33:05PM -0400, Derek Schrock wrote: > tl;dr Removing feature patches in mail/mutt! Do you care? > > A recent bug [1] has been created with a claim that one of the remote > patches QUOTE_PATCH [2] causes issues even without using the feature. > This patch was originally a vvv patch [3] left unmaintained then later > taken over by some capacity by va [4]. > > While it was taken over (mainly for context updates?) I don't think it's > fully maintained since there's still parts of it that fail at build > time. However, this got me thinking that maybe it's time to just drop > the quote patch all together... Thinking some more why not all remote > patches... Or maybe all patches all together. I'm not really looking to > maintain feature patches. That's best left to fight upstream to > include. > > I feel these patches were added maybe by request or maybe they were used > by the previous mail/mutt maintainers. Trying to track down some > patches removed for reasons/requests normally just lead to a > non-descriptive commit of the inclusion so this might be all > speculation. > > However, given that some of the patches are part of neomutt I think that > if you need these features you can either install that or build locally > with local patches or better yet work with upstream to include to > directly to mutt. > > I've always wanted to drop all patches since I don't use any of the > features so in turn don't have a good means to test however I've kept > them in for legacy reasons. > > Even though the mailing list will be a limited set of users I think it > might be a good (or at least the best) way to test user feedback. Maybe > poking the mutt-user mailing list too could be a good idea. > > However, with them removed it only means faster port releases and better > well tested packages. > > So do any of the ports/pkg mutt users deeply depend on any feature > patches from the port and would the world end if you didn't have them? > > [1] https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=271190 > [2] http://vc.org.ua/mutt/mutt-2.2.10.vvv.quote > [3] https://www.mutt.org.ua/download/stable/ > [4] http://vc.org.ua/mutt/ I use %I specifier from vvv.initials (QUOTE_PATCH option), but have vvv.quote commented out in the port's Makefile. I don't remember exactly why, it seems caused some formatting issues. I've no opinion about vc.greeting, patch-ifdef, patch-reverse_reply. The patch-date-conditional plus patch-dgc-deepif is a more flexible variant of patch-smartdate. The patch-maildir-mailtime is occasionally useful. The smime-sender can be safely dropped. tl;dr: I would like vvv.initials to stay. Will be nice to have maildir-mailtime, but I can live without it. I've no opinion about other patches. -- Alex