From nobody Thu May 04 22:33:05 2023 X-Original-To: freebsd-ports@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4QC7r72vr0z49fsg for ; Thu, 4 May 2023 22:33:11 +0000 (UTC) (envelope-from dereks@lifeofadishwasher.com) Received: from mail-qv1-xf31.google.com (mail-qv1-xf31.google.com [IPv6:2607:f8b0:4864:20::f31]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1D4" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4QC7r63ghdz3rtY for ; Thu, 4 May 2023 22:33:10 +0000 (UTC) (envelope-from dereks@lifeofadishwasher.com) Authentication-Results: mx1.freebsd.org; dkim=pass header.d=lifeofadishwasher.com header.s=google header.b=RwPVv8qU; spf=none (mx1.freebsd.org: domain of dereks@lifeofadishwasher.com has no SPF policy when checking 2607:f8b0:4864:20::f31) smtp.mailfrom=dereks@lifeofadishwasher.com; dmarc=none Received: by mail-qv1-xf31.google.com with SMTP id 6a1803df08f44-61a62fc8b5bso8888776d6.2 for ; Thu, 04 May 2023 15:33:10 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=lifeofadishwasher.com; s=google; t=1683239588; x=1685831588; h=content-disposition:mime-version:mail-followup-to:message-id :subject:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=j2AsbraQTCn8to62awvzelMf7u1proN99KxG86/RTvY=; b=RwPVv8qUCSHY8t9srS5zJBl1eaRor1wCYtLsobVwQ88BnopPOGWUzOmpe3ZfEXG3O/ RE/G9uD4lNG/0ErTu7Onlbmv570O6Z2f0SH1cTZNaID8rrv3UtU62rB7QUdv1GZhHizF 29eod474RO+0ZTVPl5jEBGEfWAsqlCREzj4Ts= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1683239588; x=1685831588; h=content-disposition:mime-version:mail-followup-to:message-id :subject:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=j2AsbraQTCn8to62awvzelMf7u1proN99KxG86/RTvY=; b=WIbrAGlEOdZZV9GmfmAPz8IqppyZDMqrAVsOLKWEkeC0KStnDh0POXiZzreruKi1mI xmXsR9mEalIWnL769pyyBO48WaSWT6TEhpiaDxfH5nX8bHP49eGqr1bNSYZFfUwzaEfW Ihqaa1zHG9VZ674z1kiaxLCc2yJqvrkUJOTeDCKpxz1UvQ3aoIJMcD0JS30IEPHk0/PQ MblAUJ1BelCOzPPdyaaiMMQNjdyq90QYHSonH6lNzMSVxO77jD7wvgkfV/U7BGSE7RJq u9fMFdyGE64qUrFJCunZJEWm/APKYiKXCv/l5K/dRid1zmIZYk7eVTXUID1mfofVZPVU XMaA== X-Gm-Message-State: AC+VfDx9lP+xszNSzODCtmfCICZjKoX4SjZChZUdH9IhbxuSM5wGybz7 kPJVcoqscI/ss6wtiD8b1/Fpknh7q5TJN/MGLNbbcw== X-Google-Smtp-Source: ACHHUZ4bR0WsA4lZmTLGMNCXbQ0lQ2DRvZBPQCdblI6ige0b7UgDGSzcuAzgIvEB185d6BnFtL9Xew== X-Received: by 2002:a05:6214:20ad:b0:61b:6e43:b20 with SMTP id 13-20020a05621420ad00b0061b6e430b20mr12625126qvd.42.1683239588248; Thu, 04 May 2023 15:33:08 -0700 (PDT) Received: from lifeofadishwasher.com ([2601:547:900:2410:51e5:f7b1:fa25:b9e2]) by smtp.gmail.com with ESMTPSA id o5-20020a05620a110500b0074df1d74841sm131130qkk.72.2023.05.04.15.33.06 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 04 May 2023 15:33:07 -0700 (PDT) Received: by lifeofadishwasher.com (sSMTP sendmail emulation); Thu, 04 May 2023 18:33:05 -0400 Date: Thu, 4 May 2023 18:33:05 -0400 From: Derek Schrock To: freebsd-ports@freebsd.org Subject: removing mutt patches Message-ID: Mail-Followup-To: freebsd-ports@freebsd.org List-Id: Porting software to FreeBSD List-Archive: https://lists.freebsd.org/archives/freebsd-ports List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-freebsd-ports@freebsd.org X-BeenThere: freebsd-ports@freebsd.org MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline X-Spamd-Result: default: False [-3.30 / 15.00]; NEURAL_HAM_LONG(-1.00)[-1.000]; NEURAL_HAM_MEDIUM(-1.00)[-1.000]; NEURAL_HAM_SHORT(-1.00)[-0.995]; R_DKIM_ALLOW(-0.20)[lifeofadishwasher.com:s=google]; MIME_GOOD(-0.10)[text/plain]; R_SPF_NA(0.00)[no SPF record]; RCVD_IN_DNSWL_NONE(0.00)[2607:f8b0:4864:20::f31:from]; MLMMJ_DEST(0.00)[freebsd-ports@freebsd.org]; RCVD_VIA_SMTP_AUTH(0.00)[]; FROM_EQ_ENVFROM(0.00)[]; DMARC_NA(0.00)[lifeofadishwasher.com]; RCVD_TLS_LAST(0.00)[]; DKIM_TRACE(0.00)[lifeofadishwasher.com:+]; RCVD_COUNT_THREE(0.00)[4]; MIME_TRACE(0.00)[0:+]; FROM_HAS_DN(0.00)[]; ARC_NA(0.00)[]; MID_RHS_MATCH_FROMTLD(0.00)[]; TO_MATCH_ENVRCPT_ALL(0.00)[]; TO_DN_NONE(0.00)[]; PREVIOUSLY_DELIVERED(0.00)[freebsd-ports@freebsd.org]; RCPT_COUNT_ONE(0.00)[1]; ASN(0.00)[asn:15169, ipnet:2607:f8b0::/32, country:US] X-Rspamd-Queue-Id: 4QC7r63ghdz3rtY X-Spamd-Bar: --- X-ThisMailContainsUnwantedMimeParts: N tl;dr Removing feature patches in mail/mutt! Do you care? A recent bug [1] has been created with a claim that one of the remote patches QUOTE_PATCH [2] causes issues even without using the feature. This patch was originally a vvv patch [3] left unmaintained then later taken over by some capacity by va [4]. While it was taken over (mainly for context updates?) I don't think it's fully maintained since there's still parts of it that fail at build time. However, this got me thinking that maybe it's time to just drop the quote patch all together... Thinking some more why not all remote patches... Or maybe all patches all together. I'm not really looking to maintain feature patches. That's best left to fight upstream to include. I feel these patches were added maybe by request or maybe they were used by the previous mail/mutt maintainers. Trying to track down some patches removed for reasons/requests normally just lead to a non-descriptive commit of the inclusion so this might be all speculation. However, given that some of the patches are part of neomutt I think that if you need these features you can either install that or build locally with local patches or better yet work with upstream to include to directly to mutt. I've always wanted to drop all patches since I don't use any of the features so in turn don't have a good means to test however I've kept them in for legacy reasons. Even though the mailing list will be a limited set of users I think it might be a good (or at least the best) way to test user feedback. Maybe poking the mutt-user mailing list too could be a good idea. However, with them removed it only means faster port releases and better well tested packages. So do any of the ports/pkg mutt users deeply depend on any feature patches from the port and would the world end if you didn't have them? [1] https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=271190 [2] http://vc.org.ua/mutt/mutt-2.2.10.vvv.quote [3] https://www.mutt.org.ua/download/stable/ [4] http://vc.org.ua/mutt/