Re: graphics/sane-backends build failure

From: Tomoaki AOKI <junchoon_at_dec.sakura.ne.jp>
Date: Thu, 04 May 2023 01:34:47 UTC
On Thu, 04 May 2023 00:06:37 +0000
jonc@chen.org.nz wrote:

> May 4, 2023 10:36 AM, "Vladimir Druzenko" <vvd@freebsd.org> wrote:
> 
> > 04.05.2023 00:22, jonc@chen.org.nz пишет:
> > 
> >> Hi,
> >> 
> >> After the update to 1.2.1, graphics/sane-backends is currently failing on STABLE/13 during the
> >> 'package' phase with:
> >> 
> >> ===> Building package for sane-backends-1.2.1
> >> pkg-static: Unable to access file
> >> /construction/xports/graphics/sane-backends/work/stage/usr/local/share/doc/sane-backends/plustek/Mak
> >> Module.sh:No such file or directory
> >> pkg-static: Unable to access file
> >> /construction/xports/graphics/sane-backends/work/stage/usr/local/share/doc/sane-backends/plustek/Mak
> >> file.kernel24:No such file or directory
> >> pkg-static: Unable to access file
> >> /construction/xports/graphics/sane-backends/work/stage/usr/local/share/doc/sane-backends/plustek/Mak
> >> file.kernel26:No such file or directory
> >> *** Error code 1
> >> 
> >> --
> >> Jonathan Chen <jonc@chen.org.nz>
> > 
> > Hi
> > 
> > This is non-default option DOCS.
> 
> This fix works, but I do not have any port-specific options set for graphics/sane-backends; but for some reason, DOCS=on is set when I build the port.
> 
> If I have read bsd.options.mk correctly, DOCS is always enabled by default?
> 
> Cheers.
> --
> Jonathan Chen <jonc@chen.org.nz>

Reproduced, and confirmed fixed by vvd@'s patch.

For DOCS option, it's described as default in Chapter 5.14.1.3 of
Porter's Handbook. [1]

If you are building with BATCH defined (like by poudriere), and if
you've never saved options manually, DOCS option would be automatically
picked. This can be avoided if you run `make config` in the specific
port's directory and forcibly save the default option and any options
you want to override.

In this case, by default,
if /var/db/ports/graphics_sane-backends/options exists, options are
taken from there and system defaults are overridden. If none, system
default would override ports default.


[1]
https://docs.freebsd.org/en/books/porters-handbook/makefiles/#makefile-options

-- 
Tomoaki AOKI    <junchoon@dec.sakura.ne.jp>