From nobody Tue Jul 25 07:59:19 2023 X-Original-To: freebsd-ports@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4R98ZC3bQ3z4pwts for ; Tue, 25 Jul 2023 07:59:31 +0000 (UTC) (envelope-from eduardo@freebsd.org) Received: from smtp.freebsd.org (smtp.freebsd.org [IPv6:2610:1c1:1:606c::24b:4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "smtp.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4R98ZC1MNvz3rMN; Tue, 25 Jul 2023 07:59:31 +0000 (UTC) (envelope-from eduardo@freebsd.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1690271971; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=i/tGXU+QdEgTHkhWIZEmrVHnjp00fP79CDkoVKNhBr8=; b=ry8f3lz7BV0OAmELs5EDLqe0g9kCvrzwRK/RLUhe8+kqkOBGeqU0rZ04X+mCf+o3l/G4LI eZlyoNL9hSiaTpEZaBDVToMYgkYfLTUOjV6jA4PtY0OLghhJ4bwsUUO3XsiOjdCNyicOI/ PAXshWADpJBCLxygRmYK8oe7Jw90HdK2OeoLEs5p+/seYyBN5f7ofo/t/juaWKo2Z6igKf hIfv9sdePQOp6ryY/3U3Gg9wxrj+J9Afo8jrIP2+dlU/6z3ojF+wXgxJcL5l1pijOnPs6D L4iuE0TLkilUN1fDAdAid23Q2XLbej2MzAMD/67JASCZPZaCLQU3/Qtfb4s69w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1690271971; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=i/tGXU+QdEgTHkhWIZEmrVHnjp00fP79CDkoVKNhBr8=; b=YBO5PEEa1dPI42HIc4QTcR6sGwSgzcvPWRkLy3uaiAWL/N4HXxJyrZTln6Yx8zg66bHGkn sIP+PFkZOzXKAa0Rof0ErdBUa5jfbEuoAb0WevxyAmJm5/v130+Sje1eqsIuSLUbLLVhWP l9YmNHI1Sb9rkJPuSlxBFSECfOBjc/zL+eb0PJjnW9nYm/lOUoJaMIaduWSK5j6qJupOPB B7ORtoSd0lo1DmwbcPDaN78mlcL5zVlwrHa4b6+4l1bcPTHHPxfYcrpJdtDB+dh/4v5Nki eRDpwjTHuwrDFeiqGX8aXFTxTCXE6IZPk6xlnmqNz4BD73SFdlpen5s5ewqDmw== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1690271971; a=rsa-sha256; cv=none; b=CMXMXn1FrJrPtheSGIz6jnnpLOmtAVQuGT04xtD4lOH8e8CP5w1l2VW4GT/HO7Ly9hpxJt KdajyixZSDEx17poYJCfkYiLtRhmSgWyTSGBNYQFqXnxWIbiA/nPYQPzTrWJ54YLGEoApE W3VmAaU7GglkIs7vLxbxiY+KSZlKFWDag8G7cdsF79NaWaG8wAgkAut7gB5Cis1iSwFYxC DgNUdDU/w23eJgvbWlH7t3lzsvYoMYuWAMKc88HArycB38FEgEHpd4vUt9ZSKRQ809qW2I T+zxIP+RxudT+esSNETTl2kdMtyZBkVg3d2TWinzTeAOjmmTeZs9vvqmGhL1Uw== Received: from mail-qt1-f170.google.com (mail-qt1-f170.google.com [209.85.160.170]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1D4" (verified OK)) (Authenticated sender: eduardo) by smtp.freebsd.org (Postfix) with ESMTPSA id 4R98ZB6GcLzXD2; Tue, 25 Jul 2023 07:59:30 +0000 (UTC) (envelope-from eduardo@freebsd.org) Received: by mail-qt1-f170.google.com with SMTP id d75a77b69052e-403b3213d8aso38733451cf.0; Tue, 25 Jul 2023 00:59:30 -0700 (PDT) X-Gm-Message-State: ABy/qLZVaBwF2c2eXMhg/NjmGpA0ccL19v4P5q6ooS7Lysm3Vcx6idk2 59odnfGHVuXNlJvp918zFpT8M6PfH9PQ0GBM5d4= X-Google-Smtp-Source: APBJJlHh7BjjvgqQQv98zHmkStlXzP8VtqMP8ccCIQ2IarDW174h97rBuRQgtpXQHcQr4Pq/7Lmr1M3e2p3kNur2qik= X-Received: by 2002:a05:622a:1344:b0:403:ad13:223a with SMTP id w4-20020a05622a134400b00403ad13223amr2812369qtk.8.1690271970263; Tue, 25 Jul 2023 00:59:30 -0700 (PDT) List-Id: Porting software to FreeBSD List-Archive: https://lists.freebsd.org/archives/freebsd-ports List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-freebsd-ports@freebsd.org X-BeenThere: freebsd-ports@freebsd.org MIME-Version: 1.0 References: <06E66577-0A59-4BCD-BCD8-9C1BC2B6F17C@FreeBSD.org> <3500818A-B09B-48F1-80FD-7BC419E386BF@FreeBSD.org> In-Reply-To: From: Nuno Teixeira Date: Tue, 25 Jul 2023 08:59:19 +0100 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: www/node18 fails to build on aarch64/current To: Dimitry Andric Cc: FreeBSD Mailing List , Po-Chuan Hsieh Content-Type: multipart/alternative; boundary="0000000000005c90cb06014b1ce7" --0000000000005c90cb06014b1ce7 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Committed. https://cgit.freebsd.org/ports/commit/?id=3Da315d93d509a19c72ad9bf76a9b903e= 8f4cb6f80 Nuno Teixeira escreveu no dia sexta, 21/07/2023 =C3= =A0(s) 19:40: > https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D272645 > > Nuno Teixeira escreveu no dia segunda, 17/07/2023 > =C3=A0(s) 10:13: > >> >> Should a temporary fix to unbreak clang16 on aarch64 acceptable? >> >> # See also: https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D272013 >> # See also: >> https://chromium.googlesource.com/v8/v8.git/+/d15d49b09dc7aef9edcc4cf6a0= cb2b77a0db203f >> .if ${OPSYS} =3D=3D FreeBSD && ${OSVERSION} >=3D 1400091 && ${ARCH} =3D= =3D aarch64 >> CXXFLAGS+=3D -Wno-error=3Denum-constexpr-conversion >> .endif >> >> I think we got required info to open a PR. >> >> Dimitry Andric escreveu no dia segunda, 17/07/2023 >> =C3=A0(s) 09:48: >> >>> Probably the particular enums it complains about are only hit on >>> aarch64. It may also be that it already partially has the actual fixes = from >>> v8 for this issue: >>> >>> >>> https://chromium.googlesource.com/v8/v8.git/+/d15d49b09dc7aef9edcc4cf6a= 0cb2b77a0db203f >>> >>> -Dimitry >>> >>> > On 17 Jul 2023, at 10:33, Nuno Teixeira wrote: >>> > >>> > (...) >>> > >>> > More strange is that I can only reproduce this on aarch64. amd64 seem= s >>> to build fine... >>> > Any clues? >>> > >>> > Nuno Teixeira escreveu no dia segunda, >>> 17/07/2023 =C3=A0(s) 07:53: >>> > I can confirm that it builds. >>> > >>> > Should a PR be open or this is being taken already? >>> > >>> > Thanks, >>> > >>> > Nuno Teixeira escreveu no dia domingo, >>> 16/07/2023 =C3=A0(s) 14:24: >>> > Hello Dimitry! >>> > >>> > Thanks, I didn't see that PR since I only searched node18... >>> > >>> > I'm building it right now with: >>> > >>> > +.if ${OPSYS} =3D=3D FreeBSD && ${OSVERSION} >=3D 1400091 >>> > +CXXFLAGS+=3D -Wno-error=3Denum-constexpr-conversion >>> > +.endif >>> > >>> > Tomorrow I will have results. >>> > >>> > Thanks! >>> > >>> > Dimitry Andric escreveu no dia domingo, 16/07/2023 >>> =C3=A0(s) 14:10: >>> > On 16 Jul 2023, at 14:58, Nuno Teixeira wrote: >>> > > >>> > > main 1400093 aarch64 >>> > > >>> > > Anyone seeing www/node18 failing (needed for www/firefox)? >>> > > I tried reverting latest 2 committs and same result with 18.16.0. >>> > > >>> > > Any hints? >>> > > >>> > > https://people.freebsd.org/~eduardo/logs/node18/node18-18.16.1.log >>> > > https://people.freebsd.org/~eduardo/logs/node18/node18-18.16.0.log >>> > >>> > These are similar to , but instead >>> of properly fixing it, the can was kicked down the road in < >>> https://cgit.freebsd.org/ports/commit/?id=3Dee3e6d5a17a0c78bb56f8d5719d= e82b8dd49950d >>> >. >>> > >>> > These enums should be fixed by either removing the values outside of >>> the enum's valid range, or by specifying the enum's underlying type >>> explicitly to allow for such values. In the near future the >>> -Wno-enum-constexpr-conversion flag is going to go away! >>> > >>> > -Dimitry >>> > >>> > >>> > >>> > -- >>> > Nuno Teixeira >>> > FreeBSD Committer (ports) >>> > >>> > >>> > -- >>> > Nuno Teixeira >>> > FreeBSD Committer (ports) >>> > >>> > >>> > -- >>> > Nuno Teixeira >>> > FreeBSD Committer (ports) >>> >>> >> >> -- >> Nuno Teixeira >> FreeBSD Committer (ports) >> > > > -- > Nuno Teixeira > FreeBSD Committer (ports) > --=20 Nuno Teixeira FreeBSD Committer (ports) --0000000000005c90cb06014b1ce7 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Nuno Teixeira <eduardo@f= reebsd.org> escreveu no dia sexta, 21/07/2023 =C3=A0(s) 19:40:
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D272645<= /div>
N= uno Teixeira <e= duardo@freebsd.org> escreveu no dia segunda, 17/07/2023 =C3=A0(s) 10= :13:

Should a temporary fix to unbreak clang16 on aarc= h64 acceptable?

.if $= {OPSYS} =3D=3D FreeBSD && ${OSVERSION} >=3D 1400091 && $= {ARCH} =3D=3D aarch64
CXXFLAGS+=3D -Wno-error=3Denum-constex= pr-conversion
.endif

I think we got requ= ired info to open a PR.

Dimitry Andric <dim@freebsd.org> escreveu no dia= segunda, 17/07/2023 =C3=A0(s) 09:48:
Probably the particular enums it complains about are = only hit on aarch64. It may also be that it already partially has the actua= l fixes from v8 for this issue:

https://chromi= um.googlesource.com/v8/v8.git/+/d15d49b09dc7aef9edcc4cf6a0cb2b77a0db203f

-Dimitry

> On 17 Jul 2023, at 10:33, Nuno Teixeira <eduardo@freebsd.org> wrote:
>
> (...)
>
> More strange is that I can only reproduce this on aarch64. amd64 seems= to build fine...
> Any clues?
>
> Nuno Teixeira <eduardo@freebsd.org> escreveu no dia segunda, 17/07/2023 =C3=A0= (s) 07:53:
> I can confirm that it builds.
>
> Should a PR be open or this is being taken already?
>
> Thanks,
>
> Nuno Teixeira <eduardo@freebsd.org> escreveu no dia domingo, 16/07/2023 =C3=A0= (s) 14:24:
> Hello Dimitry!
>
> Thanks, I didn't see that PR since I only searched node18...
>
> I'm building it right now with:
>
> +.if ${OPSYS} =3D=3D FreeBSD && ${OSVERSION} >=3D 1400091 > +CXXFLAGS+=3D -Wno-error=3Denum-constexpr-conversion
> +.endif
>
> Tomorrow I will have results.
>
> Thanks!
>
> Dimitry Andric <dim@freebsd.org> escreveu no dia domingo, 16/07/2023 =C3=A0(s) 14:= 10:
> On 16 Jul 2023, at 14:58, Nuno Teixeira <eduardo@freebsd.org> wrote:
> >
> > main 1400093 aarch64
> >
> > Anyone seeing www/node18 failing (needed for www/firefox)?
> > I tried reverting latest 2 committs and same result with 18.16.0.=
> >
> > Any hints?
> >
> > https://people.freebsd.o= rg/~eduardo/logs/node18/node18-18.16.1.log
> > https://people.freebsd.o= rg/~eduardo/logs/node18/node18-18.16.0.log
>
> These are similar to <https://bugs.freebsd.org/272013>= , but instead of properly fixing it, the can was kicked down the road in &l= t;https://cgit.f= reebsd.org/ports/commit/?id=3Dee3e6d5a17a0c78bb56f8d5719de82b8dd49950d&= gt;.
>
> These enums should be fixed by either removing the values outside of t= he enum's valid range, or by specifying the enum's underlying type = explicitly to allow for such values. In the near future the -Wno-enum-const= expr-conversion flag is going to go away!
>
> -Dimitry
>
>
>
> --
> Nuno Teixeira
> FreeBSD Committer (ports)
>
>
> --
> Nuno Teixeira
> FreeBSD Committer (ports)
>
>
> --
> Nuno Teixeira
> FreeBSD Committer (ports)



--
Nuno Teixeira
FreeBSD Committ= er (ports)


--
Nuno Teixeira
FreeBSD Committ= er (ports)


--
Nuno Teixeira
FreeBSD Committ= er (ports)
--0000000000005c90cb06014b1ce7--