From nobody Fri Jul 21 18:40:03 2023 X-Original-To: freebsd-ports@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4R6yzN1zwRz4nZPL for ; Fri, 21 Jul 2023 18:40:16 +0000 (UTC) (envelope-from eduardo@freebsd.org) Received: from smtp.freebsd.org (smtp.freebsd.org [IPv6:2610:1c1:1:606c::24b:4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "smtp.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4R6yzN1SLcz4562; Fri, 21 Jul 2023 18:40:16 +0000 (UTC) (envelope-from eduardo@freebsd.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1689964816; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=JSnlTjuRDoYZqx+4T8B5IiimFPypBeIltQU7BCTYGfM=; b=TmsYaIatBLYOUo9PHKHN0RoXciDUftauad1XHwIXATSCP+KBUpkJjcE4y5jaaXezlDCnfa Kxc+L1LzLTR4QuUDZucmAFCGGNoQwbH1aSdcD3CNVmFS2vxCBWJzIXF23L4YAqpok19UTD yADOIe3nPFBDczagvE7r7lUOW/6beaBsC+25qR6sVZ5UT+Q2Y9tlbqT5gEfBbPsCritWWd PUwhzy3K8UVfsPhg5JDY8ERuV8KclFBm1nyMfCgVdKrDJtDVTVp7BJfmOUEwxLbeTk3nXH LKccCYPCRfS3+74qX/Z8WnCzxaMChrHBnWPmrjvdvQBUxvyAX5/Mh9ohuWM9fA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1689964816; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=JSnlTjuRDoYZqx+4T8B5IiimFPypBeIltQU7BCTYGfM=; b=WDpFs/grvIZDetvMAveEmm0IPwyVfLLfbAIVZABBdRpB5wLX/It7rDu8q5OzQIzhJzvW4P MD8sEQOu2FXaSgKv55TUVnXHvmV9Rjd7fC9wzDiE5xEci33Yr8rw7ISXmMCsBd2Fmd1Inj B4wvAFFcHf+ZXjmLFjBtpsUM39zS0ur5ODpkxmJUyrEBLl4pBISJXkS9Uc80rMTsewYClT /fzY+d3EgCcj8R8DLXe2XiDe9uN09yR70d3aShybZwvW/On+MbzNfcSLUO9nqvlMAnUuFN QoIcxGmU8MKIefKeV5QkLtvyC5rl1JVL+dYQ8+FEPlWG77lDPV/2OO578jBrgQ== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1689964816; a=rsa-sha256; cv=none; b=DjU4FHOF3LECFAycwhsYBoAQJey6Bf+MMFWi1Rsa1CmbCzr0UqmiFVt1E8zbAj9+f9Wo8N gxpPRVWycewiBil7mKA25xRAN22l87f2tRdXDMM/g/7WHw5Zj6EKajBIBVX39T3PFC7PHc QHpxgRxzg9kWGOgD2pVy1PSrjAKTezAcSqx+pJZ2s0fydxfYiM/sYsw3cYVY00o5WHqiF2 v4zMdYNOIjBGWaLC5V5sxhehxh6wk4LYjHVqOIkP/LrmCUOccwWvDQ1xlcrTtf636ZcMt3 iEIx1cXDXu2+PuUpoLEbCriWhSbw+jHq8fgGH6tYfVuhjZHgplgOajsDtRR54w== Received: from mail-qt1-f173.google.com (mail-qt1-f173.google.com [209.85.160.173]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1D4" (verified OK)) (Authenticated sender: eduardo) by smtp.freebsd.org (Postfix) with ESMTPSA id 4R6yzN0Nklz15TC; Fri, 21 Jul 2023 18:40:16 +0000 (UTC) (envelope-from eduardo@freebsd.org) Received: by mail-qt1-f173.google.com with SMTP id d75a77b69052e-403a3df88a8so18325901cf.3; Fri, 21 Jul 2023 11:40:16 -0700 (PDT) X-Gm-Message-State: ABy/qLYKT0BLrI94EpJW1CjeYC2JECOe4Ek//7MCKjOWtwe4ZbXu+LSA 7YjeAhPg5qwa1ZgTgGy8nVQoHLG12M9IibFa7rc= X-Google-Smtp-Source: APBJJlGPHhRkgnJVQJCfxKp9TuUIu2Rw2Sn62LEi/KCEaUp7vEIZCsuiQm2bK39vGolazim5Wl1Vx9b6AR1xzQJ1r+0= X-Received: by 2002:a05:622a:11:b0:405:46c7:d119 with SMTP id x17-20020a05622a001100b0040546c7d119mr785821qtw.45.1689964814707; Fri, 21 Jul 2023 11:40:14 -0700 (PDT) List-Id: Porting software to FreeBSD List-Archive: https://lists.freebsd.org/archives/freebsd-ports List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-freebsd-ports@freebsd.org X-BeenThere: freebsd-ports@freebsd.org MIME-Version: 1.0 References: <06E66577-0A59-4BCD-BCD8-9C1BC2B6F17C@FreeBSD.org> <3500818A-B09B-48F1-80FD-7BC419E386BF@FreeBSD.org> In-Reply-To: From: Nuno Teixeira Date: Fri, 21 Jul 2023 19:40:03 +0100 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: www/node18 fails to build on aarch64/current To: Dimitry Andric Cc: FreeBSD Mailing List , Po-Chuan Hsieh Content-Type: multipart/alternative; boundary="00000000000076b39106010398e6" --00000000000076b39106010398e6 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D272645 Nuno Teixeira escreveu no dia segunda, 17/07/2023 =C3=A0(s) 10:13: > > Should a temporary fix to unbreak clang16 on aarch64 acceptable? > > # See also: https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D272013 > # See also: > https://chromium.googlesource.com/v8/v8.git/+/d15d49b09dc7aef9edcc4cf6a0c= b2b77a0db203f > .if ${OPSYS} =3D=3D FreeBSD && ${OSVERSION} >=3D 1400091 && ${ARCH} =3D= =3D aarch64 > CXXFLAGS+=3D -Wno-error=3Denum-constexpr-conversion > .endif > > I think we got required info to open a PR. > > Dimitry Andric escreveu no dia segunda, 17/07/2023 =C3= =A0(s) > 09:48: > >> Probably the particular enums it complains about are only hit on aarch64= . >> It may also be that it already partially has the actual fixes from v8 fo= r >> this issue: >> >> >> https://chromium.googlesource.com/v8/v8.git/+/d15d49b09dc7aef9edcc4cf6a0= cb2b77a0db203f >> >> -Dimitry >> >> > On 17 Jul 2023, at 10:33, Nuno Teixeira wrote: >> > >> > (...) >> > >> > More strange is that I can only reproduce this on aarch64. amd64 seems >> to build fine... >> > Any clues? >> > >> > Nuno Teixeira escreveu no dia segunda, >> 17/07/2023 =C3=A0(s) 07:53: >> > I can confirm that it builds. >> > >> > Should a PR be open or this is being taken already? >> > >> > Thanks, >> > >> > Nuno Teixeira escreveu no dia domingo, >> 16/07/2023 =C3=A0(s) 14:24: >> > Hello Dimitry! >> > >> > Thanks, I didn't see that PR since I only searched node18... >> > >> > I'm building it right now with: >> > >> > +.if ${OPSYS} =3D=3D FreeBSD && ${OSVERSION} >=3D 1400091 >> > +CXXFLAGS+=3D -Wno-error=3Denum-constexpr-conversion >> > +.endif >> > >> > Tomorrow I will have results. >> > >> > Thanks! >> > >> > Dimitry Andric escreveu no dia domingo, 16/07/2023 >> =C3=A0(s) 14:10: >> > On 16 Jul 2023, at 14:58, Nuno Teixeira wrote: >> > > >> > > main 1400093 aarch64 >> > > >> > > Anyone seeing www/node18 failing (needed for www/firefox)? >> > > I tried reverting latest 2 committs and same result with 18.16.0. >> > > >> > > Any hints? >> > > >> > > https://people.freebsd.org/~eduardo/logs/node18/node18-18.16.1.log >> > > https://people.freebsd.org/~eduardo/logs/node18/node18-18.16.0.log >> > >> > These are similar to , but instead of >> properly fixing it, the can was kicked down the road in < >> https://cgit.freebsd.org/ports/commit/?id=3Dee3e6d5a17a0c78bb56f8d5719de= 82b8dd49950d >> >. >> > >> > These enums should be fixed by either removing the values outside of >> the enum's valid range, or by specifying the enum's underlying type >> explicitly to allow for such values. In the near future the >> -Wno-enum-constexpr-conversion flag is going to go away! >> > >> > -Dimitry >> > >> > >> > >> > -- >> > Nuno Teixeira >> > FreeBSD Committer (ports) >> > >> > >> > -- >> > Nuno Teixeira >> > FreeBSD Committer (ports) >> > >> > >> > -- >> > Nuno Teixeira >> > FreeBSD Committer (ports) >> >> > > -- > Nuno Teixeira > FreeBSD Committer (ports) > --=20 Nuno Teixeira FreeBSD Committer (ports) --00000000000076b39106010398e6 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
= Nuno Teixeira <eduardo@freebsd.or= g> escreveu no dia segunda, 17/07/2023 =C3=A0(s) 10:13:

Should a temporary fix to unbreak clang16 on aarch64 acceptable?

.if ${OPSYS} =3D=3D Fr= eeBSD && ${OSVERSION} >=3D 1400091 && ${ARCH} =3D=3D aar= ch64
CXXFLAGS+=3D -Wno-error=3Denum-constexpr-conversion
.endif

I think we got required info to open= a PR.

Dimitry Andric <dim@freebsd.org> escreveu no dia segunda, 17/07/2= 023 =C3=A0(s) 09:48:
Probably the particular enums it complains about are only hit on aarch= 64. It may also be that it already partially has the actual fixes from v8 f= or this issue:

https://chromi= um.googlesource.com/v8/v8.git/+/d15d49b09dc7aef9edcc4cf6a0cb2b77a0db203f

-Dimitry

> On 17 Jul 2023, at 10:33, Nuno Teixeira <eduardo@freebsd.org> wrote:
>
> (...)
>
> More strange is that I can only reproduce this on aarch64. amd64 seems= to build fine...
> Any clues?
>
> Nuno Teixeira <eduardo@freebsd.org> escreveu no dia segunda, 17/07/2023 =C3=A0= (s) 07:53:
> I can confirm that it builds.
>
> Should a PR be open or this is being taken already?
>
> Thanks,
>
> Nuno Teixeira <eduardo@freebsd.org> escreveu no dia domingo, 16/07/2023 =C3=A0= (s) 14:24:
> Hello Dimitry!
>
> Thanks, I didn't see that PR since I only searched node18...
>
> I'm building it right now with:
>
> +.if ${OPSYS} =3D=3D FreeBSD && ${OSVERSION} >=3D 1400091 > +CXXFLAGS+=3D -Wno-error=3Denum-constexpr-conversion
> +.endif
>
> Tomorrow I will have results.
>
> Thanks!
>
> Dimitry Andric <dim@freebsd.org> escreveu no dia domingo, 16/07/2023 =C3=A0(s) 14:= 10:
> On 16 Jul 2023, at 14:58, Nuno Teixeira <eduardo@freebsd.org> wrote:
> >
> > main 1400093 aarch64
> >
> > Anyone seeing www/node18 failing (needed for www/firefox)?
> > I tried reverting latest 2 committs and same result with 18.16.0.=
> >
> > Any hints?
> >
> > https://people.freebsd.o= rg/~eduardo/logs/node18/node18-18.16.1.log
> > https://people.freebsd.o= rg/~eduardo/logs/node18/node18-18.16.0.log
>
> These are similar to <https://bugs.freebsd.org/272013>= , but instead of properly fixing it, the can was kicked down the road in &l= t;https://cgit.f= reebsd.org/ports/commit/?id=3Dee3e6d5a17a0c78bb56f8d5719de82b8dd49950d&= gt;.
>
> These enums should be fixed by either removing the values outside of t= he enum's valid range, or by specifying the enum's underlying type = explicitly to allow for such values. In the near future the -Wno-enum-const= expr-conversion flag is going to go away!
>
> -Dimitry
>
>
>
> --
> Nuno Teixeira
> FreeBSD Committer (ports)
>
>
> --
> Nuno Teixeira
> FreeBSD Committer (ports)
>
>
> --
> Nuno Teixeira
> FreeBSD Committer (ports)



--
Nuno Teixeira
FreeBSD Committ= er (ports)


--
Nuno Teixeira
FreeBSD Committ= er (ports)
--00000000000076b39106010398e6--