From nobody Mon Jul 17 09:13:48 2023 X-Original-To: freebsd-ports@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4R4Gbs0Z3Cz4n7XZ for ; Mon, 17 Jul 2023 09:14:01 +0000 (UTC) (envelope-from eduardo@freebsd.org) Received: from smtp.freebsd.org (smtp.freebsd.org [IPv6:2610:1c1:1:606c::24b:4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "smtp.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4R4Gbr4RLpz42rk; Mon, 17 Jul 2023 09:14:00 +0000 (UTC) (envelope-from eduardo@freebsd.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1689585240; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=SJrqPt9ucqoHwkgKcFrIPZAL/tj67fVQCDJsqi8jqpw=; b=fBRvJlkPd/DYDp8t40IwWThdtNJRAeSZOZJK5IyfyZ3iCZno7cm5SUMhvHGrnEnrBxLEHZ V2qQhj/YKmVF4yXPfx5N5qcTzYlH4IUgxrt2nWj63b4Sb/6vD7nbgKOyZ25X0326Qrk4tC bfl2WlIOnS5TicPM4KN3fcFcJl/05tnaW9wTACP1xp1W41LvXRKYi5tq/c2vwR8XEmaG4D qQYKMRwyfBXXqEcBkL1JHhzfaiwxO0r5AMfDcO1xHJdMh2sXO5SbXT0j7AO4Np77qfT3mb ivu30KdkFfGi/onajNackeadEZy6xZT+DWrJ8YnfuH0DhAqDEDGMB/TG5Uyt7A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1689585240; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=SJrqPt9ucqoHwkgKcFrIPZAL/tj67fVQCDJsqi8jqpw=; b=AnRHOOt3TtU9yPtoCvPuZKBn28NxBd3COqTzTQp9lbgPq7Qy+X1cwHgOlRnlieADLEatev mwxZVOdM2roTRDrKZli99xsqX6t7LCvI0z9fsvWzwzmjWC7FvJSbTgIzf6+ieQzdq4g2Ik gcahld7j9Shr0YZkPbwxS/jqsBo5cSB92TD6RCQiXU3zKEcuX6xW1KdJJKJsdvrVWSi3dN kjxjlraXKwWuboMUnwHP0GlxB/+R5cmjoy1t+ssnw2MJ2y9oKJqdu0BzvLfxFPpfPUnKCf W4lPo7TVI+j+pBkC5RYBBwAvjNBs3vcxAJ8UPnWPlE1MA6BXy4mD88JJe34xhA== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1689585240; a=rsa-sha256; cv=none; b=ioXfggPrWcUWLgZQ5JJ0LoS+kBdGdVySbl+5kA4kbs3hHp0uLcnqTnYVzm+YQfocxJXLDY UKojskSntR5wpMZYspBt7ybamJd8fLDyl5TaxZKoMKlwpPmmSsgTcNO12NqyUaDXHFI9O8 C14h3XUYucokdDIgUcvDbQhdfXe5IZz+Rbxc4dSWyTka8/x2kSlOo64ko6qQKFRZrJT601 UO7T2WboBExpEvPKJ7bmUo6H5kMjHQ2Or7PJm0BtQQrd42ytjFPNlqMDL38Sz+ihzkvTqi Dx42/50z1CJRguTgP+Ws4fN4T/lWBN5DqbA6uBhjl/h5s8iedyb8QBi/W4HXng== Received: from mail-qt1-f170.google.com (mail-qt1-f170.google.com [209.85.160.170]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1D4" (verified OK)) (Authenticated sender: eduardo) by smtp.freebsd.org (Postfix) with ESMTPSA id 4R4Gbr3NMjz1Cck; Mon, 17 Jul 2023 09:14:00 +0000 (UTC) (envelope-from eduardo@freebsd.org) Received: by mail-qt1-f170.google.com with SMTP id d75a77b69052e-403f3890a8eso268171cf.3; Mon, 17 Jul 2023 02:14:00 -0700 (PDT) X-Gm-Message-State: ABy/qLYvzsx4Z1c6PBt2gF+z7SIk7z2faSDNXvKaoSWqzW0plGp22K/F WmtzYKyvKFedcLsNlMIad7Z4FHQ584oWRvPCETU= X-Google-Smtp-Source: APBJJlFKg0Dl4CQKn2czN3cFQhRcNLWlZ4ZumjJdP79LAQ6UMA3JFUAfkJikJcwKrRRrnphbGXMONE3B9eMZjVemErA= X-Received: by 2002:a05:622a:189d:b0:3f6:af5f:29a6 with SMTP id v29-20020a05622a189d00b003f6af5f29a6mr16208242qtc.33.1689585239826; Mon, 17 Jul 2023 02:13:59 -0700 (PDT) List-Id: Porting software to FreeBSD List-Archive: https://lists.freebsd.org/archives/freebsd-ports List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-freebsd-ports@freebsd.org X-BeenThere: freebsd-ports@freebsd.org MIME-Version: 1.0 References: <06E66577-0A59-4BCD-BCD8-9C1BC2B6F17C@FreeBSD.org> <3500818A-B09B-48F1-80FD-7BC419E386BF@FreeBSD.org> In-Reply-To: <3500818A-B09B-48F1-80FD-7BC419E386BF@FreeBSD.org> From: Nuno Teixeira Date: Mon, 17 Jul 2023 10:13:48 +0100 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: www/node18 fails to build on aarch64/current To: Dimitry Andric Cc: FreeBSD Mailing List , Po-Chuan Hsieh Content-Type: multipart/alternative; boundary="00000000000009a7180600ab384e" X-ThisMailContainsUnwantedMimeParts: N --00000000000009a7180600ab384e Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Should a temporary fix to unbreak clang16 on aarch64 acceptable? # See also: https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D272013 # See also: https://chromium.googlesource.com/v8/v8.git/+/d15d49b09dc7aef9edcc4cf6a0cb2= b77a0db203f .if ${OPSYS} =3D=3D FreeBSD && ${OSVERSION} >=3D 1400091 && ${ARCH} =3D=3D = aarch64 CXXFLAGS+=3D -Wno-error=3Denum-constexpr-conversion .endif I think we got required info to open a PR. Dimitry Andric escreveu no dia segunda, 17/07/2023 =C3=A0= (s) 09:48: > Probably the particular enums it complains about are only hit on aarch64. > It may also be that it already partially has the actual fixes from v8 for > this issue: > > > https://chromium.googlesource.com/v8/v8.git/+/d15d49b09dc7aef9edcc4cf6a0c= b2b77a0db203f > > -Dimitry > > > On 17 Jul 2023, at 10:33, Nuno Teixeira wrote: > > > > (...) > > > > More strange is that I can only reproduce this on aarch64. amd64 seems > to build fine... > > Any clues? > > > > Nuno Teixeira escreveu no dia segunda, 17/07/2023 > =C3=A0(s) 07:53: > > I can confirm that it builds. > > > > Should a PR be open or this is being taken already? > > > > Thanks, > > > > Nuno Teixeira escreveu no dia domingo, 16/07/2023 > =C3=A0(s) 14:24: > > Hello Dimitry! > > > > Thanks, I didn't see that PR since I only searched node18... > > > > I'm building it right now with: > > > > +.if ${OPSYS} =3D=3D FreeBSD && ${OSVERSION} >=3D 1400091 > > +CXXFLAGS+=3D -Wno-error=3Denum-constexpr-conversion > > +.endif > > > > Tomorrow I will have results. > > > > Thanks! > > > > Dimitry Andric escreveu no dia domingo, 16/07/2023 > =C3=A0(s) 14:10: > > On 16 Jul 2023, at 14:58, Nuno Teixeira wrote: > > > > > > main 1400093 aarch64 > > > > > > Anyone seeing www/node18 failing (needed for www/firefox)? > > > I tried reverting latest 2 committs and same result with 18.16.0. > > > > > > Any hints? > > > > > > https://people.freebsd.org/~eduardo/logs/node18/node18-18.16.1.log > > > https://people.freebsd.org/~eduardo/logs/node18/node18-18.16.0.log > > > > These are similar to , but instead of > properly fixing it, the can was kicked down the road in < > https://cgit.freebsd.org/ports/commit/?id=3Dee3e6d5a17a0c78bb56f8d5719de8= 2b8dd49950d > >. > > > > These enums should be fixed by either removing the values outside of th= e > enum's valid range, or by specifying the enum's underlying type explicitl= y > to allow for such values. In the near future the > -Wno-enum-constexpr-conversion flag is going to go away! > > > > -Dimitry > > > > > > > > -- > > Nuno Teixeira > > FreeBSD Committer (ports) > > > > > > -- > > Nuno Teixeira > > FreeBSD Committer (ports) > > > > > > -- > > Nuno Teixeira > > FreeBSD Committer (ports) > > --=20 Nuno Teixeira FreeBSD Committer (ports) --00000000000009a7180600ab384e Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable

Should a temporary fix to unbreak clan= g16 on aarch64 acceptable?

.if ${OPSYS} =3D=3D FreeBSD &a= mp;& ${OSVERSION} >=3D 1400091 && ${ARCH} =3D=3D aarch64
CXXFLAGS+=3D -Wno-error=3Denum-constexpr-co= nversion
.endif

I think we got required info to open a = PR.

Dimitry Andric <di= m@freebsd.org> escreveu no dia segunda, 17/07/2023 =C3=A0(s) 09:48:<= br>
Probably the par= ticular enums it complains about are only hit on aarch64. It may also be th= at it already partially has the actual fixes from v8 for this issue:

https://chromi= um.googlesource.com/v8/v8.git/+/d15d49b09dc7aef9edcc4cf6a0cb2b77a0db203f

-Dimitry

> On 17 Jul 2023, at 10:33, Nuno Teixeira <eduardo@freebsd.org> wrote:
>
> (...)
>
> More strange is that I can only reproduce this on aarch64. amd64 seems= to build fine...
> Any clues?
>
> Nuno Teixeira <eduardo@freebsd.org> escreveu no dia segunda, 17/07/2023 =C3=A0= (s) 07:53:
> I can confirm that it builds.
>
> Should a PR be open or this is being taken already?
>
> Thanks,
>
> Nuno Teixeira <eduardo@freebsd.org> escreveu no dia domingo, 16/07/2023 =C3=A0= (s) 14:24:
> Hello Dimitry!
>
> Thanks, I didn't see that PR since I only searched node18...
>
> I'm building it right now with:
>
> +.if ${OPSYS} =3D=3D FreeBSD && ${OSVERSION} >=3D 1400091 > +CXXFLAGS+=3D -Wno-error=3Denum-constexpr-conversion
> +.endif
>
> Tomorrow I will have results.
>
> Thanks!
>
> Dimitry Andric <dim@freebsd.org> escreveu no dia domingo, 16/07/2023 =C3=A0(s) 14:= 10:
> On 16 Jul 2023, at 14:58, Nuno Teixeira <eduardo@freebsd.org> wrote:
> >
> > main 1400093 aarch64
> >
> > Anyone seeing www/node18 failing (needed for www/firefox)?
> > I tried reverting latest 2 committs and same result with 18.16.0.=
> >
> > Any hints?
> >
> > https://people.freebsd.o= rg/~eduardo/logs/node18/node18-18.16.1.log
> > https://people.freebsd.o= rg/~eduardo/logs/node18/node18-18.16.0.log
>
> These are similar to <https://bugs.freebsd.org/272013>= , but instead of properly fixing it, the can was kicked down the road in &l= t;https://cgit.f= reebsd.org/ports/commit/?id=3Dee3e6d5a17a0c78bb56f8d5719de82b8dd49950d&= gt;.
>
> These enums should be fixed by either removing the values outside of t= he enum's valid range, or by specifying the enum's underlying type = explicitly to allow for such values. In the near future the -Wno-enum-const= expr-conversion flag is going to go away!
>
> -Dimitry
>
>
>
> --
> Nuno Teixeira
> FreeBSD Committer (ports)
>
>
> --
> Nuno Teixeira
> FreeBSD Committer (ports)
>
>
> --
> Nuno Teixeira
> FreeBSD Committer (ports)



--
Nuno Teixeira
FreeBSD Committ= er (ports)
--00000000000009a7180600ab384e--