From nobody Fri Jul 14 12:40:16 2023 X-Original-To: ports@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4R2WKS3YLWz4ms3P for ; Fri, 14 Jul 2023 12:40:28 +0000 (UTC) (envelope-from eduardo@freebsd.org) Received: from smtp.freebsd.org (smtp.freebsd.org [IPv6:2610:1c1:1:606c::24b:4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "smtp.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4R2WKS32lCz3yF0; Fri, 14 Jul 2023 12:40:28 +0000 (UTC) (envelope-from eduardo@freebsd.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1689338428; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=EkYTr7FP509vyPKanMv4ydGpCy6eROu2kpjjvvCg63k=; b=sYinjMKB1UbeTgpltSIwKCgyivagIiYyrLgVw47juQxnn6yWY0PbUtk8eIidErybDXwhcj R7BSs8cZ4Mp331/P5BzsbcjByBrpKssEYapExMJyb1h/3IbK7xRurE1IO2NJoZa6A+/qRJ YKyy3klTFwkHk6WCKuHFzr68ftSrV9Jl2Lt1VeyTsAaqmY4+PwZjHitsgW2ajo5DtwLTnX n9BUetcw/I0gBDLfzLc/Pvfr06pOAV/Ga+VbKJ/sK1q2gg2VIC1fJ3uG42AJWbwXMAcx5j XNPJQ9f6GbbqRISA0/xbZ7JXV8tGI3xVpbOuNBn1ypiMOYlNzOLHzEbWguR2jQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1689338428; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=EkYTr7FP509vyPKanMv4ydGpCy6eROu2kpjjvvCg63k=; b=aaumH0Amz1otI8f5Su5aKFFENBhZ8o79tESZl2HZswKFbii7sDxfiOjIa8aEfZc1eKRpEI QJnzPs2MVrWReWswt0E+bHb+Dy73/jFTG5UKk6C1tlmpmeRe6AVynP3nE0rzh5ol3Lf/nv iIU39d57o9RiUZNahPdOj9pu2XYho4soW842c7Js4euvnH0RCLt401BCT6LN1+iDL+pY0F Q+YWBa1X12lDsqmsb+lm8QnHRkLzy4uc9MC07encG6oHk9uH0XfCerW0ALo0YtCzJCssI+ YPRUzZgtDPTfJCjo15f/rkfFo8MwF1w/0QcVZDEPkw7Z3rSCzZn+mOchzfK0PA== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1689338428; a=rsa-sha256; cv=none; b=naucFOexgnzVs55w0+vWhnFASp2jcuh7p689dFX6LHjJSwM63zbQgw9xzJPIYi7ISfDwZ1 1Z8whhrCQLCbeGJCZRZJzgKLSoHnn4IohGQymoWi1P17vg4Ok9+11LAapY4WxRySmdtYjh XaSicjmQ4995SzWfExFylZWWpmiqSMBonOORaBynjjoZ0e8ihtz7ZSGp52yHQ2/oEjnQ69 /OdtkttFft3zfYl9n8AbaAfbvbI9AqkVNsv4j1INheSNbomVkLp2CWRVodAhZjYX6E9123 XILEWb/4I1eQ1OEJLyAFTaQSWxrj2oqawt2qtwY7duIxYInnle6Rwyv6AsI+lw== Received: from mail-qt1-f170.google.com (mail-qt1-f170.google.com [209.85.160.170]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1D4" (verified OK)) (Authenticated sender: eduardo) by smtp.freebsd.org (Postfix) with ESMTPSA id 4R2WKS1yL7zpcD; Fri, 14 Jul 2023 12:40:28 +0000 (UTC) (envelope-from eduardo@freebsd.org) Received: by mail-qt1-f170.google.com with SMTP id d75a77b69052e-401e23045beso15383791cf.0; Fri, 14 Jul 2023 05:40:28 -0700 (PDT) X-Gm-Message-State: ABy/qLa+sL8POxG12neVk+dENKbQ1bg+M3Y9AFAplgmsJ23FcP6n/UCu x7EkjL/QuM4WMqRJ+P1mHAIfWdmAaiO+esE+tAg= X-Google-Smtp-Source: APBJJlHm7uE/D6LneDazWGzLE48/mkBTnnAzJDZFwMKd5IqIoEf7687x8AypNzI252HZ6L72IK06JWG5NQIgGHKtbeg= X-Received: by 2002:ac8:5f4a:0:b0:403:a9aa:571f with SMTP id y10-20020ac85f4a000000b00403a9aa571fmr4829011qta.16.1689338427747; Fri, 14 Jul 2023 05:40:27 -0700 (PDT) List-Id: Porting software to FreeBSD List-Archive: https://lists.freebsd.org/archives/freebsd-ports List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-freebsd-ports@freebsd.org X-BeenThere: freebsd-ports@freebsd.org MIME-Version: 1.0 References: <88100d98-8d22-bb31-9181-dbbfb7c1a1f4@FreeBSD.org> In-Reply-To: <88100d98-8d22-bb31-9181-dbbfb7c1a1f4@FreeBSD.org> From: Nuno Teixeira Date: Fri, 14 Jul 2023 13:40:16 +0100 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: graphics/xpaint updated to latest version To: Danilo Egea Gondolfo Cc: ports@freebsd.org Content-Type: multipart/alternative; boundary="000000000000e43330060071c0b3" X-ThisMailContainsUnwantedMimeParts: N --000000000000e43330060071c0b3 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Oldest version used a patch: ### --- Makefile.in.orig 2021-08-14 14:31:15 UTC +++ Makefile.in @@ -1203,16 +1203,15 @@ messages.h: preproc messages.h: preproc ./preproc > messages.h -XPaint.ad: app-defaults - $(CC) $(CFLAGS) substads.c -o substads - cd app-defaults ; \ +XPaint.ad: substads app-defaults + (cd app-defaults ; \ ../substads -appdefs \ XPAINT_VERSION $(PACKAGE_VERSION) \ XPAINT_SHAREDIR $(SHAREDIR) \ XPAINT_PRINT_COMMAND "$(PRINT_CMD)" \ XPAINT_PRINTER_LIST "$(PRINTER_LIST)" \ XPAINT_POSTSCRIPT_VIEWER "$(POSTSCRIPT_VIEWER)" \ - XPAINT_EXTERN_VIEWER "$(EXTERN_VIEWER)" + XPAINT_EXTERN_VIEWER "$(EXTERN_VIEWER)") cp -p app-defaults/out/XPaint XPaint.ad XPaint.ad.h: substads XPaint.ad ### that I'm not using here. Maybe this is related? Could you test it? Thanks Danilo Egea Gondolfo escreveu no dia sexta, 14/07/2023 =C3=A0(s) 13:30: > On 14/07/2023 12:42, Nuno Teixeira wrote: > > Hello Danilo, > > My tests don't show that under poudriere with ALLOW_MAKE_JOBS=3Dyes on 2 > parallel jobs. > > Should we wait for build packagers to see its results? > > Thanks, > > Danilo Egea Gondolfo escreveu no dia sexta, > 14/07/2023 =C3=A0(s) 12:27: > >> On 14/07/2023 11:12, Nuno Teixeira wrote: >> >> Hello all, >> >> xpaint has been updated to lastest version. >> Try out new features! >> >> I'm working on this update for more than 1 year but only yesterday I did >> have the courage and nerves to build *all* releases until 3.1.4 as a way= to >> understand the best way to "hack" configures and Makefiles and stuff. >> >> Please give it a try and tell me if anything needs to be fixed, etc. >> >> Cheers! >> >> >> https://cgit.freebsd.org/ports/commit/?id=3D973a707c70478448af77004a07ea= b1f85c2f6757 >> >> -- >> Nuno Teixeira >> FreeBSD Committer (ports) >> >> Hi Eduardo, >> >> xpaint seems to not be multi-jobs-safe. The build will eventually fail >> with this: >> cd app-defaults ; \ >> ../substads -appdefs \ >> XPAINT_VERSION 3.1.4 \ >> XPAINT_SHAREDIR /usr/local/share/xpaint \ >> XPAINT_PRINT_COMMAND "lp -d" \ >> XPAINT_PRINTER_LIST "lpstat -p | cut -d' ' -f 2" \ >> XPAINT_POSTSCRIPT_VIEWER "evince" \ >> XPAINT_EXTERN_VIEWER "display" >> /bin/sh: ../substads: Text file busy >> gmake[1]: *** [Makefile:1205: XPaint.ad] Error 126 >> gmake[1]: *** Waiting for unfinished jobs.... >> gmake[1]: Leaving directory '/usr/ports/graphics/xpaint/work/xpaint-3.1.= 4' >> >> You might want to use MAKE_JOBS_UNSAFE=3Dyes. >> >> >> > > -- > Nuno Teixeira > FreeBSD Committer (ports) > > That's because it's a race condition :) > > See: > > [danilo@capeta /usr/ports/graphics/xpaint]$ while : ; do make clean > >/dev/null ; make >/dev/null 2>&1 ; if [ $? -ne 0 ] ; then echo 'Failed' = ; > else echo 'Worked' ; fi ; done > Worked > Worked > Failed > Worked > Worked > Worked > Worked > Worked > Worked > Worked > Worked > Worked > Failed > Worked > Worked > Worked > Worked > Worked > Worked > Worked > Failed > Failed > Worked > Worked > Worked > Worked > Worked > --=20 Nuno Teixeira FreeBSD Committer (ports) --000000000000e43330060071c0b3 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Oldest version used a patch:
###
<= div>--- Makefile.in.orig =C2=A0 =C2=A02021-08-14 14:31:15 UTC
+++ Makefi= le.in
@@ -1203,16 +1203,15 @@ messages.h: preproc
=C2=A0messages.h: p= reproc
=C2=A0 =C2=A0 =C2=A0 =C2=A0 ./preproc > messages.h

-XPa= int.ad: app-defaults
- =C2=A0 =C2=A0 =C2=A0 $(CC) $(CFLAGS) substads.c -= o substads
- =C2=A0 =C2=A0 =C2=A0 cd app-defaults ; \
+XPaint.ad: sub= stads app-defaults
+ =C2=A0 =C2=A0 =C2=A0 (cd app-defaults ; \
=C2=A0= =C2=A0 =C2=A0 =C2=A0 ../substads -appdefs \
=C2=A0 =C2=A0 =C2=A0 =C2=A0= =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 XPAINT_VERSION $(PACKAGE_VERSION= ) \
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 XPAINT_SHAREDIR $(SHAREDIR) \
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 XPAINT_PRINT_COMMAND "$(PRINT_CMD)&quo= t; \
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 XPAINT_PRINTER_LIST "$(PRINTER_LIST)" \
=C2=A0 =C2=A0 =C2= =A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 XPAINT_POSTSCRIPT_VIEW= ER "$(POSTSCRIPT_VIEWER)" \
- =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 XPAINT_EXTERN_VIEWER "$(EXTERN_VIEWER)= "
+ =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 = XPAINT_EXTERN_VIEWER "$(EXTERN_VIEWER)")
=C2=A0 =C2=A0 =C2=A0 = =C2=A0 cp -p app-defaults/out/XPaint XPaint.ad

=C2=A0XPaint.ad.h: su= bstads XPaint.ad
###

that I'm not us= ing here.
Maybe this is related? Could you test it?

Thanks

Danilo Egea Gondolfo <danilo@freebsd.org> escreveu no dia sexta, 14/07= /2023 =C3=A0(s) 13:30:
=20 =20 =20

On 14/07/2023 12:42, Nuno Teixeira wrote:

=20
Hello Danilo,

My tests don't show that under poudriere with ALLOW_MAKE_JOBS=3Dyes on 2 parallel jobs.

Should we wait for build packagers to see its results?

Thanks,

Danilo Egea Gondolfo <danilo@freebsd.org&= gt; escreveu no dia sexta, 14/07/2023 =C3=A0(s) 12:27:

On 14/07/2023 11:12, Nuno Teixeira wrote:

Hello all,

xpaint has been updated to lastest version.
Try out new features!

I'm working on this update for more than 1 year bu= t only yesterday I did have the courage and nerves to build *all* releases until 3.1.4 as a way to understand the best way to "hack" configures an= d Makefiles and stuff.

Please give it a try and tell me if anything needs to be fixed, etc.

Cheers!


--
Nuno Teixeira
FreeBSD Committer (ports)

Hi Eduardo,

xpaint seems to not be multi-jobs-safe. The build will eventually fail with this:

cd app-defaults ; \
../substads -appdefs \
=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0 XPAINT_VERSION 3.1.4 \
=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0 XPAINT_SHAREDIR /usr/local/share/xpaint \
=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0 XPAINT_PRINT_COMMAND "lp -d" \
=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0 XPAINT_PRINTER_LIST "lpstat -p | cut -d' ' -f 2" \
=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0 XPAINT_POSTSCRIPT_VIEWER "evince" \
=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0 XPAINT_EXTERN_VIEWER "display"
/bin/sh: ../substads: Text file busy
gmake[1]: *** [Makefile:1205: XPaint.ad] Error 126
gmake[1]: *** Waiting for unfinished jobs....
gmake[1]: Leaving directory '/usr/ports/graphics/xpaint/work/xpaint-3.1.4'

You might want to use MAKE_JOBS_UNSAFE=3Dyes.




--
Nuno Teixeira
FreeBSD Committer (ports)

That's because it's a race condition :)

See:

[danilo@capeta /usr/ports/graphics/xpaint]$ while : ; do make clean >/dev/null ; make >/dev/null 2>&1 ; if [ $? -ne 0 ] ; then echo 'Failed' ; else echo 'Worked' ; fi ; = done
Worked
Worked
Failed
Worked
Worked
Worked
Worked
Worked
Worked
Worked
Worked
Worked
Failed
Worked
Worked
Worked
Worked
Worked
Worked
Worked
Failed
Failed
Worked
Worked
Worked
Worked
Worked



--
Nuno Teixeira
FreeBSD Committ= er (ports)
--000000000000e43330060071c0b3--