From nobody Fri Jul 14 12:30:24 2023 X-Original-To: ports@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4R2W5v2kV9z4mnhN for ; Fri, 14 Jul 2023 12:30:27 +0000 (UTC) (envelope-from danilo@FreeBSD.org) Received: from smtp.freebsd.org (smtp.freebsd.org [96.47.72.83]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "smtp.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4R2W5t6cgPz3w7C for ; Fri, 14 Jul 2023 12:30:26 +0000 (UTC) (envelope-from danilo@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1689337826; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=zGtXzy43ZPHionLJGDizUH/fCxCjRnmT+ohMNCRfgQE=; b=lLgKjEDXi+Nq71vM54P+MJew7QHf/NPKb19g615pKIEahSvDUkHJaYS6snFnO+6CsuNm2/ ERj1u9Ki26I9dXczqeJWt33ps/e9MWp4G24/qAiNJaKFvDkZ8Nqj7q1qARJdeTCQM2Ag9M RXslFaSQ0dHGKVKaLDi6pvMuAN7tDMqXmxIZVvDuimPsSvsJS/xZhSiZli2Y+CyRPZXeEm Xg9gMgPxbVDkhxgRq0Ar6ic6p+9CG6KaDROzbFf2omlAd6zJ9RlDgS4AfPSRdAD4T5DK+a J2g68YuOuNf802UoEOZm9dli97aV61DvCHGKhg0n7C9nbGZJli1yxmvqlueedw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1689337826; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=zGtXzy43ZPHionLJGDizUH/fCxCjRnmT+ohMNCRfgQE=; b=PapA7TgmaIIg1yqsunVM/9KN95kfdVjj1Jkl5+kbEwX9GmijELtiaWTNEbOz+1ZfVkKRYm zW9bXWussNJ5uh7rsdeRw31HFHLj+MYQGFUlluT6Qc7OuDO4ed1THMoi9UMCCgbhu2jMxH mLWa6s6SZyN5wFOT/Q4HomQZWMo6ZTF2UNFCUzmS3fbpX7FmiZ2vPvsLw395d2MXZxrV1I 9Dry2a/4dNkAAx8otC3lrmqXAW71wTjyBgYqDyVrxDWE1J16Xg7cPAFWfupjSHIoWYZXEy XcMOcmewt/LlDSWAEzbiS9l8C8PacI21RkRGgLZsKvwNSSJMphNUQnVufVj3fw== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1689337826; a=rsa-sha256; cv=none; b=nJJLphjN9WfuZvsbNh2TsI2j8b6YgzsovrQh8UCk3rxf/fYsTcDKv3nm7VquFrCPUFhxkh Ds+FbALEgA2AGXZZpMCZaI800oJr64kOBYM5CdeAou4eN5EnHgpF7qpvC1pX3//AaOh/zM AbQtbidVC9mdh4iVYxr/J6CM8pmwMY7/EJUL8vbRr8kBVJ40y5jqJwYeCrXjs9H4hc4Nrc WI2fqpmv5vB7P2vVvqQg84+Zyhepc3ceS7pTGZP0d+ehn84hGuDAScY2bXLAv6o6A67vOE mKMpMrA3fN0juSulD+8EqNz5RI9xWyFjiwHei62/RUdwOk1oi81I9jrXEaM+2A== Received: from [192.168.5.122] (unknown [37.228.206.65]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) (Authenticated sender: danilo) by smtp.freebsd.org (Postfix) with ESMTPSA id 4R2W5t3dTTzpBh for ; Fri, 14 Jul 2023 12:30:26 +0000 (UTC) (envelope-from danilo@FreeBSD.org) Content-Type: multipart/alternative; boundary="------------ISj97QhzviQEcFYnCsdJakpZ" Message-ID: <88100d98-8d22-bb31-9181-dbbfb7c1a1f4@FreeBSD.org> Date: Fri, 14 Jul 2023 13:30:24 +0100 List-Id: Porting software to FreeBSD List-Archive: https://lists.freebsd.org/archives/freebsd-ports List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-freebsd-ports@freebsd.org X-BeenThere: freebsd-ports@freebsd.org MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.13.0 Subject: Re: graphics/xpaint updated to latest version Content-Language: en-US To: ports@freebsd.org References: From: Danilo Egea Gondolfo In-Reply-To: X-ThisMailContainsUnwantedMimeParts: N This is a multi-part message in MIME format. --------------ISj97QhzviQEcFYnCsdJakpZ Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit On 14/07/2023 12:42, Nuno Teixeira wrote: > Hello Danilo, > > My tests don't show that under poudriere with ALLOW_MAKE_JOBS=yes on 2 > parallel jobs. > > Should we wait for build packagers to see its results? > > Thanks, > > Danilo Egea Gondolfo escreveu no dia sexta, > 14/07/2023 à(s) 12:27: > > On 14/07/2023 11:12, Nuno Teixeira wrote: > >> Hello all, >> >> xpaint has been updated to lastest version. >> Try out new features! >> >> I'm working on this update for more than 1 year but only >> yesterday I did have the courage and nerves to build *all* >> releases until 3.1.4 as a way to understand the best way to >> "hack" configures and Makefiles and stuff. >> >> Please give it a try and tell me if anything needs to be fixed, etc. >> >> Cheers! >> >> https://cgit.freebsd.org/ports/commit/?id=973a707c70478448af77004a07eab1f85c2f6757 >> >> -- >> Nuno Teixeira >> FreeBSD Committer (ports) > > Hi Eduardo, > > xpaint seems to not be multi-jobs-safe. The build will eventually > fail with this: > > cd app-defaults ; \ > ../substads -appdefs \ >             XPAINT_VERSION 3.1.4 \ >             XPAINT_SHAREDIR /usr/local/share/xpaint \ >             XPAINT_PRINT_COMMAND "lp -d" \ >             XPAINT_PRINTER_LIST "lpstat -p | cut -d' ' -f 2" \ >             XPAINT_POSTSCRIPT_VIEWER "evince" \ >             XPAINT_EXTERN_VIEWER "display" > /bin/sh: ../substads: Text file busy > gmake[1]: *** [Makefile:1205: XPaint.ad] Error 126 > gmake[1]: *** Waiting for unfinished jobs.... > gmake[1]: Leaving directory > '/usr/ports/graphics/xpaint/work/xpaint-3.1.4' > > You might want to use MAKE_JOBS_UNSAFE=yes. > > > > > -- > Nuno Teixeira > FreeBSD Committer (ports) That's because it's a race condition :) See: [danilo@capeta /usr/ports/graphics/xpaint]$ while : ; do make clean >/dev/null ; make >/dev/null 2>&1 ; if [ $? -ne 0 ] ; then echo 'Failed' ; else echo 'Worked' ; fi ; done Worked Worked Failed Worked Worked Worked Worked Worked Worked Worked Worked Worked Failed Worked Worked Worked Worked Worked Worked Worked Failed Failed Worked Worked Worked Worked Worked --------------ISj97QhzviQEcFYnCsdJakpZ Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: 8bit

On 14/07/2023 12:42, Nuno Teixeira wrote:

Hello Danilo,

My tests don't show that under poudriere with ALLOW_MAKE_JOBS=yes on 2 parallel jobs.

Should we wait for build packagers to see its results?

Thanks,

Danilo Egea Gondolfo <danilo@freebsd.org> escreveu no dia sexta, 14/07/2023 à(s) 12:27:

On 14/07/2023 11:12, Nuno Teixeira wrote:

Hello all,

xpaint has been updated to lastest version.
Try out new features!

I'm working on this update for more than 1 year but only yesterday I did have the courage and nerves to build *all* releases until 3.1.4 as a way to understand the best way to "hack" configures and Makefiles and stuff.

Please give it a try and tell me if anything needs to be fixed, etc.

Cheers!


--
Nuno Teixeira
FreeBSD Committer (ports)

Hi Eduardo,

xpaint seems to not be multi-jobs-safe. The build will eventually fail with this:

cd app-defaults ; \
../substads -appdefs \
            XPAINT_VERSION 3.1.4 \
            XPAINT_SHAREDIR /usr/local/share/xpaint \
            XPAINT_PRINT_COMMAND "lp -d" \
            XPAINT_PRINTER_LIST "lpstat -p | cut -d' ' -f 2" \
            XPAINT_POSTSCRIPT_VIEWER "evince" \
            XPAINT_EXTERN_VIEWER "display"
/bin/sh: ../substads: Text file busy
gmake[1]: *** [Makefile:1205: XPaint.ad] Error 126
gmake[1]: *** Waiting for unfinished jobs....
gmake[1]: Leaving directory '/usr/ports/graphics/xpaint/work/xpaint-3.1.4'

You might want to use MAKE_JOBS_UNSAFE=yes.




--
Nuno Teixeira
FreeBSD Committer (ports)

That's because it's a race condition :)

See:

[danilo@capeta /usr/ports/graphics/xpaint]$ while : ; do make clean >/dev/null ; make >/dev/null 2>&1 ; if [ $? -ne 0 ] ; then echo 'Failed' ; else echo 'Worked' ; fi ; done
Worked
Worked
Failed
Worked
Worked
Worked
Worked
Worked
Worked
Worked
Worked
Worked
Failed
Worked
Worked
Worked
Worked
Worked
Worked
Worked
Failed
Failed
Worked
Worked
Worked
Worked
Worked

--------------ISj97QhzviQEcFYnCsdJakpZ--