From nobody Sat Jul 08 16:10:38 2023 X-Original-To: freebsd-ports@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4QywGy1wdpz4lKqN for ; Sat, 8 Jul 2023 16:10:50 +0000 (UTC) (envelope-from eduardo@freebsd.org) Received: from smtp.freebsd.org (smtp.freebsd.org [96.47.72.83]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "smtp.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4QywGy0rkjz42Vc; Sat, 8 Jul 2023 16:10:50 +0000 (UTC) (envelope-from eduardo@freebsd.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1688832650; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=8EKqVhOzgomt3vVi1/o9W7EeaX0y6FrQMwDPl1FTIiM=; b=IUCINFL1xvqOvnwg+UydWx0vTL+I7XLLE7QAfsEiya61C7+6nFxF3BAWVTaeKhhXcKV3Wu fCdLndPJE1jJCKYEBDdo9ehQki39yD5N/L4U4gJBPpt9UcNCzoy2cf468duD+ngucC3NH+ p2TJZ3aQQcTUNFP0zYWEawa26e7qwAl0K2aUDeO7PmSVzOLIwxYli+apWNI/AhbBZzmJK8 cJ/zylIczrQHo2xxH/pSBs4t4Auy5uczez/Gso2VSa30Cb/zLq3+xWJaFa+HVZlWKVtEK1 bi53sN5Y9RbSGbyRtDfSB1m3uVC4DHLUzZZW86ghEguZTKS1OX3J71KjnT23Hg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1688832650; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=8EKqVhOzgomt3vVi1/o9W7EeaX0y6FrQMwDPl1FTIiM=; b=s18jJq3QiRzBtsSrQlRPaQuFI3C4vjwOQO9kvzCaKb07jFOMAjjeUAqdLWk1HR+4uCAwQH YdfbuD12TqNljA1Sf5lnuMHmPKvCwiq/gfje+FnM+cCfhaYf+JdqdW2g8r4kRPCtL/81vp 5aYEI7X6xHhJJ/0dJAKm2oviw5bu6BO4Re87KSB02xJqiZrQk39G1IZ81DH2jdYAN+na1I QdHuwfrB0occ5MCk0Fh98gjN4AsknU6SaVdcsTO5jJ3+SL6vzmNWtcIwPss4eg2CpyoORN AoVT48nlHzUFSR3Xopi00Wca2Ec/JT0948ITFLajXhGxXVMIFtra8ru1oquMGg== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1688832650; a=rsa-sha256; cv=none; b=U872a/77Lio0O2Uv80ad8p6BvYfAQJPhFudZKeMxkJfCgtBhZyKt4lEz6lDuuYNbcjgQuL /mMJok7ve5EHYlmEgXpx8DGQ3EeJCOvkOonFNbTQpgzfD3TipVcirW3xSVXIPnqTyJCoYc RrkqDYV3AiEb42/En6yvBpuQaEb44GF0+SYcfb0SQU8vQ3sN0FnPEyIG1XZM/vkTZH8tzE XUcHL7rjXMiESuc5qoa5MKLdam019Qkak4bEbGjUGGGL/8urchtdUF/YkSzn0w9QXwxsec NSJ0K2ALfS/3fSrbSts4O1VkdgkQFa8/w6uorne0WIfSR3uCnO7XYZo84cmQYg== Received: from mail-qt1-f172.google.com (mail-qt1-f172.google.com [209.85.160.172]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1D4" (verified OK)) (Authenticated sender: eduardo) by smtp.freebsd.org (Postfix) with ESMTPSA id 4QywGx741PzGC0; Sat, 8 Jul 2023 16:10:49 +0000 (UTC) (envelope-from eduardo@freebsd.org) Received: by mail-qt1-f172.google.com with SMTP id d75a77b69052e-403392ce2b9so24239041cf.2; Sat, 08 Jul 2023 09:10:49 -0700 (PDT) X-Gm-Message-State: ABy/qLaTNiaRJu7ZsRCFEzaBauan9GzjRQWJMuy3t9UEIjHVbkIl7kSi avjx6OI7aJY6FS/E8W07uM81lt7lxK98oQx9UWY= X-Google-Smtp-Source: APBJJlEikki7BSjGrSvMQzmhr84UFrNBN/Q/5/yiayvVegWxKOYqAl1hSp3Hgtug0qexGIXcDKARKy5QVEM9nphAS5k= X-Received: by 2002:ac8:5907:0:b0:403:929f:12e2 with SMTP id 7-20020ac85907000000b00403929f12e2mr8137289qty.49.1688832649255; Sat, 08 Jul 2023 09:10:49 -0700 (PDT) List-Id: Porting software to FreeBSD List-Archive: https://lists.freebsd.org/archives/freebsd-ports List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-freebsd-ports@freebsd.org X-BeenThere: freebsd-ports@freebsd.org MIME-Version: 1.0 References: In-Reply-To: From: Nuno Teixeira Date: Sat, 8 Jul 2023 17:10:38 +0100 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: clang-tidy not part of base To: Dimitry Andric Cc: FreeBSD Mailing List Content-Type: multipart/alternative; boundary="00000000000024e3ac05fffbfedb" X-ThisMailContainsUnwantedMimeParts: N --00000000000024e3ac05fffbfedb Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Hello Dimitry! Thanks for explanation. Having fun at https://github.com/aardappel/treesheets/pull/396 already. I digged at main src log and found that this tool have some importance: --- commit 711b35dc24a8165929a9402ff8406248b65467bc Author: Richard Yao Date: Fri Oct 14 22:46:43 2022 -0400 fm_fmri_hc_create() must call va_end() before returning clang-tidy caught this. (...) --- Cheers, Dimitry Andric escreveu no dia s=C3=A1bado, 8/07/2023 =C3= =A0(s) 15:14: > On 8 Jul 2023, at 14:38, Nuno Teixeira wrote: > > > > Recently deskutils/treesheets upstream introduced clang-tidy to cmake: > > --- > > set(CMAKE_CXX_CLANG_TIDY clang-tidy > -checks=3Dcppcoreguidelines-*,clang-analyzer-*,readability-*,performance-= *,portability-*,concurrency-*,modernize-*) > > --- > > > https://github.com/aardappel/treesheets/blob/9131048804169c448ba61900935f= f04acfb1e279/CMakeLists.txt#L63C13-L63C13 > > > > This causing build to fail because clang-tidy is not found. > > What I found is that 13 and 14 doesn't ship this program but it is > available as clang-tidy{13,15} from llvm ports. > > Theoretically we could import clang-tidy into base, at least the parts > that don't use Python, but it is better left in the llvm ports. > > > > As workaround I comment it out. > > Any sugestions on what to do, what to say to upstream? > > > > Should this be a cmake debug option? > > I guess that clang-tidy is used by the upstream maintainers, for cleaning > up the source, but it is of no use to ports builders or package end-users= . > > For the short term, I would simply comment it out. I would inform upstrea= m > that this can be problematic, and maybe put it under some sort of > "enable-maintainer-mode" option? > > -Dimitry > > --=20 Nuno Teixeira FreeBSD Committer (ports) --00000000000024e3ac05fffbfedb Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Hello Dimitry!

Thanks for ex= planation.

commit 711b35dc24= a8165929a9402ff8406248b65467bc
Author: Richard Yao <richard.yao@alumni.stonybrook.edu&g= t;
Date: =C2=A0 Fri Oct 14 22:46:43 2022 -0400

=C2=A0 =C2=A0 fm_f= mri_hc_create() must call va_end() before returning

=C2=A0 =C2=A0 cl= ang-tidy caught this.
(...)
---

Cheer= s,

Dimitry Andric <dim@freeb= sd.org> escreveu no dia s=C3=A1bado, 8/07/2023 =C3=A0(s) 15:14:
<= /div>
On 8 Jul 2023, at 14= :38, Nuno Teixeira <eduardo@freebsd.org> wrote:
>
> Recently deskutils/treesheets upstream introduced clang-tidy to cmake:=
> ---
> set(CMAKE_CXX_CLANG_TIDY clang-tidy -checks=3Dcppcoreguidelines-*,clan= g-analyzer-*,readability-*,performance-*,portability-*,concurrency-*,modern= ize-*)
> ---
> https://github.com/aardappel/treesheets/blob/91310488041= 69c448ba61900935ff04acfb1e279/CMakeLists.txt#L63C13-L63C13
>
> This causing build to fail because clang-tidy is not found.
> What I found is that 13 and 14 doesn't ship this program but it is= available as clang-tidy{13,15} from llvm ports.

Theoretically we could import clang-tidy into base, at least the parts that= don't use Python, but it is better left in the llvm ports.


> As workaround I comment it out.
> Any sugestions on what to do, what to say to upstream?
>
> Should this be a cmake debug option?

I guess that clang-tidy is used by the upstream maintainers, for cleaning u= p the source, but it is of no use to ports builders or package end-users.
For the short term, I would simply comment it out. I would inform upstream = that this can be problematic, and maybe put it under some sort of "ena= ble-maintainer-mode" option?

-Dimitry



--
Nuno Teixeira
FreeBSD Committ= er (ports)
--00000000000024e3ac05fffbfedb--